From mboxrd@z Thu Jan 1 00:00:00 1970 From: William Breathitt Gray Subject: Re: [PATCH v10 00/10] Introduce the for_each_set_clump8 macro Date: Sun, 24 Mar 2019 13:08:09 +0900 Message-ID: <20190324040704.GA8285@icarus> References: <20190322191202.GC9224@smile.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190322191202.GC9224@smile.fi.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Andy Shevchenko , Geert Uytterhoeven , Phil Reid Cc: linux-arch@vger.kernel.org, yamada.masahiro@socionext.com, linus.walleij@linaro.org, linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, bgolaszewski@baylibre.com, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org List-Id: linux-gpio@vger.kernel.org On Fri, Mar 22, 2019 at 09:12:02PM +0200, Andy Shevchenko wrote: > On Thu, Mar 14, 2019 at 09:29:32PM +0900, William Breathitt Gray wrote: > > Changes in v10: > > - Fix off-by-one error in bitmap initialization in the > > test_for_each_set_clump8 function > > - Fix typos in clump_exp array definition in test_bitmap.c ("0x28" > > should have been "0x38") > > - Utilize for_each_set_clump8 macro in intel_soc_dts_iosf.c > > One more, can you look at gen_74x164_set_multiple() ? It seems a candidate as > well, if I'm not mistaken. We can utilize the for_each_set_clump8 macro in the gen_74x164_set_multiple function, but I skipped over it earlier since I noticed it used the BITS_PER_BYTE define rather than a hardcoded 8. If it always loops 8 bits at a time, then we can use the for_each_set_clump8 macro; otherwise we would need the more generic for_each_set_clump macro to handle the non-8-bit looping cases. Will BITS_PER_BYTE always be defined as 8 bits? William Breathitt Gray > > > -- > With Best Regards, > Andy Shevchenko > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0555C43381 for ; Sun, 24 Mar 2019 04:07:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A5732148D for ; Sun, 24 Mar 2019 04:07:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IaT/xtjO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726160AbfCXEHZ (ORCPT ); Sun, 24 Mar 2019 00:07:25 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:42398 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725267AbfCXEHZ (ORCPT ); Sun, 24 Mar 2019 00:07:25 -0400 Received: by mail-pf1-f193.google.com with SMTP id r15so4087810pfn.9; Sat, 23 Mar 2019 21:07:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MRm25Mq7sSdAKcYNmsiuGnOxKdMDFRpruZX/lX+nroM=; b=IaT/xtjOaloyW34bAa8prr1vSFL8z5zVoitFhgMrIhZAQ+cSu0HB1zZBVHCoYv+IXt X0fO1NcM18c42fVhe+E+ttWvOH0zaZNffgHFstgow3a2MNlP9OIaH9TReYoJwZS6xLG9 EHrZwpHOIe/+Ts4NDO7qY72k8gCY3QgRJD/dXGty+TyFH/sqrL8WsNETLJi6/72wVIXx uzMS2jvAWa7nQR7RHPk0bXPvlbQEoSxaHk6nMn1znhJgADFMOP0TwX3cOfmbu6PswmLe 4+/uXkAf1zhG2YfZq/cZS9oHQBV+EM8bf22Yv1nZfJDc2hhGbRq4PiASuGFGZkFRgJY4 Bk3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MRm25Mq7sSdAKcYNmsiuGnOxKdMDFRpruZX/lX+nroM=; b=VSxeRfKCtRwx7XLuhaP4Y3U3sdhVOkVd/7KQwcMEuVL8sKwM8LTd3iaiJjhYaHUkN9 9hw6uF1I2j1L+X7EyF5BMr2HCg2PXzmvsYXrgnP3Ni4e5Jf1KRV4ayN9V9Ln/FNRU0zC M3uMyVEBBfPM3N2WkszLngDkducAWd1RTeQLMA/USL22e2slUFPi4Jpnk9ImYf8OH7dg znYPjPnOJRS7n1nNUqR4dGwzqKBgkUKLohMFaib0l8sS4YF1fTXmyeOlgjgerlJxycJZ Z+CePG8dKnP5/5RC17gmNad/NxAxJb2zc1PXpliT66kP89zA3L30WuDyPZoyRUPTs5s2 wOYw== X-Gm-Message-State: APjAAAXEu0XS9Q4qgLuCCGgmKDYakVFGHBlWLxRAOsq0S/k/w6pUp8wY L0od4f/zl9nY4fyaWrKbhoC6tYeA X-Google-Smtp-Source: APXvYqxTxNZC5GaWdQcMiXWbBskGUl9FQ4DFTN4XoJouQzL+/mxQrNsBNmGoPM/tpwmerdkWRkxoug== X-Received: by 2002:a17:902:42:: with SMTP id 60mr18053742pla.132.1553400443909; Sat, 23 Mar 2019 21:07:23 -0700 (PDT) Received: from icarus ([2001:268:c0a4:5125:c70:4af9:86e2:2]) by smtp.gmail.com with ESMTPSA id g13sm21638168pfm.159.2019.03.23.21.07.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 23 Mar 2019 21:07:23 -0700 (PDT) Date: Sun, 24 Mar 2019 13:08:09 +0900 From: William Breathitt Gray To: Andy Shevchenko , Geert Uytterhoeven , Phil Reid Cc: linus.walleij@linaro.org, akpm@linux-foundation.org, linux-gpio@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux@rasmusvillemoes.dk, yamada.masahiro@socionext.com, bgolaszewski@baylibre.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v10 00/10] Introduce the for_each_set_clump8 macro Message-ID: <20190324040704.GA8285@icarus> References: <20190322191202.GC9224@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190322191202.GC9224@smile.fi.intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 22, 2019 at 09:12:02PM +0200, Andy Shevchenko wrote: > On Thu, Mar 14, 2019 at 09:29:32PM +0900, William Breathitt Gray wrote: > > Changes in v10: > > - Fix off-by-one error in bitmap initialization in the > > test_for_each_set_clump8 function > > - Fix typos in clump_exp array definition in test_bitmap.c ("0x28" > > should have been "0x38") > > - Utilize for_each_set_clump8 macro in intel_soc_dts_iosf.c > > One more, can you look at gen_74x164_set_multiple() ? It seems a candidate as > well, if I'm not mistaken. We can utilize the for_each_set_clump8 macro in the gen_74x164_set_multiple function, but I skipped over it earlier since I noticed it used the BITS_PER_BYTE define rather than a hardcoded 8. If it always loops 8 bits at a time, then we can use the for_each_set_clump8 macro; otherwise we would need the more generic for_each_set_clump macro to handle the non-8-bit looping cases. Will BITS_PER_BYTE always be defined as 8 bits? William Breathitt Gray > > > -- > With Best Regards, > Andy Shevchenko > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE5C6C43381 for ; Sun, 24 Mar 2019 04:07:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8ACA22148D for ; Sun, 24 Mar 2019 04:07:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UYonj3lO"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IaT/xtjO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8ACA22148D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/SAC+xb2+3yyzzIi0hGWAPSSlk4AELeK7d4BKwS25yM=; b=UYonj3lO6U58sF q8LvYrgY1f+/qXmKLa5Ia/+YmUTPHNGo6wCLLU3l1wOVxJ15iHkNrxQuNsLVc7lEmpWUQ+Qs3UVG3 ydFjLaLhauLGUV7YHzU2cPg3utRJp9Z25wXEComfPK6w9z84QilQ3AOSvQZvgRMFE5WhkVuReJOn2 ABFLCWdaIqK/hRphS0S9HhmVqLZRXtObKU9KvTHuHqQJQ07Sq0CiGfjV1eMLrhvsPEZs4FrEcZub1 9EvJlOljc2Qrli/aeNG1JpXuDla8WgWIj3R/liD8r2utBlHqX37VyIndRB2Tv8898FrhFF6lK2ufn w+qKzYY0tl1a+6HOYwww==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h7uPy-0005uq-2Q; Sun, 24 Mar 2019 04:07:30 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h7uPu-0005tm-5g for linux-arm-kernel@lists.infradead.org; Sun, 24 Mar 2019 04:07:28 +0000 Received: by mail-pg1-x542.google.com with SMTP id y3so4121112pgk.12 for ; Sat, 23 Mar 2019 21:07:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MRm25Mq7sSdAKcYNmsiuGnOxKdMDFRpruZX/lX+nroM=; b=IaT/xtjOaloyW34bAa8prr1vSFL8z5zVoitFhgMrIhZAQ+cSu0HB1zZBVHCoYv+IXt X0fO1NcM18c42fVhe+E+ttWvOH0zaZNffgHFstgow3a2MNlP9OIaH9TReYoJwZS6xLG9 EHrZwpHOIe/+Ts4NDO7qY72k8gCY3QgRJD/dXGty+TyFH/sqrL8WsNETLJi6/72wVIXx uzMS2jvAWa7nQR7RHPk0bXPvlbQEoSxaHk6nMn1znhJgADFMOP0TwX3cOfmbu6PswmLe 4+/uXkAf1zhG2YfZq/cZS9oHQBV+EM8bf22Yv1nZfJDc2hhGbRq4PiASuGFGZkFRgJY4 Bk3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MRm25Mq7sSdAKcYNmsiuGnOxKdMDFRpruZX/lX+nroM=; b=mvKAlEbx3jIgQjTT3qgkq2KNTXTwCUR371InYdnSCT60sn7vUi2nS/DD/hYmr8I4Xn m2eZesvvKDr23rUWP8XUo1L39rm8Mc7rzSq3ubhB1J3euJM2rhZkY1ZR2UBklWaB/V5a uovbETDmVBhQhRnc2OziLQkoDzAhXDomXa1AoscSSSJCahWz0SO4XpfcnUFebB8JADme fJmo96bEphNUrhnVsU5UW7QlrO1rC5ZPDb7to+jBN1iW4HSg3lLHHXGaeH+bWUJyhYPl Lt5f4yulwqas/K3Kw+LwIrYZ2AGfmqjR3hPa2zgnpBfKUn5fd1sMOQt8VD6YNEBXlG0u kvYQ== X-Gm-Message-State: APjAAAXn62Kn2bfA3pt7d+ael6AHmqtuGpXapReWPFGEbFU+SJGCJfxg kF+LYEM44XWIOjWOCz+3XSQ= X-Google-Smtp-Source: APXvYqxTxNZC5GaWdQcMiXWbBskGUl9FQ4DFTN4XoJouQzL+/mxQrNsBNmGoPM/tpwmerdkWRkxoug== X-Received: by 2002:a17:902:42:: with SMTP id 60mr18053742pla.132.1553400443909; Sat, 23 Mar 2019 21:07:23 -0700 (PDT) Received: from icarus ([2001:268:c0a4:5125:c70:4af9:86e2:2]) by smtp.gmail.com with ESMTPSA id g13sm21638168pfm.159.2019.03.23.21.07.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 23 Mar 2019 21:07:23 -0700 (PDT) Date: Sun, 24 Mar 2019 13:08:09 +0900 From: William Breathitt Gray To: Andy Shevchenko , Geert Uytterhoeven , Phil Reid Subject: Re: [PATCH v10 00/10] Introduce the for_each_set_clump8 macro Message-ID: <20190324040704.GA8285@icarus> References: <20190322191202.GC9224@smile.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190322191202.GC9224@smile.fi.intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190323_210726_241421_788743A3 X-CRM114-Status: GOOD ( 12.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, yamada.masahiro@socionext.com, linus.walleij@linaro.org, linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, bgolaszewski@baylibre.com, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 22, 2019 at 09:12:02PM +0200, Andy Shevchenko wrote: > On Thu, Mar 14, 2019 at 09:29:32PM +0900, William Breathitt Gray wrote: > > Changes in v10: > > - Fix off-by-one error in bitmap initialization in the > > test_for_each_set_clump8 function > > - Fix typos in clump_exp array definition in test_bitmap.c ("0x28" > > should have been "0x38") > > - Utilize for_each_set_clump8 macro in intel_soc_dts_iosf.c > > One more, can you look at gen_74x164_set_multiple() ? It seems a candidate as > well, if I'm not mistaken. We can utilize the for_each_set_clump8 macro in the gen_74x164_set_multiple function, but I skipped over it earlier since I noticed it used the BITS_PER_BYTE define rather than a hardcoded 8. If it always loops 8 bits at a time, then we can use the for_each_set_clump8 macro; otherwise we would need the more generic for_each_set_clump macro to handle the non-8-bit looping cases. Will BITS_PER_BYTE always be defined as 8 bits? William Breathitt Gray > > > -- > With Best Regards, > Andy Shevchenko > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel