From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AEEEC10F00 for ; Sun, 24 Mar 2019 13:39:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 11D1D222D6 for ; Sun, 24 Mar 2019 13:39:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728745AbfCXNji (ORCPT ); Sun, 24 Mar 2019 09:39:38 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:42595 "EHLO relay11.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726970AbfCXNji (ORCPT ); Sun, 24 Mar 2019 09:39:38 -0400 Received: from localhost (lfbn-lyo-1-149-219.w86-202.abo.wanadoo.fr [86.202.231.219]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 95527100004; Sun, 24 Mar 2019 13:39:34 +0000 (UTC) Date: Sun, 24 Mar 2019 14:39:34 +0100 From: Alexandre Belloni To: Pi-Hsun Shih Cc: Eddie Huang , Sean Wang , Alessandro Zummo , Matthias Brugger , "moderated list:ARM/Mediatek RTC DRIVER" , "moderated list:ARM/Mediatek RTC DRIVER" , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" , open list Subject: Re: [PATCH] mfd: mt6397: Don't call irq_dispose_mapping. Message-ID: <20190324133934.GH30105@piout.net> References: <20190311075540.26117-1-pihsun@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190311075540.26117-1-pihsun@chromium.org> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/03/2019 15:55:40+0800, Pi-Hsun Shih wrote: > The IRQ mapping was changed to not being created in the rtc-mt6397 > driver, so the irq_dispose_mapping is no longer needed. > Also the dev_id passed to free_irq should be the same as the last > argument passed to request_threaded_irq. > This prevents a "Trying to free already-free IRQ 274" warning when > unbinding the driver. > > Fixes: e695d3a0b3b3 ("mfd: mt6397: Create irq mappings in mfd core driver") > Signed-off-by: Pi-Hsun Shih > > --- > drivers/rtc/rtc-mt6397.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH] mfd: mt6397: Don't call irq_dispose_mapping. Date: Sun, 24 Mar 2019 14:39:34 +0100 Message-ID: <20190324133934.GH30105@piout.net> References: <20190311075540.26117-1-pihsun@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190311075540.26117-1-pihsun@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Pi-Hsun Shih Cc: Eddie Huang , Sean Wang , Alessandro Zummo , Matthias Brugger , "moderated list:ARM/Mediatek RTC DRIVER" , "moderated list:ARM/Mediatek RTC DRIVER" , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" , open list List-Id: linux-mediatek@lists.infradead.org On 11/03/2019 15:55:40+0800, Pi-Hsun Shih wrote: > The IRQ mapping was changed to not being created in the rtc-mt6397 > driver, so the irq_dispose_mapping is no longer needed. > Also the dev_id passed to free_irq should be the same as the last > argument passed to request_threaded_irq. > This prevents a "Trying to free already-free IRQ 274" warning when > unbinding the driver. > > Fixes: e695d3a0b3b3 ("mfd: mt6397: Create irq mappings in mfd core driver") > Signed-off-by: Pi-Hsun Shih > > --- > drivers/rtc/rtc-mt6397.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4668C43381 for ; Sun, 24 Mar 2019 13:40:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8227A222D6 for ; Sun, 24 Mar 2019 13:40:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EaaZGhd5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8227A222D6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lrh9i2CXQNNOX1/57HKYzDcpBmQhhOLf8c3Vk1HE45g=; b=EaaZGhd5SHE8NQ QxTqCMFj/XhESwacusoLICl3nXY5Q853AcqXr3NhIrmYmTDIAcSEB6sTY1nC9+AKSgMW14aXoFzPy OgUplJyU8rKMlcNbNjXTJBJP3YV7Gk9xo4c4SjTb6thR/lFeVucID0wafaMJ6dglOsUJPe1t3BFew tbMYsTHL4xNMWfioPg3F2ozTEWtbG/ZLhuvWNDyRZkbHJmhPTRN9u0QZsuZMv0O6Lt2zTFeq6EF2v 1W2myqhF+xha5iZxtuiF4rMzTTA4U1diNxlRVd6OLAxo2dDMZmADYGvD3A3sc2I/+HBAiMLo8sLKm yb9UnJBE8NpEqJvqNbPg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h83M2-00083N-FK; Sun, 24 Mar 2019 13:40:02 +0000 Received: from relay11.mail.gandi.net ([217.70.178.231]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h83Lx-00080J-K8; Sun, 24 Mar 2019 13:39:59 +0000 Received: from localhost (lfbn-lyo-1-149-219.w86-202.abo.wanadoo.fr [86.202.231.219]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 95527100004; Sun, 24 Mar 2019 13:39:34 +0000 (UTC) Date: Sun, 24 Mar 2019 14:39:34 +0100 From: Alexandre Belloni To: Pi-Hsun Shih Subject: Re: [PATCH] mfd: mt6397: Don't call irq_dispose_mapping. Message-ID: <20190324133934.GH30105@piout.net> References: <20190311075540.26117-1-pihsun@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190311075540.26117-1-pihsun@chromium.org> User-Agent: Mutt/1.11.3 (2019-02-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190324_063957_814990_9D204C54 X-CRM114-Status: GOOD ( 11.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:REAL TIME CLOCK \(RTC\) SUBSYSTEM" , Alessandro Zummo , Sean Wang , open list , "moderated list:ARM/Mediatek RTC DRIVER" , Matthias Brugger , Eddie Huang , "moderated list:ARM/Mediatek RTC DRIVER" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/03/2019 15:55:40+0800, Pi-Hsun Shih wrote: > The IRQ mapping was changed to not being created in the rtc-mt6397 > driver, so the irq_dispose_mapping is no longer needed. > Also the dev_id passed to free_irq should be the same as the last > argument passed to request_threaded_irq. > This prevents a "Trying to free already-free IRQ 274" warning when > unbinding the driver. > > Fixes: e695d3a0b3b3 ("mfd: mt6397: Create irq mappings in mfd core driver") > Signed-off-by: Pi-Hsun Shih > > --- > drivers/rtc/rtc-mt6397.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel