From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB7BFC10F00 for ; Sun, 24 Mar 2019 14:56:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B8661222C8 for ; Sun, 24 Mar 2019 14:56:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553439385; bh=PQJlMhXx19zgnuvUPgl3Tj6OKjYdEbKrT1DRDTlEb4w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=sFfNT/rXthQh+wW3MyBCLDPco4Em757Gr81NWiF2+VZpTUueUqy9iettHciv87ev6 dljWnZVhDhB/BMoep4LnLkzOgzrq03wqllC5jx93JAJOpX7o+CcUI/ATnj/R1h+ZX3 9ivgE+FFiFuGQdVVwDVHY8YgA4cQPxrBZP/OM9EU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728697AbfCXO4Y (ORCPT ); Sun, 24 Mar 2019 10:56:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:52076 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726603AbfCXO4Y (ORCPT ); Sun, 24 Mar 2019 10:56:24 -0400 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B6C5521906; Sun, 24 Mar 2019 14:56:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553439383; bh=PQJlMhXx19zgnuvUPgl3Tj6OKjYdEbKrT1DRDTlEb4w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=keIji2J6jBhN3ZMGyT/qcLJsJ4tx+pXApBiZ8DVZ9l3QH3lpxpDEaU9UGA/YMpgzl Lcv2PwJvr58b2g8C2k4QOlSrcPHMNlLE9m9J0m6OXN9a//jwwMCLyXcpV5vj1L5nZi rIUxRILY+Wk7MWgNy3J9Bi+hrDW3nl8BhrMC8LDw= Date: Sun, 24 Mar 2019 14:56:18 +0000 From: Jonathan Cameron To: Cristian Sicilia Cc: Lars-Peter Clausen , Michael Hennerich , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/5] staging: iio: adc: Remove CamelCase notation Message-ID: <20190324145618.5df31a70@archlinux> In-Reply-To: References: X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 23 Mar 2019 20:21:49 +0100 Cristian Sicilia wrote: > Fix CamelCase naming. > > Signed-off-by: Cristian Sicilia Applied. Note that I added the part number to the titles of all these patches so that people can readily see what they are actually changing. Directory isn't very helpful when there can potentially be many 10s of drivers in there (not true in this case, but still more than 1!) Thanks, Jonathan > --- > drivers/staging/iio/adc/ad7280a.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c > index 5d848aa..c02454c 100644 > --- a/drivers/staging/iio/adc/ad7280a.c > +++ b/drivers/staging/iio/adc/ad7280a.c > @@ -917,8 +917,8 @@ static int ad7280_probe(struct spi_device *spi) > const struct ad7280_platform_data *pdata = dev_get_platdata(&spi->dev); > struct ad7280_state *st; > int ret; > - const unsigned short tACQ_ns[4] = {465, 1010, 1460, 1890}; > - const unsigned short nAVG[4] = {1, 2, 4, 8}; > + const unsigned short t_acq_ns[4] = {465, 1010, 1460, 1890}; > + const unsigned short n_avg[4] = {1, 2, 4, 8}; > struct iio_dev *indio_dev; > > indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st)); > @@ -966,10 +966,9 @@ static int ad7280_probe(struct spi_device *spi) > */ > > st->readback_delay_us = > - ((tACQ_ns[pdata->acquisition_time & 0x3] + 695) * > - (AD7280A_NUM_CH * nAVG[pdata->conversion_averaging & 0x3])) > - - tACQ_ns[pdata->acquisition_time & 0x3] + > - st->slave_num * 250; > + ((t_acq_ns[pdata->acquisition_time & 0x3] + 695) * > + (AD7280A_NUM_CH * n_avg[pdata->conversion_averaging & 0x3])) - > + t_acq_ns[pdata->acquisition_time & 0x3] + st->slave_num * 250; > > /* Convert to usecs */ > st->readback_delay_us = DIV_ROUND_UP(st->readback_delay_us, 1000);