Re: [PATCH v4 06/11] selftests/ftrace: Add error_log testcase for probe errors

[Masami Hiramatsu <mhiramat@kernel.org>]

On Sat, 23 Mar 2019 08:11:09 -0500
Tom Zanussi <zanussi@kernel.org> wrote:

> Hi Masami,
> 
> On Sat, 2019-03-23 at 19:22 +0900, Masami Hiramatsu wrote:
> > On Fri, 22 Mar 2019 10:34:32 -0500
> > Tom Zanussi <zanussi@kernel.org> wrote:
> > 
> > > From: Masami Hiramatsu <mhiramat@kernel.org>
> > > 
> > > Add error_log testcase for error logs on probe events.
> > > This tests most of error cases and checks the error position
> > > is correct.
> > > 
> > > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> > > ---
> > >  .../ftrace/test.d/kprobe/kprobe_syntax_errors.tc   | 93
> > > ++++++++++++++++++++++
> > >  .../ftrace/test.d/kprobe/uprobe_syntax_errors.tc   | 31 ++++++++
> > >  2 files changed, 124 insertions(+)
> > >  create mode 100644
> > > tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.t
> > > c
> > >  create mode 100644
> > > tools/testing/selftests/ftrace/test.d/kprobe/uprobe_syntax_errors.t
> > > c
> > > 
> > > diff --git
> > > a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors
> > > .tc
> > > b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors
> > > .tc
> > > new file mode 100644
> > > index 000000000000..281665b1348c
> > > --- /dev/null
> > > +++
> > > b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors
> > > .tc
> > > @@ -0,0 +1,93 @@
> > > +#!/bin/sh
> > > +# SPDX-License-Identifier: GPL-2.0
> > > +# description: Kprobe event parser error log check
> > > +
> > > +[ -f kprobe_events ] || exit_unsupported # this is configurable
> > > +
> > > +[ -f error_log ] || exit_unsupported
> > > +
> > > +check_error() { # command-with-error-pos-by-^
> > > +pos=$(echo -n "${1%^*}" | wc -c) # error position
> > > +command=$(echo "$1" | tr -d ^)
> > > +echo "Test command: $command"
> > > +echo > error_log
> > > +(! echo "$command" > kprobe_events ) >& /dev/null
> > 
> > Oops, this one. This must be
> > 
> > (! echo "$command" > kprobe_events ) > /dev/null 2>&1
> > 
> > [...]
> > > diff --git
> > > a/tools/testing/selftests/ftrace/test.d/kprobe/uprobe_syntax_errors
> > > .tc
> > > b/tools/testing/selftests/ftrace/test.d/kprobe/uprobe_syntax_errors
> > > .tc
> > > new file mode 100644
> > > index 000000000000..957011300bb7
> > > --- /dev/null
> > > +++
> > > b/tools/testing/selftests/ftrace/test.d/kprobe/uprobe_syntax_errors
> > > .tc
> > > @@ -0,0 +1,31 @@
> > > +#!/bin/sh
> > > +# SPDX-License-Identifier: GPL-2.0
> > > +# description: Uprobe event parser error log check
> > > +
> > > +[ -f uprobe_events ] || exit_unsupported # this is configurable
> > > +
> > > +[ -f error_log ] || exit_unsupported
> > > +
> > > +check_error() { # command-with-error-pos-by-^
> > > +pos=$(echo -n "${1%^*}" | wc -c) # error position
> > > +command=$(echo "$1" | tr -d ^)
> > > +echo "Test command: $command"
> > > +echo > error_log
> > > +(! echo "$command" > uprobe_events ) >& /dev/null
> > 
> > Here too.
> > 
> > Tom, if you don't mind, could you update it when you update
> > the series? Or should I resend it?
> > 
> 
> I can just change it in the next update.  I assume 2> as in the other
> patch?

Yes, that is better, since stdout goes to [ku]probe_event file.

Thank you!


-- 
Masami Hiramatsu <mhiramat@kernel.org>