From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70D31C43381 for ; Sun, 24 Mar 2019 18:29:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D66D2082C for ; Sun, 24 Mar 2019 18:28:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727726AbfCXS26 (ORCPT ); Sun, 24 Mar 2019 14:28:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34546 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726347AbfCXS26 (ORCPT ); Sun, 24 Mar 2019 14:28:58 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4ED20308425C; Sun, 24 Mar 2019 18:28:58 +0000 (UTC) Received: from carbon (ovpn-200-46.brq.redhat.com [10.40.200.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5F3EF600C2; Sun, 24 Mar 2019 18:28:54 +0000 (UTC) Date: Sun, 24 Mar 2019 19:28:52 +0100 From: Jesper Dangaard Brouer To: Ioana Ciocoi Radulescu Cc: "netdev@vger.kernel.org" , "davem@davemloft.net" , Ioana Ciornei , brouer@redhat.com Subject: Re: [PATCH net] dpaa2-eth: Fix possible access beyond end of array Message-ID: <20190324192852.29bd2f9a@carbon> In-Reply-To: <1553091059-15991-1-git-send-email-ruxandra.radulescu@nxp.com> References: <1553091059-15991-1-git-send-email-ruxandra.radulescu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Sun, 24 Mar 2019 18:28:58 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 20 Mar 2019 14:11:04 +0000 Ioana Ciocoi Radulescu wrote: > Make sure we don't try to enqueue XDP_REDIRECT frames to an > inexistent FQ. > > While it is guaranteed not to have more than one queue per core, > having fewer queues than CPUs on an interface is a valid > configuration. > > Fixes: d678be1dc1ec ("dpaa2-eth: add XDP_REDIRECT support") > Reported-by: Jesper Dangaard Brouer > Signed-off-by: Ioana Radulescu > --- > drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c > index 2ba49e9..1a68052 100644 > --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c > +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c > @@ -1817,7 +1817,7 @@ static int dpaa2_eth_xdp_xmit_frame(struct net_device *net_dev, > dpaa2_fd_set_format(&fd, dpaa2_fd_single); > dpaa2_fd_set_ctrl(&fd, FD_CTRL_PTA); > > - fq = &priv->fq[smp_processor_id()]; > + fq = &priv->fq[smp_processor_id() % dpaa2_eth_queue_count(priv)]; > for (i = 0; i < DPAA2_ETH_ENQUEUE_RETRIES; i++) { > err = priv->enqueue(priv, fq, &fd, 0); Are you sure this is correct? How do you guard/lock concurrent CPUs from accessing 'fq' ? -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer