From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/2] drm/i915: Disable C3 when enabling vblank interrupts on i945gm Date: Mon, 25 Mar 2019 09:03:56 +0200 Message-ID: <20190325070356.GP3888@intel.com> References: <20190322180804.3300-1-ville.syrjala@linux.intel.com> <155328891458.15930.7846778955426270611@skylake-alporthouse-com> <20190322235534.GM3888@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 534316E654 for ; Mon, 25 Mar 2019 07:04:00 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190322235534.GM3888@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gU2F0LCBNYXIgMjMsIDIwMTkgYXQgMDE6NTU6MzRBTSArMDIwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIEZyaSwgTWFyIDIyLCAyMDE5IGF0IDA5OjA4OjM1UE0gKzAwMDAsIENocmlz IFdpbHNvbiB3cm90ZToKPiA+IFF1b3RpbmcgVmlsbGUgU3lyamFsYSAoMjAxOS0wMy0yMiAxODow ODowMykKPiA+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4Lmlu dGVsLmNvbT4KPiA+ID4gCj4gPiA+IFRoZSBBR1BCVVNZIHRoaW5nIGRvZXNuJ3Qgd29yayBvbiBp OTQ1Z20gYW55bW9yZS4gVGhpcyBtZWFucwo+ID4gPiB0aGUgZ21jaCBpcyBpbmNhcGFibGUgb2Yg d2FraW5nIHRoZSBDUFUgZnJvbSBDMyB3aGVuIGFuIGludGVycnVwdAo+ID4gPiBpcyBnZW5lcmF0 ZWQuIFRoZSBpbnRlcnJ1cHRzIGp1c3QgZ2V0IHBvc3Rwb25lZCBpbmRlZmluaXRlbHkgdW50aWwK PiA+ID4gc29tZXRoaW5nIHdha2VzIHVwIHRoZSBDUFUuIFRoaXMgaXMgcmF0aGVyIGFubm95aW5n IGZvciB2YmxhbmsKPiA+ID4gaW50ZXJydXB0cyBhcyB3ZSBhcmUgdW5hYmxlIHRvIG1haW50YWlu IGEgc3RlYWR5IGZyYW1lcmF0ZQo+ID4gPiB1bmxlc3MgdGhlIG1hY2hpbmUgaXMgc3VmZmljaWVu dGx5IGxvYWRlZCB0byBzdGF5IG91dCBvZiBDMy4KPiA+ID4gCj4gPiA+IFRvIGNvbWJhdCB0aGlz IGxldCdzIHVzZSBwbV9xb3MgdG8gcHJldmVudCBDMyB3aGVuZXZlciB2YmxhbmsKPiA+ID4gaW50 ZXJydXB0cyBhcmUgZW5hYmxlZC4gVG8gbWFpbnRhaW4gcmVhc29uYWJsZSBhbW91bnQgb2YgcG93 ZXJzYXZpbmcKPiA+ID4gd2Ugd2lsbCBhdHRlbXB0IHRvIGxpbWl0IHRoaXMgdG8gQzMgb25seSB3 aGlsZSBsZWF2aW5nIEMxIGFuZCBDMgo+ID4gPiBlbmFibGVkLgo+ID4gCj4gPiBJbnRlcmVzdGlu ZyBjb21wcm9taXNlLiBGcmFua2x5LCBJIGhhZCBjb25zaWRlcmVkIHBtX3FvcyBpbiBhbgo+ID4g YWxsLW9yLW5vdGhpbmcgYXBwcm9hY2gsIHBhcnRseSBiZWNhdXNlIGZpbmRpbmcgdGhlIEMgdHJh bnNpdGlvbnMgaXMgYQo+ID4gYml0IG9wYXF1ZS4KPiA+ICAKPiA+ID4gQnVnemlsbGE6IGh0dHBz Oi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTMwMzY0Cj4gPiA+IFNpZ25l ZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+ Cj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCB8ICA4ICsr Kwo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyB8IDg4ICsrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKwo+ID4gPiAgMiBmaWxlcyBjaGFuZ2VkLCA5NiBpbnNlcnRp b25zKCspCj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiA+ID4gaW5kZXggZjcy M2IxNTUyN2Y4Li4wYzczNmY4Y2ExYjIgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZHJ2LmgKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k cnYuaAo+ID4gPiBAQCAtMjA0Miw2ICsyMDQyLDE0IEBAIHN0cnVjdCBkcm1faTkxNV9wcml2YXRl IHsKPiA+ID4gICAgICAgICAgICAgICAgIHN0cnVjdCBpOTE1X3ZtYSAqc2NyYXRjaDsKPiA+ID4g ICAgICAgICB9IGd0Owo+ID4gPiAgCj4gPiA+ICsgICAgICAgLyogRm9yIGk5NDVnbSB2Ymxhbmsg aXJxIHZzLiBDMyB3b3JrYXJvdW5kICovCj4gPiA+ICsgICAgICAgc3RydWN0IHsKPiA+ID4gKyAg ICAgICAgICAgICAgIHN0cnVjdCB3b3JrX3N0cnVjdCB3b3JrOwo+ID4gPiArICAgICAgICAgICAg ICAgc3RydWN0IHBtX3Fvc19yZXF1ZXN0IHBtX3FvczsKPiA+ID4gKyAgICAgICAgICAgICAgIHU4 IGMzX2Rpc2FibGVfbGF0ZW5jeTsKPiA+IAo+ID4gT2ssIGxvb2tzIGEgYml0IHRpZ2h0LCBidXQg Y2hlY2tzIG91dC4KPiA+IAo+ID4gPiArICAgICAgICAgICAgICAgdTggZW5hYmxlZDsKPiA+ID4g KyAgICAgICB9IGk5NDVnbV92Ymxhbms7Cj4gPiA+ICsKPiA+ID4gICAgICAgICAvKiBwZXJmb3Jt IFBIWSBzdGF0ZSBzYW5pdHkgY2hlY2tzPyAqLwo+ID4gPiAgICAgICAgIGJvb2wgY2h2X3BoeV9h c3NlcnRbMl07Cj4gPiA+ICAKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfaXJxLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gPiA+IGluZGV4 IDJmNzg4MjkxY2ZlMC4uMzMzODZmMGFjYWIzIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfaXJxLmMKPiA+ID4gQEAgLTMwLDYgKzMwLDcgQEAKPiA+ID4gIAo+ID4gPiAgI2luY2x1ZGUg PGxpbnV4L3N5c3JxLmg+Cj4gPiA+ICAjaW5jbHVkZSA8bGludXgvc2xhYi5oPgo+ID4gPiArI2lu Y2x1ZGUgPGxpbnV4L2NwdWlkbGUuaD4KPiA+ID4gICNpbmNsdWRlIDxsaW51eC9jaXJjX2J1Zi5o Pgo+ID4gPiAgI2luY2x1ZGUgPGRybS9kcm1faXJxLmg+Cj4gPiA+ICAjaW5jbHVkZSA8ZHJtL2Ry bV9kcnYuaD4KPiA+ID4gQEAgLTMxMzEsNiArMzEzMiwxNiBAQCBzdGF0aWMgaW50IGk4eHhfZW5h YmxlX3ZibGFuayhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgcGlwZSkKPiA+ ID4gICAgICAgICByZXR1cm4gMDsKPiA+ID4gIH0KPiA+ID4gIAo+ID4gPiArc3RhdGljIGludCBp OTQ1Z21fZW5hYmxlX3ZibGFuayhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQg cGlwZSkKPiA+ID4gK3sKPiA+ID4gKyAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYgPSB0b19pOTE1KGRldik7Cj4gPiA+ICsKPiA+ID4gKyAgICAgICBpZiAoZGV2X3ByaXYt Pmk5NDVnbV92YmxhbmsuZW5hYmxlZCsrID09IDApCj4gPiA+ICsgICAgICAgICAgICAgICBzY2hl ZHVsZV93b3JrKCZkZXZfcHJpdi0+aTk0NWdtX3ZibGFuay53b3JrKTsKPiA+IAo+ID4gSSB3YXMg dGhpbmtpbmcgdTgsIGlzbid0IHRoYXQgYSBiaXQgZGFuZ2Vyb3VzLiBCdXQgdGhlIG1heCBjb3Vu dGVyIGhlcmUKPiA+IHNob3VsZCBiZSBudW1fcGlwZXMuIEhtbSwgaXMgdGhlIHZibGFuayBzcGlu bG9jayBsb2NhbCB0byBhIHBpcGU/IE5vcGUsCj4gPiBkZXYtPnZibF9sb2NrLgo+ID4gCj4gPiA+ ICsKPiA+ID4gKyAgICAgICByZXR1cm4gaTh4eF9lbmFibGVfdmJsYW5rKGRldiwgcGlwZSk7Cj4g PiA+ICt9Cj4gPiA+ICsKPiA+ID4gIHN0YXRpYyBpbnQgaTk2NV9lbmFibGVfdmJsYW5rKHN0cnVj dCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCBwaXBlKQo+ID4gPiAgewo+ID4gPiAgICAg ICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiA+ ID4gQEAgLTMxOTUsNiArMzIwNiwxNiBAQCBzdGF0aWMgdm9pZCBpOHh4X2Rpc2FibGVfdmJsYW5r KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVkIGludCBwaXBlKQo+ID4gPiAgICAgICAg IHNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmRldl9wcml2LT5pcnFfbG9jaywgaXJxZmxhZ3MpOwo+ ID4gPiAgfQo+ID4gPiAgCj4gPiA+ICtzdGF0aWMgdm9pZCBpOTQ1Z21fZGlzYWJsZV92Ymxhbmso c3RydWN0IGRybV9kZXZpY2UgKmRldiwgdW5zaWduZWQgaW50IHBpcGUpCj4gPiA+ICt7Cj4gPiA+ ICsgICAgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShkZXYp Owo+ID4gPiArCj4gPiA+ICsgICAgICAgaTh4eF9kaXNhYmxlX3ZibGFuayhkZXYsIHBpcGUpOwo+ ID4gPiArCj4gPiA+ICsgICAgICAgaWYgKC0tZGV2X3ByaXYtPmk5NDVnbV92YmxhbmsuZW5hYmxl ZCA9PSAwKQo+ID4gPiArICAgICAgICAgICAgICAgc2NoZWR1bGVfd29yaygmZGV2X3ByaXYtPmk5 NDVnbV92Ymxhbmsud29yayk7Cj4gPiA+ICt9Cj4gPiA+ICsKPiA+ID4gIHN0YXRpYyB2b2lkIGk5 NjVfZGlzYWJsZV92Ymxhbmsoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdW5zaWduZWQgaW50IHBp cGUpCj4gPiA+ICB7Cj4gPiA+ICAgICAgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2ID0gdG9faTkxNShkZXYpOwo+ID4gPiBAQCAtMzIyOCw2ICszMjQ5LDYwIEBAIHN0YXRpYyB2 b2lkIGdlbjhfZGlzYWJsZV92Ymxhbmsoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdW5zaWduZWQg aW50IHBpcGUpCj4gPiA+ICAgICAgICAgc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmZGV2X3ByaXYt PmlycV9sb2NrLCBpcnFmbGFncyk7Cj4gPiA+ICB9Cj4gPiA+ICAKPiA+ID4gK3N0YXRpYyB2b2lk IGk5NDVnbV92Ymxhbmtfd29ya19mdW5jKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykKPiA+ID4g K3sKPiA+ID4gKyAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPQo+ID4g PiArICAgICAgICAgICAgICAgY29udGFpbmVyX29mKHdvcmssIHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlLCBpOTQ1Z21fdmJsYW5rLndvcmspOwo+ID4gPiArCj4gPiA+ICsgICAgICAgLyoKPiA+ID4g KyAgICAgICAgKiBWYmxhbmsgaW50ZXJydXB0cyBmYWlsIHRvIHdha2UgdXAgdGhlIGRldmljZSBm cm9tIEMzLAo+ID4gPiArICAgICAgICAqIGhlbmNlIHdlIHdhbnQgdG8gcHJldmVudCBDMyB1c2Fn ZSB3aGlsZSB2YmxhbmsgaW50ZXJydXB0cwo+ID4gPiArICAgICAgICAqIGFyZSBlbmFibGVkLgo+ ID4gPiArICAgICAgICAqLwo+ID4gPiArICAgICAgIHBtX3Fvc191cGRhdGVfcmVxdWVzdCgmZGV2 X3ByaXYtPmk5NDVnbV92YmxhbmsucG1fcW9zLAo+ID4gPiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBkZXZfcHJpdi0+aTk0NWdtX3ZibGFuay5lbmFibGVkID8KPiA+ID4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgZGV2X3ByaXYtPmk5NDVnbV92YmxhbmsuYzNfZGlzYWJsZV9s YXRlbmN5IDoKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUE1fUU9TX0RFRkFV TFRfVkFMVUUpOwo+ID4gCj4gPiBXb3JrZXIgaXMgcmVxdWlyZWQgYXMgdGhlIHVwZGF0ZSBtYXkg YmxvY2suCj4gPiAKPiA+IEknZCBwcmVmZXIgdGhhdCBhcyBSRUFEX09OQ0UoZGV2X3ByaXYtPmk5 NDVnbV92YmxhbmsuZW5hYmxlZCkKPiAKPiBZZWFoLCB0aGF0IGRvZXMgc2VlbSBhcHByb3ByaWF0 ZS4KClB1c2hlZCB3aXRoIHRoYXQgYmVmb3JlIEkgaGF2ZSBjaGFuY2UgdG8gcmVncmV0IHRoZSAw LjdXLgpUaGFua3MgZm9yIHRoZSByZXZpZXcuCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==