From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80651C43381 for ; Mon, 25 Mar 2019 16:17:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A20E20828 for ; Mon, 25 Mar 2019 16:17:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729571AbfCYQRe (ORCPT ); Mon, 25 Mar 2019 12:17:34 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:38116 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726182AbfCYQRc (ORCPT ); Mon, 25 Mar 2019 12:17:32 -0400 Received: by mail-pl1-f193.google.com with SMTP id g37so178117plb.5 for ; Mon, 25 Mar 2019 09:17:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EQ8VUpmBBubbNPUolCACetJhg4NroR2iGHFPPm9YxTY=; b=ZWJA1Zn8KI4XiAW0q4F5ENwRd4DIQNXHWGMDGvO5q5YFn6qCNpL/S0HA40c+by1Zrq d4Snmf7fGsU7U/+6/IzC/jeVN3MyYfNq5lGPoecPldhgeXVmk1Dtc8HTyuIYuiNJqk1t 1FmhEuCm3tqgrNGz6UQ3N+xiB6DpJoQFBaT9+M1jvS6p5yl68hR6YSD9vHYoylo12fBI obJw3ln8+UIK4XiEpxxItLxQ3gPG3B6BbU8IZ0i2Ozcw8qqbQX4UR7zPgyRv1qbbj8XT 2EBCszY1QzJYBFiMHQ2bUS51rQm3L+IwtJUevemZh7VRGhaCx0BdbE9XWzP5QgUgeB1w nIpw== X-Gm-Message-State: APjAAAWI2AYlh6c43X8Cn4MPbglrNAiCHNooRPkeLyBdPVjw1RfKI/PE WHuXiTCMC03S+Kt8TOexcTPLIKwd5Rc= X-Google-Smtp-Source: APXvYqxQDe7a+zLPCLV5bgVwv9BdGSMjRGiogH2w6ArIxvsqy128opC65B3Kw8MZvmVYPl0A3MII2g== X-Received: by 2002:a17:902:9a88:: with SMTP id w8mr26371093plp.8.1553530652108; Mon, 25 Mar 2019 09:17:32 -0700 (PDT) Received: from desktop-bart.svl.corp.google.com ([2620:15c:2cd:203:5cdc:422c:7b28:ebb5]) by smtp.gmail.com with ESMTPSA id 4sm8931854pgx.68.2019.03.25.09.17.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Mar 2019 09:17:31 -0700 (PDT) From: Bart Van Assche To: David Miller Cc: netdev@vger.kernel.org, Bart Van Assche , Martin KaFai Lau Subject: [PATCH v2 1/5] net/core: Document reuseport_add_sock() bind_inany argument Date: Mon, 25 Mar 2019 09:17:19 -0700 Message-Id: <20190325161723.144556-2-bvanassche@acm.org> X-Mailer: git-send-email 2.20.GIT In-Reply-To: <20190325161723.144556-1-bvanassche@acm.org> References: <20190325161723.144556-1-bvanassche@acm.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch avoids that the following warning is reported when building with W=1: warning: Function parameter or member 'bind_inany' not described in 'reuseport_add_sock' Cc: Martin KaFai Lau Fixes: 2dbb9b9e6df6 ("bpf: Introduce BPF_PROG_TYPE_SK_REUSEPORT") # v4.19. Signed-off-by: Bart Van Assche --- net/core/sock_reuseport.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/sock_reuseport.c b/net/core/sock_reuseport.c index d8fe3e549373..dc4aefdf2a08 100644 --- a/net/core/sock_reuseport.c +++ b/net/core/sock_reuseport.c @@ -144,6 +144,8 @@ static void reuseport_free_rcu(struct rcu_head *head) * reuseport_add_sock - Add a socket to the reuseport group of another. * @sk: New socket to add to the group. * @sk2: Socket belonging to the existing reuseport group. + * @bind_inany: Whether or not the group is bound to a local INANY address. + * * May return ENOMEM and not add socket to group under memory pressure. */ int reuseport_add_sock(struct sock *sk, struct sock *sk2, bool bind_inany) -- 2.21.0.155.ge902e9bcae20