From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1h8SzY-0008QB-Ri for mharc-grub-devel@gnu.org; Mon, 25 Mar 2019 13:02:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8SzW-0008Po-VZ for grub-devel@gnu.org; Mon, 25 Mar 2019 13:02:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8SzW-0006Dr-3P for grub-devel@gnu.org; Mon, 25 Mar 2019 13:02:30 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:56127) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h8SzV-0006Cj-Ql for grub-devel@gnu.org; Mon, 25 Mar 2019 13:02:29 -0400 Received: from 139.35.155.90.in-addr.arpa ([90.155.35.139] helo=riva.pelham.vpn.ucam.org) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1h8SzU-0004cy-Cl for grub-devel@gnu.org; Mon, 25 Mar 2019 17:02:28 +0000 Received: from ns1.pelham.vpn.ucam.org ([172.20.153.2] helo=riva.ucam.org) by riva.pelham.vpn.ucam.org with esmtp (Exim 4.89) (envelope-from ) id 1h8SzT-0000ZB-KT for grub-devel@gnu.org; Mon, 25 Mar 2019 17:02:27 +0000 Date: Mon, 25 Mar 2019 17:02:27 +0000 From: Colin Watson To: grub-devel@gnu.org Subject: Re: Fwd: [PATCH] POTFILES: Don't include gnulib in grub.pot Message-ID: <20190325170227.iohqtgozqc4gqjop@riva.ucam.org> References: <20190325115844.nqiqoesn7slq6vrz@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 91.189.89.112 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Mar 2019 17:02:31 -0000 On Mon, Mar 25, 2019 at 03:24:25PM +0100, Vladimir 'phcoder' Serbinenko wrote: > On Mon, Mar 25, 2019 at 12:58 PM Daniel Kiper wrote: > > Sadly this patch does not look complete. ./grub-core/lib/gnulib is still > > included. And as Colin pointed out missing SOB. > > This directory still exists, at least in my copy. I didn't spend any > time figuring out if this is intended or stale. In either case I don't > want those file to accidently end up in POTFILES grub-core/lib/gnulib/ exists and is supposed to exist; it consists of automatically-maintained copies of the bits of Gnulib that GRUB actually uses, as opposed to the clone of all of Gnulib that lives in the gnulib/ directory. It shouldn't end up in POTFILES; so I think Daniel's point is that you should exclude both gnulib/ and grub-core/lib/gnulib/ in your patch. -- Colin Watson [cjwatson@ubuntu.com]