From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7683C43381 for ; Tue, 26 Mar 2019 06:43:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8AE2B2070B for ; Tue, 26 Mar 2019 06:43:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553582623; bh=RQNspr6dFmcSmfNlv7+IzmLo0YHcIyqfmfZ8CeZ4zIM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=2FqyzXKn4NV0YL/vr4wpCqE/eqenA9salv13+zvhyv+kpDDpB5XptJWOlC+igpnZn vnagRiDRVmbz06s30VY1ElHZZx72/UgilvdeM56I+w9dCChKJ5tAxqkDSeGOPsZyGH G8nzGO/PD7UBNwi0xCfSY1R8eVgeJbogfgpFskpM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731948AbfCZGnm (ORCPT ); Tue, 26 Mar 2019 02:43:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:50284 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731566AbfCZGhJ (ORCPT ); Tue, 26 Mar 2019 02:37:09 -0400 Received: from localhost (unknown [104.132.152.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 410712086C; Tue, 26 Mar 2019 06:37:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553582228; bh=RQNspr6dFmcSmfNlv7+IzmLo0YHcIyqfmfZ8CeZ4zIM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jfSRZHet3Fh01/T+/mi3rSiNcEZI8Aou0VmR5F0ITOXJU/7naModUjSkmxaHwQlFg POvvDWNNgXMgxSu2N/JZGcFDW4Yv/eSJqMiaWSJ/RRAN9WCtdV7vpVup/2dtfUaWDj clFflgA3ckR9ElcvXobUPR3DxQeF8o8zFlJOkuUQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vassili Karpov , Josh Poimboeuf , Thomas Gleixner , Peter Zijlstra Subject: [PATCH 4.19 20/45] objtool: Move objtool_file struct off the stack Date: Tue, 26 Mar 2019 15:30:03 +0900 Message-Id: <20190326042703.756807269@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190326042702.565683325@linuxfoundation.org> References: <20190326042702.565683325@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Josh Poimboeuf commit 0c671812f152b628bd87c0af49da032cc2a2c319 upstream. Objtool uses over 512k of stack, thanks to the hash table embedded in the objtool_file struct. This causes an unnecessarily large stack allocation and breaks users with low stack limits. Move the struct off the stack. Fixes: 042ba73fe7eb ("objtool: Add several performance improvements") Reported-by: Vassili Karpov Signed-off-by: Josh Poimboeuf Signed-off-by: Thomas Gleixner Cc: Peter Zijlstra Cc: stable@vger.kernel.org Link: https://lkml.kernel.org/r/df92dcbc4b84b02ffa252f46876df125fb56e2d7.1552954176.git.jpoimboe@redhat.com Signed-off-by: Greg Kroah-Hartman --- tools/objtool/check.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -2157,9 +2157,10 @@ static void cleanup(struct objtool_file elf_close(file->elf); } +static struct objtool_file file; + int check(const char *_objname, bool orc) { - struct objtool_file file; int ret, warnings = 0; objname = _objname;