Re: [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode

From: Hyong Youb Kim <hyonkim@cisco.com>
To: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	"John Daley (johndale)" <johndale@cisco.com>,
	Andrew Rybchenko <arybchenko@solarflare.com>,
	Qi Zhang <qi.z.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
	Shahaf Shuler <shahafs@mellanox.com>,
	Jerin Jacob <jerin.jacob@caviumnetworks.com>,
	David Marchand <david.marchand@6wind.com>,
	Maxime Coquelin <maxime.coquelin@redhat.com>,
	Konstantin Ananyev <konstantin.ananyev@intel.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode
Date: Tue, 26 Mar 2019 15:39:14 +0900	[thread overview]
Message-ID: <20190326063912.GA24848@HYONKIM-7R0DR.cisco.com> (raw)
In-Reply-To: <20190325133341.wqzl4jhoaopiskgk@bidouze.vm.6wind.com>

[...]

> > > I see it can work if an application always wants this config option to have
> > > *same* value. So it can set this in eal_init() always.
> > > 
> > > This requires "driver=xxx,key=value" kind of support in devargs.
> > > 
> > > 
> > > John, Hyong,
> > > 
> > > I guess some level of devargs support is already there, Thomas/Gaetan can
> > > provide more information on latest status of it, can it be possible to get some
> > > support from you to finalize this effort?
> > > 
> > > And when it is ready enic can benefit from it for this usecase.
> > > 
> > > Thanks,
> > > ferruh
> > 
> > Hi Thomas, Ferruh, John, Hyong,
> > 
> > driver=xxx,key=value could work, as it is not dependent on the
> > devargs framework, only on the driver implementation. Nothing specific
> > should be needed from EAL PoV (regarding this feature only). What will
> > be missing is the new devargs support in general.
> 
> Sorry I spoke too quickly, specific development and some passing of
> arguments would be needed.
> 
> > 
> > Regarding the new devargs: this dev was stalled 2 versions ago at the
> > --dev inclusion step. This parameter was necessary for PMD maintainers
> > to be able to use the new init path with their drivers and transition to
> > rte_eth_devargs_parse() for devargs parsing.
> > 
> > --dev was proposed, but its patch was not kept by Thomas during the
> > final crunch. I probably did not shout loud enough about it and let it
> > go, but I think this was a mistake: this feature was low-risk and central
> > in the transition process (it was in parallel to -w/b and --vdev).

Hi All,

Thanks for tracking this issue. Yes, we will work on "driver=x,k=v"
and try to submit patches early in the 19.08 cycle. Cannot keep
free-riding :-)

As for vpp, it can have its own local DPDK patches. So, we added an
enic patch to change the default rewrite mode to 'untag', which has
the same effect as 'driver=enic,rewrite=untag'.

-Hyong