From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 640FCC43381 for ; Tue, 26 Mar 2019 12:03:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D52A2075C for ; Tue, 26 Mar 2019 12:03:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="XZKwDu1C" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731400AbfCZMDK (ORCPT ); Tue, 26 Mar 2019 08:03:10 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:47027 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726140AbfCZMDK (ORCPT ); Tue, 26 Mar 2019 08:03:10 -0400 Received: by mail-wr1-f65.google.com with SMTP id o1so13981728wrs.13 for ; Tue, 26 Mar 2019 05:03:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=aiLfzGMex2bqnl9OtFF3LZuTGC2cbTlwhC7efboJ/aw=; b=XZKwDu1CqlMZ8p3MmgruHdl8nguaMoODmop1Sb9BsYnZidIm/xSiLhEkS7MJ/8vtNe MSU4Gig7Vcb60giCXOQpVNEvFqtChXuRjyKoW42gvY4vyRjbdpwhN2puB7uKl4z7G47K cSLAx1fNRWu4P3DgfekGu2ugEgotaF7vlJwHYFZKjQmG6nFSKxo4JFHxll0IWSkoqiTl 15hPvY48Lh3x/Hr4RX3w4dAuwt4A7F/ZoA566StySc+wIQ3g0/opqV3ym3KfoLvuozpF l4b9oeqZ+sCk/J9xckziCCNDApvPrcGUiSdfqC+QXY/KKGxLvFl02Zj963JkPIPnjYaa 38uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=aiLfzGMex2bqnl9OtFF3LZuTGC2cbTlwhC7efboJ/aw=; b=slSiUGhyMIU6ubMbdDmk+3AR1eCuxSyUpr8P8h2SAPZi0DHK5LrnYmOm2goKeGUEmE 8jhwjNo9e3Ju3HZP9zIX19AtqsvsaCKEPRg4VQbTkP7cOAGPU66yiQPLefvCReLaPm+w Vhjp/WjgCQrFNTDEIFAJ+rKptL1mtLGKbkhmtjHOAHu04lY1m4CFbz7EG+6TU4nzBpS5 Z8Of35HwAIW+FM3DhP3c8IfepRTnBV8CIpUzlysNbY6oWs+idWwi4wJbV/h0H4ORpv3Y me+vSpDLh1IyhV6hWy1EHxHrZYyjKAWIGp7PHCvQRq/3BmdEJgmiu8BrnVz2/chjAFv0 oXfA== X-Gm-Message-State: APjAAAUmOUdaE0UCi+ozeoWO0TGjBUvYVFpT+1ZHME+riSL80A4oIaRp OXKcAYgN7ZfNMdpQPfNSRIGS/mwYThE= X-Google-Smtp-Source: APXvYqwtKUN6JPpXiAQ7OqfAvqY09r/VQ3HkuVhhC4SLFUkBaAuR51vJ2ML66Ce5PZEilwMrIF/2Gw== X-Received: by 2002:adf:ee50:: with SMTP id w16mr19001319wro.293.1553601788450; Tue, 26 Mar 2019 05:03:08 -0700 (PDT) Received: from localhost (mail.chocen-mesto.cz. [85.163.43.2]) by smtp.gmail.com with ESMTPSA id h17sm15890775wrq.93.2019.03.26.05.03.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Mar 2019 05:03:08 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com, michael.chan@broadcom.com Subject: [patch net-next v2 00/12] net: call for phys_port_name into devlink directly if possible Date: Tue, 26 Mar 2019 13:02:55 +0100 Message-Id: <20190326120307.2953-1-jiri@resnulli.us> X-Mailer: git-send-email 2.17.2 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko phys_port_name may be assembled by a helper in devlink. It is currently the case only for mlxsw driver. Benefit from the get_devlink_port ndo and call into devlink directly from dev_get_phys_port_name(). That saves the trip to the driver, simplifies the code and makes it similar to recently introduced ethtool-devlink compat helpers. Move bnxt, dsa and partly nfp to let devlink core generate the name too. Jiri Pirko (12): net: replace ndo_get_devlink with ndo_get_devlink_port net: devlink: introduce devlink_compat_phys_port_name_get() mlxsw: Implement ndo_get_devlink_port mlxsw: Remove ndo_get_phys_port_name implementation net: devlink: remove unused devlink_port_get_phys_port_name() function bnxt: implement ndo_get_devlink_port bnxt: remove ndo_get_phys_port_name implementation dsa: implement ndo_get_devlink_port dsa: don't fill-up remove ndo_get_phys_port_name for slaves nfp: do not handle nn->port defined case in nfp_net_get_phys_port_name() net: devlink: expose phys port name net: devlink: add warning for ndo_get_phys_port_name set when not needed drivers/net/ethernet/broadcom/bnxt/bnxt.c | 26 ++-- drivers/net/ethernet/mellanox/mlxsw/core.c | 10 +- drivers/net/ethernet/mellanox/mlxsw/core.h | 5 +- drivers/net/ethernet/mellanox/mlxsw/minimal.c | 22 ++-- .../net/ethernet/mellanox/mlxsw/spectrum.c | 22 ++-- .../net/ethernet/mellanox/mlxsw/switchx2.c | 22 ++-- drivers/net/ethernet/netronome/nfp/nfp_app.h | 2 +- .../net/ethernet/netronome/nfp/nfp_devlink.c | 10 +- .../ethernet/netronome/nfp/nfp_net_common.c | 7 +- .../net/ethernet/netronome/nfp/nfp_net_repr.c | 2 +- include/linux/netdevice.h | 6 +- include/net/devlink.h | 25 +++- include/uapi/linux/devlink.h | 2 + net/core/dev.c | 11 +- net/core/devlink.c | 123 +++++++++++++----- net/dsa/dsa_priv.h | 1 + net/dsa/legacy.c | 2 +- net/dsa/slave.c | 49 ++++++- 18 files changed, 234 insertions(+), 113 deletions(-) -- 2.17.2