From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DD84C43381 for ; Tue, 26 Mar 2019 20:36:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2BCA320823 for ; Tue, 26 Mar 2019 20:36:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="IYUMKK2U" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732730AbfCZUgl (ORCPT ); Tue, 26 Mar 2019 16:36:41 -0400 Received: from mail-qk1-f171.google.com ([209.85.222.171]:33851 "EHLO mail-qk1-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731736AbfCZUgk (ORCPT ); Tue, 26 Mar 2019 16:36:40 -0400 Received: by mail-qk1-f171.google.com with SMTP id n68so8555944qka.1 for ; Tue, 26 Mar 2019 13:36:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=SfofcFyCQEs112O5wglxamsC1eX3iF1ADMv2PWXf7YY=; b=IYUMKK2UTQ7Bza1T7dUO16JWWSkZeR00BhRkDx4dLPGhGHHWKXCQX/JX+6IFnc8Kdb E8zTQdiSOEEeXwBCcGCxLzg638oT3j7DHTFGlP5hOKtatP1yzjG4+uqZuv7F8CGO7UuU YC8QRYMmRCx1Pek3NHyLAcwnTz3MTVAWzyM17nG+0fl7wNtu65bzhKI5ZgeltoQFvK6L jXeRyo7fr0J3vG4bUjWzmYB4sXozKitTDisDo95gLcDQMfFF5CYb3xgDCNmSrqW8/F76 RueuN29Hb9Rl1GXJdc4vF50ZYHFSrGLiWBDiT0IndA1+CNO/pwhlgVDmnNsVPDBl9wi+ a+nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=SfofcFyCQEs112O5wglxamsC1eX3iF1ADMv2PWXf7YY=; b=Se4hmxNS/Q00OnykaYIwVTCdhxaCs2yjvDKih54aEMsH/T7x7eqFunzVGWqoOjd3Je zkZ0y95Tk98Z2MQS4GF3PMyJo1WToDaxeU3LlM4atOj/5P3F3z9dWX8DMSWFpINSRcX6 mHQ/Rvt8j4h42FuqXgvoyawYPbz0+MgnWcrBJmPiELE7t9LM+eDJlfu7vFR9Sapda6kP LW+gC39mdlrDZznSDKzZb9Qc6hz678WwCsoYB1e0YLO04JTw9cV+XFW3hbfvoNoT7JaN CMDIZc5c8eAWnGYAtNNXdydwhWTqiNe3NLKrT0y7RxxudrNeaIxRMWU31WqDJbIojmcE Tzow== X-Gm-Message-State: APjAAAX7zvPqcQ5+RtZjs+SUWiz9sBp3TIXRH6rhx/UvP/jijwjib8JI YO1fk9G9l3zkO8Bn+31uyl7zlw== X-Google-Smtp-Source: APXvYqxq3YD//zA2zctjtZ+QJtjVSNcq5/n+SxihDV0q0Aczk7Or/kH+DaWWdFUieJT05ABTjn0Law== X-Received: by 2002:ae9:f00e:: with SMTP id l14mr25934273qkg.270.1553632599610; Tue, 26 Mar 2019 13:36:39 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id a8sm12777129qtc.19.2019.03.26.13.36.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Mar 2019 13:36:39 -0700 (PDT) Date: Tue, 26 Mar 2019 13:36:34 -0700 From: Jakub Kicinski To: Jiri Pirko Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com, michael.chan@broadcom.com Subject: Re: [patch net-next v2 12/12] net: devlink: add warning for ndo_get_phys_port_name set when not needed Message-ID: <20190326133634.484ec760@cakuba.netronome.com> In-Reply-To: <20190326120307.2953-13-jiri@resnulli.us> References: <20190326120307.2953-1-jiri@resnulli.us> <20190326120307.2953-13-jiri@resnulli.us> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 26 Mar 2019 13:03:07 +0100, Jiri Pirko wrote: > From: Jiri Pirko > > Currently if the driver registers devlink port instance, it should set > the devlink port attributes as well. Then the devlink core is able to > obtain physical port name itself, no need for driver to implement > the ndo. Once all drivers will implement devlink port registration, > this ndo should be removed. This warning guides new > drivers to do things as they should be done. > > Signed-off-by: Jiri Pirko Reviewed-by: Jakub Kicinski