From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D80DC43381 for ; Tue, 26 Mar 2019 14:59:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2ADEB2075C for ; Tue, 26 Mar 2019 14:59:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731827AbfCZO7M (ORCPT ); Tue, 26 Mar 2019 10:59:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41774 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726175AbfCZO7L (ORCPT ); Tue, 26 Mar 2019 10:59:11 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6EB7BBCD20; Tue, 26 Mar 2019 14:59:11 +0000 (UTC) Received: from carbon (ovpn-200-46.brq.redhat.com [10.40.200.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id 569AE84792; Tue, 26 Mar 2019 14:59:04 +0000 (UTC) Date: Tue, 26 Mar 2019 15:59:02 +0100 From: Jesper Dangaard Brouer To: Dean Nelson Cc: Robert Richter , Sunil Goutham , David Miller , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Vadim Lomovtsev , brouer@redhat.com Subject: Re: [PATCH net 1/2] thunderx: enable page recycling for non-XDP case Message-ID: <20190326155902.0c0ce9fd@carbon> In-Reply-To: <3ea9678c-863b-edcb-c812-1f3e7d492155@redhat.com> References: <155360907744.12643.15472521931039184559.email-sent-by-dnelson@cyan> <155360908585.12643.12967701630346715912.email-sent-by-dnelson@cyan> <20190326153916.530d472e@carbon> <3ea9678c-863b-edcb-c812-1f3e7d492155@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 26 Mar 2019 14:59:11 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 26 Mar 2019 09:44:19 -0500 Dean Nelson wrote: > On 3/26/19 9:39 AM, Jesper Dangaard Brouer wrote: > > On Tue, 26 Mar 2019 10:04:47 -0400 > > Dean Nelson wrote: > > > >> Commit 773225388dae15e72790 added code to nicvf_alloc_page() that inadvertently > >> disables receive buffer page recycling for the non-XDP case by always NULL'ng > >> the page pointer. > >> > >> This patch corrects two if-conditionals to allow for the recycling of non-XDP > >> mode pages by only setting the page pointer to NULL when the page is not ready > >> for recycling. > >> > >> Signed-off-by: Dean Nelson > > > > You need to add a "fixes" line like this: > > > > Fixes: 773225388dae ("net: thunderx: Optimize page recycling for XDP") > > > > And in-general reference a commit in the same way in the description. > > Sorry, for some reason I thought the 'Fixes' line was optional. > > Thank you for setting me straight. Should I repost the patchset? I would say, yes please. (Given the amount of patches DaveM have to process, lets make it easy for him). -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 487AFC43381 for ; Tue, 26 Mar 2019 14:59:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1980C2075C for ; Tue, 26 Mar 2019 14:59:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S2jQFoRP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1980C2075C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zPjLhqZA/N7r3nvScr1wv1/lzcU/EtVR8zXaN4gzExs=; b=S2jQFoRP9jzcIt fJ3SoQb26Z9Z6ECDjsLC0iHmyjr2x8WAjTyywnxBJwBh+6dhBvBjzmoSC1FiucGHKu1QN9mqKd6AW EoVjxTViHZ6lUupK/OhMT6SYe2Gy5copaycSUHhQwlEe2T8DG1eRhZaQWB+XRTAWFjDoigTQGUiNB si103i4Xp3+uU1gopKKS+ZJr2PI7Gm188LaC3l5l8KNNxG7lNofYUfs7PxsQSY4ykAjtoW8Gp5Up1 Z6QvukodsAUoM2uc0ttHbZtkS+BcK06iiiQw2CWNfG/LC7orUuyFwkocWreNwlcM2wuUgkfA8ZGWA qk3T6qtaqqTkqUjuzVDA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8nXu-0007FL-Ru; Tue, 26 Mar 2019 14:59:22 +0000 Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8nXn-0007Eq-Ot for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2019 14:59:21 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6EB7BBCD20; Tue, 26 Mar 2019 14:59:11 +0000 (UTC) Received: from carbon (ovpn-200-46.brq.redhat.com [10.40.200.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id 569AE84792; Tue, 26 Mar 2019 14:59:04 +0000 (UTC) Date: Tue, 26 Mar 2019 15:59:02 +0100 From: Jesper Dangaard Brouer To: Dean Nelson Subject: Re: [PATCH net 1/2] thunderx: enable page recycling for non-XDP case Message-ID: <20190326155902.0c0ce9fd@carbon> In-Reply-To: <3ea9678c-863b-edcb-c812-1f3e7d492155@redhat.com> References: <155360907744.12643.15472521931039184559.email-sent-by-dnelson@cyan> <155360908585.12643.12967701630346715912.email-sent-by-dnelson@cyan> <20190326153916.530d472e@carbon> <3ea9678c-863b-edcb-c812-1f3e7d492155@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 26 Mar 2019 14:59:11 +0000 (UTC) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_075915_828574_2218175D X-CRM114-Status: GOOD ( 17.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sunil Goutham , Robert Richter , netdev@vger.kernel.org, brouer@redhat.com, Vadim Lomovtsev , David Miller , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 26 Mar 2019 09:44:19 -0500 Dean Nelson wrote: > On 3/26/19 9:39 AM, Jesper Dangaard Brouer wrote: > > On Tue, 26 Mar 2019 10:04:47 -0400 > > Dean Nelson wrote: > > > >> Commit 773225388dae15e72790 added code to nicvf_alloc_page() that inadvertently > >> disables receive buffer page recycling for the non-XDP case by always NULL'ng > >> the page pointer. > >> > >> This patch corrects two if-conditionals to allow for the recycling of non-XDP > >> mode pages by only setting the page pointer to NULL when the page is not ready > >> for recycling. > >> > >> Signed-off-by: Dean Nelson > > > > You need to add a "fixes" line like this: > > > > Fixes: 773225388dae ("net: thunderx: Optimize page recycling for XDP") > > > > And in-general reference a commit in the same way in the description. > > Sorry, for some reason I thought the 'Fixes' line was optional. > > Thank you for setting me straight. Should I repost the patchset? I would say, yes please. (Given the amount of patches DaveM have to process, lets make it easy for him). -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel