Re: [PATCH] dt-bindings: Add schemas for simple-framebuffer

[Maxime Ripard <maxime.ripard@bootlin.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2073 bytes --]

Hi,

On Mon, Mar 25, 2019 at 11:27:36AM -0500, Rob Herring wrote:
> On Mon, Mar 25, 2019 at 8:54 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> >
> > The simple framebuffer is a binding that allows the bootloader to setup a
> > framebuffer, describe it in the Device Tree for the OS to pick it up and
> > use it as is.
> >
> > Replace the current binding by a schema to allow the validation tools to
> > check those nodes.
> >
> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Cc: Chen-Yu Tsai <wens@csie.org>
> > Cc: Hans de Goede <hdegoede@redhat.com>
> > Cc: Maxime Jourdan <mjourdan@baylibre.com>
> > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> >
> > ---
> >
> > Rob,
> >
> > Even though the node itself is properly described, I still end up with some
> > validation warnings when the chosen node is validated (basically
> > complaining that ranges, and the framebuffer nodes shouldn't be here, since
> > we haven't described them in the chosen schemas).
>
> Having 'ranges' is a bit strange because 'chosen' doesn't have an
> address. We can add #address-cells, #size-cells and framebuffer child
> node to the base chosen schema.

Maybe that's just cargo cult, but both the amlogic and the sunxi DT
have ranges in chosen. Shouldn't we need it so that the address is
decoded properly?

> > I've tried to expand it, but I failed, using that patch:
> > http://code.bulix.org/mimu5z-634661?raw
>
> That should work, but you will still get warnings from the core
> schema. Also, I guess you really want to match on the child compatible
> which isn't possible with the current tools. I think for now at least,
> we don't need to validate that simple-fb is a child of chosen.

Ok, so the current patch would be good enough for now I guess.

> Maybe we could add a '$parent' property which the tools add like
> $nodename. I'd rather wait and see how frequently we need something
> like this.

ACK.

I'll address the rest of your comments, thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel