From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] diff: batch fetching of missing blobs
Date: Wed, 27 Mar 2019 11:10:55 +0100 [thread overview]
Message-ID: <20190327101055.GB32732@szeder.dev> (raw)
In-Reply-To: <20190326220906.111879-1-jonathantanmy@google.com>
On Tue, Mar 26, 2019 at 03:09:06PM -0700, Jonathan Tan wrote:
> diff --git a/t/t4067-diff-partial-clone.sh b/t/t4067-diff-partial-clone.sh
> new file mode 100755
> index 0000000000..38f03be114
> --- /dev/null
> +++ b/t/t4067-diff-partial-clone.sh
> @@ -0,0 +1,76 @@
> +#!/bin/sh
> +
> +test_description='behavior of diff when reading objects in a partial clone'
> +
> +. ./test-lib.sh
> +
> +test_expect_success 'git show batches blobs' '
> + test_create_repo server &&
> + echo a >server/a &&
> + echo b >server/b &&
> + git -C server add a b &&
> + git -C server commit -m x &&
> +
> + test_config -C server uploadpack.allowfilter 1 &&
> + test_config -C server uploadpack.allowanysha1inwant 1 &&
> + git clone --bare --filter=blob:limit=0 "file://$(pwd)/server" client &&
> +
> + # Ensure that there is exactly 1 negotiation by checking that there is
> + # only 1 "done" line sent. ("done" marks the end of negotiation.)
> + GIT_TRACE_PACKET="$(pwd)/trace" git -C client show HEAD &&
> + grep "git> done" trace >done_lines &&
> + test_line_count = 1 done_lines
> +'
> +
> +test_expect_success 'diff batches blobs' '
> + rm -rf server client trace &&
Please use 'test_when_finished' in the previous test to clean up after
itself.
> +
> + test_create_repo server &&
> + echo a >server/a &&
> + echo b >server/b &&
> + git -C server add a b &&
> + git -C server commit -m x &&
> + echo c >server/c &&
> + echo d >server/d &&
> + git -C server add c d &&
> + git -C server commit -m x &&
> +
> + test_config -C server uploadpack.allowfilter 1 &&
> + test_config -C server uploadpack.allowanysha1inwant 1 &&
> + git clone --bare --filter=blob:limit=0 "file://$(pwd)/server" client &&
> +
> + # Ensure that there is exactly 1 negotiation by checking that there is
> + # only 1 "done" line sent. ("done" marks the end of negotiation.)
> + GIT_TRACE_PACKET="$(pwd)/trace" git -C client diff HEAD^ HEAD &&
> + grep "git> done" trace >done_lines &&
> + test_line_count = 1 done_lines
> +'
> +
> +test_expect_success 'diff skips same-OID blobs' '
> + rm -rf server client trace &&
Likewise.
> + test_create_repo server &&
> + echo a >server/a &&
> + echo b >server/b &&
> + git -C server add a b &&
> + git -C server commit -m x &&
> + echo another-a >server/a &&
> + git -C server add a &&
> + git -C server commit -m x &&
> +
> + test_config -C server uploadpack.allowfilter 1 &&
> + test_config -C server uploadpack.allowanysha1inwant 1 &&
> + git clone --bare --filter=blob:limit=0 "file://$(pwd)/server" client &&
> +
> + echo a | git hash-object --stdin >hash-old-a &&
> + echo another-a | git hash-object --stdin >hash-new-a &&
> + echo b | git hash-object --stdin >hash-b &&
> +
> + # Ensure that only a and another-a are fetched.
> + GIT_TRACE_PACKET="$(pwd)/trace" git -C client diff HEAD^ HEAD &&
> + grep "want $(cat hash-old-a)" trace &&
> + grep "want $(cat hash-new-a)" trace &&
> + ! grep "want $(cat hash-b)" trace
> +'
> +
> +test_done
> --
> 2.21.0.155.ge902e9bcae.dirty
>
next prev parent reply other threads:[~2019-03-27 10:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 22:09 [PATCH] diff: batch fetching of missing blobs Jonathan Tan
2019-03-27 10:10 ` SZEDER Gábor [this message]
2019-03-27 22:02 ` Johannes Schindelin
2019-03-28 6:52 ` Jeff King
2019-03-29 21:39 ` [PATCH v2 0/2] Batch fetching of missing blobs in diff and show Jonathan Tan
2019-03-29 21:39 ` [PATCH v2 1/2] sha1-file: support OBJECT_INFO_FOR_PREFETCH Jonathan Tan
2019-04-05 14:13 ` Johannes Schindelin
2019-04-05 22:00 ` Jeff King
2019-03-29 21:39 ` [PATCH v2 2/2] diff: batch fetching of missing blobs Jonathan Tan
2019-04-04 2:47 ` SZEDER Gábor
2019-04-05 13:38 ` Johannes Schindelin
2019-04-07 6:00 ` Christian Couder
2019-04-08 2:36 ` Junio C Hamano
2019-04-08 5:51 ` Junio C Hamano
2019-04-08 6:03 ` Junio C Hamano
2019-04-08 6:45 ` Christian Couder
2019-04-08 6:40 ` Christian Couder
2019-04-08 7:59 ` Junio C Hamano
2019-04-08 9:56 ` Christian Couder
2019-04-05 9:39 ` Duy Nguyen
2019-04-05 17:09 ` [PATCH] fixup! " Jonathan Tan
2019-04-05 20:16 ` Johannes Schindelin
2019-04-06 4:17 ` Duy Nguyen
2019-04-08 3:46 ` Junio C Hamano
2019-04-08 4:06 ` Junio C Hamano
2019-04-08 9:58 ` Duy Nguyen
2019-04-09 6:36 ` Junio C Hamano
2019-04-05 14:17 ` [PATCH v2 2/2] " Johannes Schindelin
2019-04-05 22:12 ` [PATCH v2 0/2] Batch fetching of missing blobs in diff and show Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327101055.GB32732@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.