From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D115C10F00 for ; Wed, 27 Mar 2019 12:31:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B04820449 for ; Wed, 27 Mar 2019 12:31:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729294AbfC0Mb1 (ORCPT ); Wed, 27 Mar 2019 08:31:27 -0400 Received: from foss.arm.com ([217.140.101.70]:53870 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726392AbfC0Mb1 (ORCPT ); Wed, 27 Mar 2019 08:31:27 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D21EC374; Wed, 27 Mar 2019 05:31:26 -0700 (PDT) Received: from e107981-ln.cambridge.arm.com (e107981-ln.cambridge.arm.com [10.1.197.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 577C53F557; Wed, 27 Mar 2019 05:31:25 -0700 (PDT) Date: Wed, 27 Mar 2019 12:31:15 +0000 From: Lorenzo Pieralisi To: Srinath Mannam Cc: Bjorn Helgaas , Ray Jui , Scott Branden , BCM Kernel Feedback , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List Subject: Re: [PATCH v4 0/2] Add IPROC PCIe new features Message-ID: <20190327123114.GA9636@e107981-ln.cambridge.arm.com> References: <1551415936-30174-1-git-send-email-srinath.mannam@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 27, 2019 at 02:08:46PM +0530, Srinath Mannam wrote: > Hi Lorenzo/Bjorn, > > Could you please help to review this patch series when you have time? > I believe I have addressed all your review comments. I will shortly keeping in mind that you should really ask HW designers to get to grips with a proper design because there are ways too many HW quirks this driver has to fix-up, it has become an unmanageable collection of work arounds. Lorenzo > Thanks, > Srinath. > > On Fri, Mar 1, 2019 at 10:22 AM Srinath Mannam > wrote: > > > > This patch set extends support of new IPROC PCIe host controller features > > - Add CRS check using controller register status flags > > - Add outbound window mapping configuration for 32-bit I/O region > > > > This patch set is based on Linux-5.0-rc2. > > > > Changes from v3: > > - Addressed Lorenzo Pieralisi comments. > > > > Changes from v2: > > - Based on Lorenzo Pieralisi comments, commit logs are expanded. > > > > Changes from v1: > > - Addressed Bjorn Helgaas comments. > > - Removed set order mode patch from patchset. > > > > Srinath Mannam (2): > > PCI: iproc: Add CRS check in config read > > PCI: iproc: Add outbound configuration for 32-bit I/O region > > > > drivers/pci/controller/pcie-iproc.c | 44 +++++++++++++++++++++++++++++++++---- > > 1 file changed, 40 insertions(+), 4 deletions(-) > > > > -- > > 2.7.4 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BF03C43381 for ; Wed, 27 Mar 2019 12:31:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1DB4A2070D for ; Wed, 27 Mar 2019 12:31:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="h3PlCvzE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DB4A2070D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dH3QSRkvklbjR9HTdAQ9X5BcgbH+K8Dr1qo5rkMBpQ8=; b=h3PlCvzEV513c8 wAmtMrvMomcetNMfreG3RjKiVRemPaXUR+NO2AWdFatyA2grir+Bd/vSScrq8pbFCh69wcaG34BkV Ms1JPvp8cxsKm4RPIoRSiN5U1nnlvIrSPvDbVAo2hIH4qnxwI7TwLH0dHl0W9nMJ3t5Qu39A+YFoT UnTlYCC6i1yw6FsNsZt3kgwvx92yFEMCtj6hn8Jzrwkcb0KPKHC92nYpwj74los7TggTfcw/VZzLY fdZyj/5SnhIK29oUTT+TYlE8s3OvY0un8WfibhCYsb4hVbSkQBQ61WmwsOziVop/TE8dC1qaiLQjM /mH6vLtyECDkGkdCijaQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h97iL-0006zZ-Nv; Wed, 27 Mar 2019 12:31:29 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h97iJ-0006yx-Fo for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2019 12:31:28 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D21EC374; Wed, 27 Mar 2019 05:31:26 -0700 (PDT) Received: from e107981-ln.cambridge.arm.com (e107981-ln.cambridge.arm.com [10.1.197.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 577C53F557; Wed, 27 Mar 2019 05:31:25 -0700 (PDT) Date: Wed, 27 Mar 2019 12:31:15 +0000 From: Lorenzo Pieralisi To: Srinath Mannam Subject: Re: [PATCH v4 0/2] Add IPROC PCIe new features Message-ID: <20190327123114.GA9636@e107981-ln.cambridge.arm.com> References: <1551415936-30174-1-git-send-email-srinath.mannam@broadcom.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190327_053127_527031_4967B8F6 X-CRM114-Status: GOOD ( 18.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Scott Branden , Ray Jui , Linux Kernel Mailing List , BCM Kernel Feedback , linux-pci@vger.kernel.org, Bjorn Helgaas , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 27, 2019 at 02:08:46PM +0530, Srinath Mannam wrote: > Hi Lorenzo/Bjorn, > > Could you please help to review this patch series when you have time? > I believe I have addressed all your review comments. I will shortly keeping in mind that you should really ask HW designers to get to grips with a proper design because there are ways too many HW quirks this driver has to fix-up, it has become an unmanageable collection of work arounds. Lorenzo > Thanks, > Srinath. > > On Fri, Mar 1, 2019 at 10:22 AM Srinath Mannam > wrote: > > > > This patch set extends support of new IPROC PCIe host controller features > > - Add CRS check using controller register status flags > > - Add outbound window mapping configuration for 32-bit I/O region > > > > This patch set is based on Linux-5.0-rc2. > > > > Changes from v3: > > - Addressed Lorenzo Pieralisi comments. > > > > Changes from v2: > > - Based on Lorenzo Pieralisi comments, commit logs are expanded. > > > > Changes from v1: > > - Addressed Bjorn Helgaas comments. > > - Removed set order mode patch from patchset. > > > > Srinath Mannam (2): > > PCI: iproc: Add CRS check in config read > > PCI: iproc: Add outbound configuration for 32-bit I/O region > > > > drivers/pci/controller/pcie-iproc.c | 44 +++++++++++++++++++++++++++++++++---- > > 1 file changed, 40 insertions(+), 4 deletions(-) > > > > -- > > 2.7.4 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel