All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vadym Kochan <vadim4j@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/netsniff-ng: Allow to build with uclibc but w/o mausezahn
Date: Thu, 28 Mar 2019 19:41:25 +0200	[thread overview]
Message-ID: <20190328174125.GA15667@lwo1-lhp-f71841> (raw)
In-Reply-To: <20190328181511.22031245@windsurf>

On Thu, Mar 28, 2019 at 06:15:11PM +0100, Thomas Petazzoni wrote:
> On Mon, 4 Mar 2019 20:06:00 +0100
> Arnout Vandecappelle <arnout@mind.be> wrote:
> 
> > >  define NETSNIFF_NG_INSTALL_TARGET_CMDS
> > >  	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
> > > -		PREFIX=$(TARGET_DIR)/usr ETCDIR=$(TARGET_DIR)/etc install -C $(@D)
> > > +		PREFIX=$(TARGET_DIR)/usr ETCDIR=$(TARGET_DIR)/etc install \
> > > +			-C $(@D) $(NETSNIFF_NG_TOOLS)  
> > 
> >  I don't like very much that we have to enumerate the tools in the .mk file, but
> > I don't see any other possibility.
> 
> The Makefile has the following targets:
> 
> 	allbutmausezahn: $(filter-out mausezahn,$(TOOLS))
> 
> 	install_allbutmausezahn: $(foreach tool,$(filter-out mausezahn,$(TOOLS)),$(tool)_install)
> 
> So I think we can build/install everything except mausezahen fairly
> easily without duplicating the list of tools in netsniff-ng.mk.
> 

Good catch, I really missed this event that I contributed some quite a
lot of patches to netsniff-ng :))

But still separate config option for mz is OK ? If not, then I will
prepare patch for netsniff-ng configure to check for existence of missed
function for mz, but in that case libnet and libcli will be selected by
buildroot even if mz is not built.

Regards,
Vadim Kochan

  reply	other threads:[~2019-03-28 17:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-04  8:57 [Buildroot] [PATCH 1/1] package/netsniff-ng: Allow to build with uclibc but w/o mausezahn Vadim Kochan
2019-03-04 19:06 ` Arnout Vandecappelle
2019-03-06  5:29   ` Vadim Kochan
2019-03-06  9:28     ` Arnout Vandecappelle
2019-03-28 17:16       ` Thomas Petazzoni
2019-03-28 17:15   ` Thomas Petazzoni
2019-03-28 17:41     ` Vadym Kochan [this message]
2019-03-28 17:56 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190328174125.GA15667@lwo1-lhp-f71841 \
    --to=vadim4j@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.