From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manasi Navare Subject: Re: [PATCH 1/2] drm/i915/icl: Assign genlock CRTC pointer in all slave CRTC states for tiled displays Date: Thu, 28 Mar 2019 11:54:39 -0700 Message-ID: <20190328185438.GB20982@intel.com> References: <20190322015939.23189-1-manasi.d.navare@intel.com> <87imw32vkt.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3AFE36E7CD for ; Thu, 28 Mar 2019 18:52:19 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87imw32vkt.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXIgMjgsIDIwMTkgYXQgMTE6MzI6MThBTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gVGh1LCAyMSBNYXIgMjAxOSwgTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJl QGludGVsLmNvbT4gd3JvdGU6Cj4gPiBJbiBjYXNlIG9mIHRpbGVkIGRpc3BsYXlzIHdoZW4gdGhl IHR3byB0aWxlcyBhcmUgc2VudCBhY3Jvc3MgdHdvIENSVENzCj4gPiBvdmVyIHR3byBzZXBhcmF0 ZSBEUCBTU1QgY29ubmVjdG9ycywgd2UgbmVlZCBhIG1lY2hhbmlzbSB0byBzeW5jaHJvbml6ZQo+ ID4gdGhlIHR3byBDUlRDcyBhbmQgdGhlaXIgY29ycmVzcG9uZGluZyB0cmFuc2NvZGVycy4KPiA+ IFNvIHVzZSB0aGUgbWFzdGVyLXNsYXZlIG1vZGUgd2hlcmUgdGhlcmUgaXMgb25lIG1hc3RlciBj b3JyZXNwb25kaW5nCj4gPiB0byBsYXN0IGhvcml6b250YWwgYW5kIHZlcnRpY2FsIHRpbGUgdGhh dCBuZWVkcyB0byBiZSBnZW5sb2NrZWQgd2l0aAo+ID4gYWxsIG90aGVyIHNsYXZlIHRpbGVzLgo+ ID4gVGhpcyBwYXRjaCBpZGVudGlmaWVzIHNhdmVzIHRoZSBtYXN0ZXIgQ1JUQyBwb2ludGVyIGlu IGFsbCB0aGUgc2xhdmUKPiA+IENSVEMgc3RhdGVzLiBUaGlzIHBvaW50ZXIgaXMgbmVlZGVkIHRv IHNlbGVjdCB0aGUgbWFzdGVyIENSVEMvdHJhbnNjb2Rlcgo+ID4gd2hpbGUgY29uZmlndXJpbmcg dHJhbnNjb2RlciBwb3J0IHN5bmMgZm9yIHRoZSBjb3JyZXNwb25kaW5nIHNsYXZlcy4KPiA+Cj4g PiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiA+IENjOiBWaWxs ZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gQ2M6IE1hYXJ0 ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gPiBDYzog TWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6 IE1hbmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA4NCArKysrKysrKysrKysrKysr KysrKysrKysrKysrCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAgIHwg IDMgKwo+ID4gIDIgZmlsZXMgY2hhbmdlZCwgODcgaW5zZXJ0aW9ucygrKQo+ID4KPiA+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IGluZGV4IDhmZjdhYThjYjNjZi4uOTk4MGE0 ZWQ4YzljIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IEBA IC0xMTI4MSw2ICsxMTI4MSw4NiBAQCBzdGF0aWMgaW50IGljbF9jaGVja19udjEyX3BsYW5lcyhz dHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKPiA+ICAJcmV0dXJuIDA7Cj4gPiAg fQo+ID4gIAo+ID4gK3N0YXRpYyBpbnQgaWNsX2FkZF9nZW5sb2NrX2NydGNzKHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYsCj4gPiArCQkJCSBzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4g PiArewo+ID4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRl dik7Cj4gPiArCXN0cnVjdCBkcm1fY29ubmVjdG9yICpnZW5sb2NrX2Nvbm5lY3RvciwgKmNvbm5l Y3RvcjsKPiA+ICsJc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5lY3Rvcl9zdGF0ZTsK PiA+ICsJc3RydWN0IGRybV9jb25uZWN0b3JfbGlzdF9pdGVyIGNvbm5faXRlcjsKPiA+ICsJc3Ry dWN0IGRybV9jcnRjICpnZW5sb2NrX2NydGMgPSBOVUxMOwo+ID4gKwlzdHJ1Y3QgZHJtX2NydGNf c3RhdGUgKmdlbmxvY2tfY3J0Y19zdGF0ZTsKPiA+ICsJc3RydWN0IGludGVsX2NydGNfc3RhdGUg KnNsYXZlX2NydGNfc3RhdGU7Cj4gPiArCWludCBpLCB0aWxlX2dyb3VwX2lkOwo+ID4gKwo+ID4g KwlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA8IDExKQo+ID4gKwkJcmV0dXJuIDA7Cj4gPiArCj4g PiArCS8qCj4gPiArCSAqIEluIGNhc2Ugb2YgdGlsZWQgZGlzcGxheXMgdGhlcmUgY291bGQgYmUg b25lIG9yIG1vcmUgc2xhdmVzIGJ1dCB0aGVyZSBpcwo+ID4gKwkgKiBvbmx5IG9uZSBtYXN0ZXIu IExldHMgbWFrZSB0aGUgQ1JUQyB1c2VkIGJ5IHRoZSBjb25uZWN0b3IgY29ycmVzcG9uZGluZwo+ ID4gKwkgKiB0byB0aGUgbGFzdCBob3Jpem9uYWwgYW5kIGxhc3QgdmVydGljYWwgdGlsZSBhIG1h c3Rlci9nZW5sb2NrIENSVEMuCj4gPiArCSAqIEFsbCB0aGUgb3RoZXIgQ1JUQ3MgY29ycmVzcG9u ZGluZyB0byBvdGhlciB0aWxlcyBvZiB0aGUgc2FtZSBUaWxlIGdyb3VwCj4gPiArCSAqIGFyZSB0 aGUgc2xhdmUgQ1JUQ3MgYW5kIGhvbGQgYSBwb2ludGVyIHRvIHRoZWlyIGdlbmxvY2sgQ1JUQy4K PiA+ICsJICovCj4gPiArCWZvcl9lYWNoX25ld19jb25uZWN0b3JfaW5fc3RhdGUoc3RhdGUsIGNv bm5lY3RvciwgY29ubmVjdG9yX3N0YXRlLCBpKSB7Cj4gPiArCQlpZiAoIWNvbm5lY3Rvcl9zdGF0 ZS0+Y3J0YykKPiA+ICsJCQljb250aW51ZTsKPiA+ICsJCWlmICghY29ubmVjdG9yLT5oYXNfdGls ZSkKPiA+ICsJCQljb250aW51ZTsKPiA+ICsJCWlmIChjb25uZWN0b3ItPnRpbGVfaF9sb2MgPT0g Y29ubmVjdG9yLT5udW1faF90aWxlIC0gMSAmJgo+ID4gKwkJICAgIGNvbm5lY3Rvci0+dGlsZV92 X2xvYyA9PSBjb25uZWN0b3ItPm51bV92X3RpbGUgLSAxKQo+ID4gKwkJCWNvbnRpbnVlOwo+ID4g KwkJc2xhdmVfY3J0Y19zdGF0ZSA9IHRvX2ludGVsX2NydGNfc3RhdGUoCj4gPiArCQkJZHJtX2F0 b21pY19nZXRfbmV3X2NydGNfc3RhdGUoc3RhdGUsCj4gPiArCQkJCQkJICAgICAgY29ubmVjdG9y X3N0YXRlLT5jcnRjKSk7Cj4gPiArCQlzbGF2ZV9jcnRjX3N0YXRlLT5nZW5sb2NrX2NydGMgPSBO VUxMOwo+ID4gKwkJdGlsZV9ncm91cF9pZCA9IGNvbm5lY3Rvci0+dGlsZV9ncm91cC0+aWQ7Cj4g PiArCQlkcm1fY29ubmVjdG9yX2xpc3RfaXRlcl9iZWdpbihkZXYsICZjb25uX2l0ZXIpOwo+ID4g KwkJZHJtX2Zvcl9lYWNoX2Nvbm5lY3Rvcl9pdGVyKGdlbmxvY2tfY29ubmVjdG9yLCAmY29ubl9p dGVyKSB7Cj4gPiArCQkJc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKmdlbmxvY2tfY29ubl9z dGF0ZSA9IE5VTEw7Cj4gPiArCj4gPiArCQkJaWYgKCFnZW5sb2NrX2Nvbm5lY3Rvci0+aGFzX3Rp bGUpCj4gPiArCQkJCWNvbnRpbnVlOwo+ID4gKwkJCWlmIChnZW5sb2NrX2Nvbm5lY3Rvci0+dGls ZV9oX2xvYyAhPSBnZW5sb2NrX2Nvbm5lY3Rvci0+bnVtX2hfdGlsZSAtIDEgfHwKPiA+ICsJCQkg ICAgZ2VubG9ja19jb25uZWN0b3ItPnRpbGVfdl9sb2MgIT0gZ2VubG9ja19jb25uZWN0b3ItPm51 bV92X3RpbGUgLSAxKQo+ID4gKwkJCQljb250aW51ZTsKPiA+ICsJCQlpZiAoZ2VubG9ja19jb25u ZWN0b3ItPnRpbGVfZ3JvdXAtPmlkICE9IHRpbGVfZ3JvdXBfaWQpCj4gPiArCQkJCWNvbnRpbnVl Owo+ID4gKwo+ID4gKwkJCWdlbmxvY2tfY29ubl9zdGF0ZSA9IGRybV9hdG9taWNfZ2V0X2Nvbm5l Y3Rvcl9zdGF0ZShzdGF0ZSwKPiA+ICsJCQkJCQkJCQkgICAgZ2VubG9ja19jb25uZWN0b3IpOwo+ ID4gKwkJCWlmIChJU19FUlIoZ2VubG9ja19jb25uX3N0YXRlKSkgewo+ID4gKwkJCQlkcm1fY29u bmVjdG9yX2xpc3RfaXRlcl9lbmQoJmNvbm5faXRlcik7Cj4gPiArCQkJCXJldHVybiBQVFJfRVJS KGdlbmxvY2tfY29ubl9zdGF0ZSk7Cj4gPiArCQkJfQo+ID4gKwkJCWlmIChnZW5sb2NrX2Nvbm5f c3RhdGUtPmNydGMpIHsKPiA+ICsJCQkJZ2VubG9ja19jcnRjID0gZ2VubG9ja19jb25uX3N0YXRl LT5jcnRjOwo+ID4gKwkJCQlicmVhazsKPiA+ICsJCQl9Cj4gPiArCQl9Cj4gPiArCQlkcm1fY29u bmVjdG9yX2xpc3RfaXRlcl9lbmQoJmNvbm5faXRlcik7Cj4gCj4gVGhlIGFib3ZlIGxvb3Agd291 bGQgYmVuZWZpdCBmcm9tIGJlaW5nIGFic3RyYWN0ZWQgdG8gYSBzZXBhcmF0ZQo+IGZ1bmN0aW9u LiAiZmluZCBnZW5sb2NrIG1hc3RlciBiYXNlZCBvbiB0aWxlIGluZm8iCj4gCj4gSSB3b25kZXIg aWYgaXQgd291bGQgd29yayB0byBoYXZlIGVhY2ggcmVsZXZhbnQgZW5jb2RlciAtPmNvbXB1dGVf Y29uZmlnCj4gaG9vayBsb29rIGZvciBpdHMgZ2VubG9jayBtYXN0ZXIgaW5zdGVhZCBvZiBhZGRp bmcgYW5vdGhlciB0b3AgbGV2ZWwKPiBsb29wLgoKU28gYXJlIHlvdSBzdWdnZXN0aW5nIGFkZGlu ZyB0aGlzIGRpcmVjdGx5IGluc2lkZSBzYXkgY29tcHV0ZV9jb25maWcoKSBob29rCmZvciBEUCBl bmNvZGVyIHNvIGluc2lkZSBpbnRlbF9kcF9jb21wdXRlX2NvbmZpZygpLCBvciB3b3VsZCBpdCBi ZSBiZXR0ZXIgdG8gYWRkCmp1c3QgdGhlIGlubmVyIGZpbmRfZ2VubG9ja19tYXN0ZXIoKSBmdW5j dGlvbiBpbiB0aGUgZXhpc3RpbmcgZm9yX2VhY2hfY29ubmVjdG9yKCkgaW4gaW50ZWxfbW9kZXNl dF9waXBlX2NvbmZpZygpCmJlZm9yZSBjYWxsaW5nIGludG8gdGhlIGNvbXB1dGVfY29uZmlnIGVu Y29kZXIgaG9vaz8KClJlZ2FyZHMKTWFuYXNpCj4gCj4gQlIsCj4gSmFuaS4KPiAKPiAKPiA+ICsK PiA+ICsJCWlmICghZ2VubG9ja19jcnRjKSB7Cj4gPiArCQkJRFJNX0RFQlVHX0tNUygiQ291bGQg bm90IGFkZCBHZW5sb2NrIENSVEMgZm9yIFNsYXZlIENSVEMgJWRcbiIsCj4gPiArCQkJCSAgICAg IGNvbm5lY3Rvcl9zdGF0ZS0+Y3J0Yy0+YmFzZS5pZCk7Cj4gPiArCQkJcmV0dXJuIC1FSU5WQUw7 Cj4gPiArCQl9Cj4gPiArCj4gPiArCQlnZW5sb2NrX2NydGNfc3RhdGUgPSBkcm1fYXRvbWljX2dl dF9jcnRjX3N0YXRlKHN0YXRlLAo+ID4gKwkJCQkJCQkgICAgICAgZ2VubG9ja19jcnRjKTsKPiA+ ICsJCWlmIChJU19FUlIoZ2VubG9ja19jcnRjX3N0YXRlKSkKPiA+ICsJCQlyZXR1cm4gUFRSX0VS UihnZW5sb2NrX2NydGNfc3RhdGUpOwo+ID4gKwo+ID4gKwkJc2xhdmVfY3J0Y19zdGF0ZS0+Z2Vu bG9ja19jcnRjID0gdG9faW50ZWxfY3J0YyhnZW5sb2NrX2NydGMpOwo+ID4gKwkJRFJNX0RFQlVH X0tNUygiR2VubG9jayBDUlRDID0gJWQgYWRkZWQgZm9yIFNsYXZlIENSVEMgPSAlZFxuIiwKPiA+ ICsJCQkgICAgICBnZW5sb2NrX2NydGMtPmJhc2UuaWQsCj4gPiArCQkJICAgICAgc2xhdmVfY3J0 Y19zdGF0ZS0+YmFzZS5jcnRjLT5iYXNlLmlkKTsKPiA+ICsJfQo+ID4gKwo+ID4gKwlyZXR1cm4g MDsKPiA+ICt9Cj4gPiArCj4gPiAgc3RhdGljIGludCBpbnRlbF9jcnRjX2F0b21pY19jaGVjayhz dHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gPiAgCQkJCSAgIHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAq Y3J0Y19zdGF0ZSkKPiA+ICB7Cj4gPiBAQCAtMTMwOTgsNiArMTMxNzgsMTAgQEAgc3RhdGljIGlu dCBpbnRlbF9hdG9taWNfY2hlY2soc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+ICAJaWYgKHJl dCkKPiA+ICAJCXJldHVybiByZXQ7Cj4gPiAgCj4gPiArCXJldCA9IGljbF9hZGRfZ2VubG9ja19j cnRjcyhkZXYsIHN0YXRlKTsKPiA+ICsJaWYgKHJldCkKPiA+ICsJCXJldHVybiByZXQ7Cj4gPiAr Cj4gPiAgCWZvcl9lYWNoX29sZG5ld19jcnRjX2luX3N0YXRlKHN0YXRlLCBjcnRjLCBvbGRfY3J0 Y19zdGF0ZSwgY3J0Y19zdGF0ZSwgaSkgewo+ID4gIAkJc3RydWN0IGludGVsX2NydGNfc3RhdGUg KnBpcGVfY29uZmlnID0KPiA+ICAJCQl0b19pbnRlbF9jcnRjX3N0YXRlKGNydGNfc3RhdGUpOwo+ ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiA+IGluZGV4IDRkN2FlNTc5ZmM5Mi4uYjQxNzI4 OTQ2YjczIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgK PiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gPiBAQCAtMTA3NCw2 ICsxMDc0LDkgQEAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgewo+ID4gIAo+ID4gIAkvKiBGb3J3 YXJkIEVycm9yIGNvcnJlY3Rpb24gU3RhdGUgKi8KPiA+ICAJYm9vbCBmZWNfZW5hYmxlOwo+ID4g Kwo+ID4gKwkvKiBQb2ludGVyIHRvIG1hc3Rlci9nZW5sb2NrIGNydGMgaW4gY2FzZSBvZiB0aWxl ZCBkaXNwbGF5cyAqLwo+ID4gKwlzdHJ1Y3QgaW50ZWxfY3J0YyAqZ2VubG9ja19jcnRjOwo+ID4g IH07Cj4gPiAgCj4gPiAgc3RydWN0IGludGVsX2NydGMgewo+IAo+IC0tIAo+IEphbmkgTmlrdWxh LCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4