From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A0D2C43381 for ; Mon, 1 Apr 2019 18:06:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 051AB20663 for ; Mon, 1 Apr 2019 18:06:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730627AbfDASGI (ORCPT ); Mon, 1 Apr 2019 14:06:08 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:32956 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730445AbfDARND (ORCPT ); Mon, 1 Apr 2019 13:13:03 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B8F8D14B8AF64; Mon, 1 Apr 2019 10:13:02 -0700 (PDT) Date: Fri, 29 Mar 2019 13:17:11 -0700 (PDT) Message-Id: <20190329.131711.2043491726296499419.davem@davemloft.net> To: edumazet@google.com Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, soheil@google.com, willemb@google.com Subject: Re: [PATCH net-next] tcp: cleanup sk_tx_skb_cache before reuse From: David Miller In-Reply-To: <20190329194617.195528-1-edumazet@google.com> References: <20190329194617.195528-1-edumazet@google.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 01 Apr 2019 10:13:02 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Eric Dumazet Date: Fri, 29 Mar 2019 12:46:17 -0700 > TCP stack relies on the fact that a freshly allocated skb > has skb->cb[] and skb_shinfo(skb)->tx_flags cleared. > > When recycling tx skb, we must ensure these fields are cleared. > > Fixes: 472c2e07eef0 ("tcp: add one skb cache for tx") > Signed-off-by: Eric Dumazet Applied, thanks Eric.