From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC2FEC43381 for ; Fri, 29 Mar 2019 06:49:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ABBD02082F for ; Fri, 29 Mar 2019 06:49:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SgvAku8j" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728787AbfC2Gth (ORCPT ); Fri, 29 Mar 2019 02:49:37 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:35702 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728700AbfC2Gth (ORCPT ); Fri, 29 Mar 2019 02:49:37 -0400 Received: by mail-pl1-f195.google.com with SMTP id p19so570865plo.2 for ; Thu, 28 Mar 2019 23:49:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JyhG4KiqlmUctaeL7IFcdOPmGqfvH8RvX9zGV1WlMVQ=; b=SgvAku8jw3wNvgs0TT7my7hxPqoXsHzhUdta34s0A60ci2PMJ4TJtUWb107YbCrxdq PwlX3Fu4CBQkx1gTDxhE/Q7H1N0dOREQ6PRtdz83ZijOt56JRd6shbHixMxi2MqsLDNY yUHPVP1oQ6zGAsc6iz6jReJkzlbipuLDhs8IUvFdMoyQFBXenyWo5zm+nNNrmCuyZKgP As0CoJOfRlDBp4lLxbv6c6PO7235x8S6qJesaHcggxO4c3nGocRoggnreF5TkVGr0U42 3QSW/amV9/PSJArijESjrm9Zzgqn/Xs7OuTM8YwHEPxQQKpHJpaR0YqwqHSrM/xZUaeV glRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JyhG4KiqlmUctaeL7IFcdOPmGqfvH8RvX9zGV1WlMVQ=; b=C+C8n9U1LKR9x2oyhrERpr3ksVFCc5/jNFXSbhSN78Fn/eruJggZMTt0uQSzx3Ubxf aOtK0LblvHjCcK/wH+bBvJy/PLgm6MW7GG0CzgAE71nqMz0vw9fsM5kexLZD+A6+JEXy UsekkG6ealg0QxiuxMSSt/9Z6CbH/bk3TMx7aFiun23AHlJrdOR7DvTYVHh6ZADR1uVd DkLPpkWsZJESPV+qEZtLzK1FYUXyqB0R+9+KHzvy2DuEE4hazG15y0/9PwyokDEtb2Wm 4zBDIfXjnMfHB9+MkyIeAUUkKxpUFicyYvMWwsN2jWcdXfhdTr/whqb8J1JZ6DsdtCBk iBAg== X-Gm-Message-State: APjAAAV5Dj+b/DzZA0j+VGy0SyUfDy+BE0QVIjlgRmMzw2An25SCQrLN cdFpjWUR1eYR7OjT9UOwhzg= X-Google-Smtp-Source: APXvYqxJsoIPHTMM893IvjPDXA3c35Q3WVKowu3BuI5NY3nm2bAneFzlEj+i5R9Xufith4BF5tlTJg== X-Received: by 2002:a17:902:12f:: with SMTP id 44mr47511002plb.208.1553842176395; Thu, 28 Mar 2019 23:49:36 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id i5sm1602818pfd.16.2019.03.28.23.49.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Mar 2019 23:49:35 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Cc: Andrey Smirnov , Lucas Stach , Angus Ainslie , Chris Healy , Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/9] ARM: dts: imx6qdl: Specify IMX6QDL_CLK_IPG as "ipg" clock to SDMA Date: Thu, 28 Mar 2019 23:49:16 -0700 Message-Id: <20190329064924.8728-1-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" clock to determine if it needs to configure the IP block as operating at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both clocks as IMX6QDL_CLK_SDMA results in driver incorrectly thinking that ratio is 1:1 which results in broken SDMA funtionality(this at least breaks RAVE SP serdev driver on RDU2). Fix the code to specify IMX6QDL_CLK_IPG as "ipg" clock for SDMA, to avoid detecting incorrect clock ratio. Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Signed-off-by: Andrey Smirnov Reviewed-by: Lucas Stach Cc: Angus Ainslie (Purism) Cc: Chris Healy Cc: Lucas Stach Cc: Fabio Estevam Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/imx6qdl.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index 9f9aa6e7ed0e..354feba077b2 100644 --- a/arch/arm/boot/dts/imx6qdl.dtsi +++ b/arch/arm/boot/dts/imx6qdl.dtsi @@ -949,7 +949,7 @@ compatible = "fsl,imx6q-sdma", "fsl,imx35-sdma"; reg = <0x020ec000 0x4000>; interrupts = <0 2 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&clks IMX6QDL_CLK_SDMA>, + clocks = <&clks IMX6QDL_CLK_IPG>, <&clks IMX6QDL_CLK_SDMA>; clock-names = "ipg", "ahb"; #dma-cells = <3>; -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BEF6C43381 for ; Fri, 29 Mar 2019 06:49:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A7892183F for ; Fri, 29 Mar 2019 06:49:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="I8q8KzyV"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SgvAku8j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A7892183F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=7L7Pk7fSY1C5Co42FAkx9MY1I+nOepf+ws4d7w0WCoU=; b=I8q8KzyVBRxdH6 kn9BeFbmhMU8x49iIFZ8oJsZXbvfjQpIumwJ5JAtAo4ApDexynBRXkFvte5xzNrqVbGhKERzFmtp9 1KDAy8B1YzUwZr+SagYPHby0LP3MhXHvXTcDonwCiL7woPzcpU0SuI48RhmTyvaymDEPy71h9J6Lq hVmRNZamPqF5W3Pi5JhG19XjDowNQEr7SadH+5IYOQrpUEKMoKpkwGwEdCW0lh1vwY1dGvWMcFhu6 u+LuJctUgP5O2URvwNEv8wn47IZj9vrfYNNMAzn4DB9I9ZOJWfLIE4k58heN7PlqGJTggJ3WsDCmg EQKUjG2TbJxdL0XVR1jw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lKd-0003xR-Ro; Fri, 29 Mar 2019 06:49:39 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lKa-0003wm-VR for linux-arm-kernel@lists.infradead.org; Fri, 29 Mar 2019 06:49:38 +0000 Received: by mail-pl1-x642.google.com with SMTP id g12so550908pll.11 for ; Thu, 28 Mar 2019 23:49:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JyhG4KiqlmUctaeL7IFcdOPmGqfvH8RvX9zGV1WlMVQ=; b=SgvAku8jw3wNvgs0TT7my7hxPqoXsHzhUdta34s0A60ci2PMJ4TJtUWb107YbCrxdq PwlX3Fu4CBQkx1gTDxhE/Q7H1N0dOREQ6PRtdz83ZijOt56JRd6shbHixMxi2MqsLDNY yUHPVP1oQ6zGAsc6iz6jReJkzlbipuLDhs8IUvFdMoyQFBXenyWo5zm+nNNrmCuyZKgP As0CoJOfRlDBp4lLxbv6c6PO7235x8S6qJesaHcggxO4c3nGocRoggnreF5TkVGr0U42 3QSW/amV9/PSJArijESjrm9Zzgqn/Xs7OuTM8YwHEPxQQKpHJpaR0YqwqHSrM/xZUaeV glRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JyhG4KiqlmUctaeL7IFcdOPmGqfvH8RvX9zGV1WlMVQ=; b=PG2yUSygKOMM/GEN7J1K/qJmtVsW6NJPu5+RV3BlRhKALpC/s2l8WSG0kszr0y2Qn3 bkndKSBtDlYHODZ57HVGxXawNWDaXVuk+1YDQWufZWUkTsTEvh5g1veAsai/Mtc7Hezy lE41dkz2rv8MS9uOMslVZjK2bC06acj1CqLSxpE/vKl99Prb75VhnqFTFE+4OnF7HDe2 8T4ymD+IyN50YJBynKzsbN646BIzY4YpUMQcfRyNUSvzIi702wBH3ioSbhIaDXqU2a5p C/uNq+IJTZe7/umBoyDJh2xZkBz7slgkI5v23L4jJbZE3zGA8AbGzBWcyE73Dh5zOzY/ dHlg== X-Gm-Message-State: APjAAAW6PlaGg3OLPtUb2DKhdLPet0vGZN205Bn60m5jtnEp2EGRe+hO JHIl5jpHmkO7JCXjonIME8g= X-Google-Smtp-Source: APXvYqxJsoIPHTMM893IvjPDXA3c35Q3WVKowu3BuI5NY3nm2bAneFzlEj+i5R9Xufith4BF5tlTJg== X-Received: by 2002:a17:902:12f:: with SMTP id 44mr47511002plb.208.1553842176395; Thu, 28 Mar 2019 23:49:36 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id i5sm1602818pfd.16.2019.03.28.23.49.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Mar 2019 23:49:35 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Subject: [PATCH v3 1/9] ARM: dts: imx6qdl: Specify IMX6QDL_CLK_IPG as "ipg" clock to SDMA Date: Thu, 28 Mar 2019 23:49:16 -0700 Message-Id: <20190329064924.8728-1-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_234937_033426_0A8E0DAA X-CRM114-Status: GOOD ( 12.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Angus Ainslie , linux-kernel@vger.kernel.org, Chris Healy , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lucas Stach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" clock to determine if it needs to configure the IP block as operating at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both clocks as IMX6QDL_CLK_SDMA results in driver incorrectly thinking that ratio is 1:1 which results in broken SDMA funtionality(this at least breaks RAVE SP serdev driver on RDU2). Fix the code to specify IMX6QDL_CLK_IPG as "ipg" clock for SDMA, to avoid detecting incorrect clock ratio. Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Signed-off-by: Andrey Smirnov Reviewed-by: Lucas Stach Cc: Angus Ainslie (Purism) Cc: Chris Healy Cc: Lucas Stach Cc: Fabio Estevam Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/imx6qdl.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index 9f9aa6e7ed0e..354feba077b2 100644 --- a/arch/arm/boot/dts/imx6qdl.dtsi +++ b/arch/arm/boot/dts/imx6qdl.dtsi @@ -949,7 +949,7 @@ compatible = "fsl,imx6q-sdma", "fsl,imx35-sdma"; reg = <0x020ec000 0x4000>; interrupts = <0 2 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&clks IMX6QDL_CLK_SDMA>, + clocks = <&clks IMX6QDL_CLK_IPG>, <&clks IMX6QDL_CLK_SDMA>; clock-names = "ipg", "ahb"; #dma-cells = <3>; -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel