From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 304FAC43381 for ; Fri, 29 Mar 2019 06:50:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA5192082F for ; Fri, 29 Mar 2019 06:50:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mXVa01cB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728816AbfC2Gtl (ORCPT ); Fri, 29 Mar 2019 02:49:41 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:36772 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728700AbfC2Gti (ORCPT ); Fri, 29 Mar 2019 02:49:38 -0400 Received: by mail-pl1-f195.google.com with SMTP id k2so568596plt.3 for ; Thu, 28 Mar 2019 23:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ATUitjO3l5PbwZI7xwdst/n1EivnhW4ELZtfYtpsmzw=; b=mXVa01cBPZ7ASZa37qhHs4ST7gC2TNZy2CJhdh58DleRfCAP5gO4/Gj0HF4UhfotyW dLOckldShqSGLe45uZYTabqXJ7AeBliYVfzcRkDT6llDdzcSEIFoTNbsknh3g8mXCKYM cu6GdE749wjKCS/dl+3vcMExs0my2l0IVThw1yiR33vxNPuAuB/yJKeoOarXtv3tC5gh sxCL+sYFdFyZb+9l8FgrEudBO6Vzqx4X0Sf0B7tFN7YqAYZSAd40G8OshNNhGTQhvrUF Mq5AWfsQtuMHddOvpWqbrxvn6JprOWzNOUOMQ8kR84+nu9qjJPP9EWAlEGVtmb7ib7fM nyHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ATUitjO3l5PbwZI7xwdst/n1EivnhW4ELZtfYtpsmzw=; b=TrrIuZMnHWVBuvg7NKHlarq9E/FNy4qK8Qr2BIbMAV9ka+Nfn65qIlUc8tCn7Sjhmq ISKuExboaug6uYCIBDVAwF0bQVTp//K3WYLTIeTLePmz/m6fsqLx8EcYHxgsuTSb+MXU feirScBUB3iLa+1CJUE7+NKGZFkC90zB1wUD0C9sCC8geYeKMIG1uAsHieSjrqkJXofy L4CMmFNNgpNVbMa8TfXPwXcb82naMPQkdun/SljVoIRm869YLQ0T9OgejtoW4d97cbL0 4WA7FZj4WsqoQoy5/KXiZElcYuzagw+4x1KSvBLshk6B1PFcFlIpc9ehzax8PxP9xYV7 o6dw== X-Gm-Message-State: APjAAAWYdS6N6Sz3PODIPNjy5Ha5H1bZYNgSPF889kUC462yOCwJwL9X uFAXi7y/z0l+ecXfIWI2i9k= X-Google-Smtp-Source: APXvYqzV0tPHbLG88WNKysL3Wa8O359cTEJVEk9eVaBs+hzI7yM83kE12caFJk5WxVMmsfMrp6Spow== X-Received: by 2002:a17:902:526:: with SMTP id 35mr44501356plf.276.1553842177646; Thu, 28 Mar 2019 23:49:37 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id i5sm1602818pfd.16.2019.03.28.23.49.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Mar 2019 23:49:36 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Cc: Andrey Smirnov , Angus Ainslie , Chris Healy , Lucas Stach , Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/9] ARM: dts: imx6sx: Specify IMX6SX_CLK_IPG as "ipg" clock to SDMA Date: Thu, 28 Mar 2019 23:49:17 -0700 Message-Id: <20190329064924.8728-2-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190329064924.8728-1-andrew.smirnov@gmail.com> References: <20190329064924.8728-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" clock to determine if it needs to configure the IP block as operating at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both clocks as IMX6SX_CLK_SDMA results in driver incorrectly thinking that ratio is 1:1 which results in broken SDMA funtionality. Fix the code to specify IMX6SX_CLK_IPG as "ipg" clock for SDMA, to avoid detecting incorrect clock ratio. Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Signed-off-by: Andrey Smirnov Cc: Angus Ainslie (Purism) Cc: Chris Healy Cc: Lucas Stach Cc: Fabio Estevam Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/imx6sx.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi index df0c59519886..b16a123990a2 100644 --- a/arch/arm/boot/dts/imx6sx.dtsi +++ b/arch/arm/boot/dts/imx6sx.dtsi @@ -820,7 +820,7 @@ compatible = "fsl,imx6sx-sdma", "fsl,imx6q-sdma"; reg = <0x020ec000 0x4000>; interrupts = ; - clocks = <&clks IMX6SX_CLK_SDMA>, + clocks = <&clks IMX6SX_CLK_IPG>, <&clks IMX6SX_CLK_SDMA>; clock-names = "ipg", "ahb"; #dma-cells = <3>; -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55C9FC43381 for ; Fri, 29 Mar 2019 06:50:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2732F2082F for ; Fri, 29 Mar 2019 06:50:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="M15J24JZ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mXVa01cB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2732F2082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yp9mHLNvnVaJC6ltYC9Zbn4in3Yn6MzsxPnFLqx6p4A=; b=M15J24JZncI4+n /gWbamMaNitIDSF85rVhQjJRARlERl3bow83IXWI8dRsMlfu2gbyWQrtAZclPVcJxNAjoCtTv48C1 nfd5KgJdrCM3WaYAg6ubuo9eHvAWu28GxcaE8+SfA8Px1v31ngdWpTSzUlGwLC3iXxXP0+JY9bi5F oTIeL12bCgzsjZQbgz6vpnnV5Je63HnEGjP0BU4/Y0oBk5kVJwOLOukQokRycqNzmw1K6cvaS27hD lYym/bSH0FOAh+tT6cDwlAbpIrJA/YjGJ2/nIxREm+Dn+4q7icqfCkC0axNY4xF27uBZC8jC091Nw w9S5p/CT81cJUTjerTxw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lKu-0004GA-4G; Fri, 29 Mar 2019 06:49:56 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lKc-0003x0-4D for linux-arm-kernel@lists.infradead.org; Fri, 29 Mar 2019 06:49:39 +0000 Received: by mail-pl1-x642.google.com with SMTP id m10so551412plt.10 for ; Thu, 28 Mar 2019 23:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ATUitjO3l5PbwZI7xwdst/n1EivnhW4ELZtfYtpsmzw=; b=mXVa01cBPZ7ASZa37qhHs4ST7gC2TNZy2CJhdh58DleRfCAP5gO4/Gj0HF4UhfotyW dLOckldShqSGLe45uZYTabqXJ7AeBliYVfzcRkDT6llDdzcSEIFoTNbsknh3g8mXCKYM cu6GdE749wjKCS/dl+3vcMExs0my2l0IVThw1yiR33vxNPuAuB/yJKeoOarXtv3tC5gh sxCL+sYFdFyZb+9l8FgrEudBO6Vzqx4X0Sf0B7tFN7YqAYZSAd40G8OshNNhGTQhvrUF Mq5AWfsQtuMHddOvpWqbrxvn6JprOWzNOUOMQ8kR84+nu9qjJPP9EWAlEGVtmb7ib7fM nyHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ATUitjO3l5PbwZI7xwdst/n1EivnhW4ELZtfYtpsmzw=; b=MjBgmU6zjsV8CEMOu/o9RGyL7ruKy/l+TWZ3FGs+NAaaILTiy6KGrgGNSomCQDm9+J ZO+vgELz426gFgYaGVNf3L41UamcFvQa0DoIM71umtLW5XhzK2ElIzyrJz2rpBBQPo2F XrLTNOl+OM30fY3SbTKipv6r43c85lvJqrg0CWZQ4rmKV4FgxaMnVIW1LL/jLTH02spK RntVj/FoNvQlQddEhCm4VU4pjXWUNXGtEYsnQJo5oA4Aqb8KexCX7bF3MASDdmqDaHTs ZyUcLrybFSHJuN6BvRQBEHSKjjYx9Bhkt54WsAJWWUHexHZV//iW9jvGkgKGn6TVmPzV wMnQ== X-Gm-Message-State: APjAAAXeBIHvLX0lUDjT1trgGxW32aGldjszs9QsGwyMMYiBjF8iRssN 5d/chjEi0K3LD4IeWpA9oYY= X-Google-Smtp-Source: APXvYqzV0tPHbLG88WNKysL3Wa8O359cTEJVEk9eVaBs+hzI7yM83kE12caFJk5WxVMmsfMrp6Spow== X-Received: by 2002:a17:902:526:: with SMTP id 35mr44501356plf.276.1553842177646; Thu, 28 Mar 2019 23:49:37 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id i5sm1602818pfd.16.2019.03.28.23.49.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Mar 2019 23:49:36 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Subject: [PATCH v3 2/9] ARM: dts: imx6sx: Specify IMX6SX_CLK_IPG as "ipg" clock to SDMA Date: Thu, 28 Mar 2019 23:49:17 -0700 Message-Id: <20190329064924.8728-2-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190329064924.8728-1-andrew.smirnov@gmail.com> References: <20190329064924.8728-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_234938_163214_450B7EB0 X-CRM114-Status: GOOD ( 13.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Angus Ainslie , linux-kernel@vger.kernel.org, Chris Healy , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lucas Stach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" clock to determine if it needs to configure the IP block as operating at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both clocks as IMX6SX_CLK_SDMA results in driver incorrectly thinking that ratio is 1:1 which results in broken SDMA funtionality. Fix the code to specify IMX6SX_CLK_IPG as "ipg" clock for SDMA, to avoid detecting incorrect clock ratio. Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Signed-off-by: Andrey Smirnov Cc: Angus Ainslie (Purism) Cc: Chris Healy Cc: Lucas Stach Cc: Fabio Estevam Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/imx6sx.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi index df0c59519886..b16a123990a2 100644 --- a/arch/arm/boot/dts/imx6sx.dtsi +++ b/arch/arm/boot/dts/imx6sx.dtsi @@ -820,7 +820,7 @@ compatible = "fsl,imx6sx-sdma", "fsl,imx6q-sdma"; reg = <0x020ec000 0x4000>; interrupts = ; - clocks = <&clks IMX6SX_CLK_SDMA>, + clocks = <&clks IMX6SX_CLK_IPG>, <&clks IMX6SX_CLK_SDMA>; clock-names = "ipg", "ahb"; #dma-cells = <3>; -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel