From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDB61C43381 for ; Fri, 29 Mar 2019 06:49:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C55A2082F for ; Fri, 29 Mar 2019 06:49:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A3T01U2L" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728873AbfC2Gtv (ORCPT ); Fri, 29 Mar 2019 02:49:51 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:37788 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728827AbfC2Gtm (ORCPT ); Fri, 29 Mar 2019 02:49:42 -0400 Received: by mail-pl1-f196.google.com with SMTP id q6so565334pll.4 for ; Thu, 28 Mar 2019 23:49:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=klOQQder074G6QHLH5zIbrfbm39+4L8f6wWRAdAHSDY=; b=A3T01U2LaJJfUFIHi9Uynzel0Se7kfMqns7j3aJ+mcXBvDMYUrEKj7kFtywWt3UauZ jjghDJ2GN61ejYubBhsRcU8D6i78y5p1Y5nvY6tripyM1xnVJ4Y2/u+cFN4fwi2LiKIe v6IojykzLkuSnHTrL/lC9ZF5qcwy0FVm0fOuJfP+lIvI517RSAyjUhxilSUQFbWmhwaB 9wy/BFPbmyMwk1wPwWkI9t0jmTzMOcVmQi1kfLJkZult0Os9FbEbLLMwTzKL4w0cxLvg ZKCixyQegnm/AAVCHimWuuhbrMkHGYIYNtf+yCzsF7kaYGkjK8sD61jn3tRX0jvk0XZw WaYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=klOQQder074G6QHLH5zIbrfbm39+4L8f6wWRAdAHSDY=; b=LhSwOU/RoiKy/3zQ374Q3bQ9wYwnbNs6P2EK+BPSw8Qeo8IM+sAHYCgvmsANgi6h81 yyaWv4nTpNnA8rHMJwFNAwjD+3aXFM5GLLZ4xYgDVwOsEznI74DD3wSRDHRwrTTqrJf6 U9qeiTzLyMCIASx8XrHYFkJyj9fAav3IytbgSt4XKNYZDKiYOgfs5KkM1n+Vv+8PFi9v kAwDWxK2kYuLrA31GTHy/lP6E/lwZTqvKk0fPKlHij5kWCW+Wp4W/i2BumS+V5xSjGrx muzOhqdmXvKaQzN1BNhEeyXiAjQDLLPzaKcaVnWTDZSh6Pd8qJTPcCgR8TDyEhJhrzvS EAIQ== X-Gm-Message-State: APjAAAXaD7tW5BB0e96+urhhQ5bF4anPEqrZ3+CywS1Pw1lfoME9oYEA O6PXJ2J1a9q76UdinKPQmNE= X-Google-Smtp-Source: APXvYqxffam5Lj41/BYdtCA9pV8HcHSI25Yg6Yn5m7tFnacaLSC+0EkebK08KLGNmOwAJaHF4xJhoA== X-Received: by 2002:a17:902:70c8:: with SMTP id l8mr15461096plt.177.1553842181806; Thu, 28 Mar 2019 23:49:41 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id i5sm1602818pfd.16.2019.03.28.23.49.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Mar 2019 23:49:41 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Cc: Andrey Smirnov , Angus Ainslie , Chris Healy , Lucas Stach , Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 5/9] ARM: dts: imx6sll: Specify IMX6SLL_CLK_IPG as "ipg" clock to SDMA Date: Thu, 28 Mar 2019 23:49:20 -0700 Message-Id: <20190329064924.8728-5-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190329064924.8728-1-andrew.smirnov@gmail.com> References: <20190329064924.8728-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" clock to determine if it needs to configure the IP block as operating at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both clocks as IMX6SLL_CLK_SDMA result in driver incorrectly thinking that ratio is 1:1 which results in broken SDMA funtionality. Fix the code to specify IMX6SLL_CLK_IPG as "ipg" clock for SDMA, to avoid detecting incorrect clock ratio. Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Signed-off-by: Andrey Smirnov Cc: Angus Ainslie (Purism) Cc: Chris Healy Cc: Lucas Stach Cc: Fabio Estevam Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/imx6sll.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6sll.dtsi b/arch/arm/boot/dts/imx6sll.dtsi index 62847c68330b..ed598d72038c 100644 --- a/arch/arm/boot/dts/imx6sll.dtsi +++ b/arch/arm/boot/dts/imx6sll.dtsi @@ -621,7 +621,7 @@ compatible = "fsl,imx6sll-sdma", "fsl,imx35-sdma"; reg = <0x020ec000 0x4000>; interrupts = ; - clocks = <&clks IMX6SLL_CLK_SDMA>, + clocks = <&clks IMX6SLL_CLK_IPG>, <&clks IMX6SLL_CLK_SDMA>; clock-names = "ipg", "ahb"; #dma-cells = <3>; -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64A16C43381 for ; Fri, 29 Mar 2019 06:50:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 343B32082F for ; Fri, 29 Mar 2019 06:50:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QY4TXeMa"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A3T01U2L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 343B32082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xTrVU6I+HZM98JF1WIniMI7k3LbhgtPj1BRq9J2mMbw=; b=QY4TXeMaCTZjwm I+9UgXJRziQMjwyCfH4tT/5uEPL+Fc+Rz91jMBo0w4ETr+OMA2tJmC4Iyrd2fFq6QW56x33+qBqQT geh9+52+e8D8JfkuqrixIyLE6OawvyJZz8TXOSgbz/Bl1EVG6inYHO4iP0RAAwMJ3VYSPaB4XKSux D/d5c+2LTvRK1hO+aqUntv2gieiSIUMFKemYZxlKpeXDahaoXoeFX5edcca0LBwoX0g38m69KH7B0 5JtIzu0OkvZy8SPST+LvwNfVO99F6lXo3og5FcyzojGbgrNUITcIDn4s9C6+Jei+g2gdVJWa8zvQ1 Tm3JTnScxxqx80DHsGzA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lLT-0006Bv-Eg; Fri, 29 Mar 2019 06:50:31 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lKg-000412-Av for linux-arm-kernel@lists.infradead.org; Fri, 29 Mar 2019 06:49:45 +0000 Received: by mail-pl1-x641.google.com with SMTP id y6so572398plt.1 for ; Thu, 28 Mar 2019 23:49:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=klOQQder074G6QHLH5zIbrfbm39+4L8f6wWRAdAHSDY=; b=A3T01U2LaJJfUFIHi9Uynzel0Se7kfMqns7j3aJ+mcXBvDMYUrEKj7kFtywWt3UauZ jjghDJ2GN61ejYubBhsRcU8D6i78y5p1Y5nvY6tripyM1xnVJ4Y2/u+cFN4fwi2LiKIe v6IojykzLkuSnHTrL/lC9ZF5qcwy0FVm0fOuJfP+lIvI517RSAyjUhxilSUQFbWmhwaB 9wy/BFPbmyMwk1wPwWkI9t0jmTzMOcVmQi1kfLJkZult0Os9FbEbLLMwTzKL4w0cxLvg ZKCixyQegnm/AAVCHimWuuhbrMkHGYIYNtf+yCzsF7kaYGkjK8sD61jn3tRX0jvk0XZw WaYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=klOQQder074G6QHLH5zIbrfbm39+4L8f6wWRAdAHSDY=; b=UdFKK4gWwpEmbOMT3jdAQA0rM6GBFakoJvSJXJ+vpkG8bsIdSu67Ou6ZuMldaGjFan X29CyqUUAzFVeGy+qNBR0Elu0QBQGh/JZ8yPMPxo3ZZ6jSY5nw4PgDEPMMyzxTI/74Vw gWX37ktOAi76UxEK2msHMQ75xo2hGs342D/nUeioTy8Y/xdVBoz17qg5ETomUdRFKuMw U25D1lkdxhdvPUuC8eGlol47tjfSBrFbO/Jj+2ugpi6TF6FoGqhMggg+w8iK8T+b4YWe oA7PZ4jjfo6mgzZhvDxFLlZ2yC2lntygKqsEeG+No9CfbCHAVA+ddHLBeMTb1kE4RwTf /ahg== X-Gm-Message-State: APjAAAXLeaxWML4dBdsCUEpsM1rqQrBiFoorqX4IkPTZ2NW/CN3tU0bg uw+NSOulSh33hvE2oiMLs5U= X-Google-Smtp-Source: APXvYqxffam5Lj41/BYdtCA9pV8HcHSI25Yg6Yn5m7tFnacaLSC+0EkebK08KLGNmOwAJaHF4xJhoA== X-Received: by 2002:a17:902:70c8:: with SMTP id l8mr15461096plt.177.1553842181806; Thu, 28 Mar 2019 23:49:41 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id i5sm1602818pfd.16.2019.03.28.23.49.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Mar 2019 23:49:41 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Subject: [PATCH v3 5/9] ARM: dts: imx6sll: Specify IMX6SLL_CLK_IPG as "ipg" clock to SDMA Date: Thu, 28 Mar 2019 23:49:20 -0700 Message-Id: <20190329064924.8728-5-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190329064924.8728-1-andrew.smirnov@gmail.com> References: <20190329064924.8728-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_234942_802314_C417F4E0 X-CRM114-Status: GOOD ( 13.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Angus Ainslie , linux-kernel@vger.kernel.org, Chris Healy , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lucas Stach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" clock to determine if it needs to configure the IP block as operating at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both clocks as IMX6SLL_CLK_SDMA result in driver incorrectly thinking that ratio is 1:1 which results in broken SDMA funtionality. Fix the code to specify IMX6SLL_CLK_IPG as "ipg" clock for SDMA, to avoid detecting incorrect clock ratio. Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Signed-off-by: Andrey Smirnov Cc: Angus Ainslie (Purism) Cc: Chris Healy Cc: Lucas Stach Cc: Fabio Estevam Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/imx6sll.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6sll.dtsi b/arch/arm/boot/dts/imx6sll.dtsi index 62847c68330b..ed598d72038c 100644 --- a/arch/arm/boot/dts/imx6sll.dtsi +++ b/arch/arm/boot/dts/imx6sll.dtsi @@ -621,7 +621,7 @@ compatible = "fsl,imx6sll-sdma", "fsl,imx35-sdma"; reg = <0x020ec000 0x4000>; interrupts = ; - clocks = <&clks IMX6SLL_CLK_SDMA>, + clocks = <&clks IMX6SLL_CLK_IPG>, <&clks IMX6SLL_CLK_SDMA>; clock-names = "ipg", "ahb"; #dma-cells = <3>; -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel