From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 423C1C43381 for ; Fri, 29 Mar 2019 06:50:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 122642082F for ; Fri, 29 Mar 2019 06:50:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jbx8eCCx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728897AbfC2GuE (ORCPT ); Fri, 29 Mar 2019 02:50:04 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:43740 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728838AbfC2Gtq (ORCPT ); Fri, 29 Mar 2019 02:49:46 -0400 Received: by mail-pf1-f194.google.com with SMTP id c8so575940pfd.10 for ; Thu, 28 Mar 2019 23:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=k2Cjq9x631wLzGK9gtayGHpM1M/LJ4e0deWNdmi+j4Q=; b=Jbx8eCCxlkj9f7lJcaEAl/HEHgnmd23R2aMcPE63P988aQzKfTpRGRqss7KmVBiP90 jDkNg2oZxMGgXzun5Z4ASHo65AF2SsbCn5jEGOFay2GfCplLoJfJoUL/DB6sgh67f3Kb Iqee6lVHWiaClL11akdrKiRKVFU/w4NX5+xFhJr+J+YLjO6rB68zuLnbMvJHd5ERWrWK X3TzLtwek6CnqwZIdkCfjs07KR2E7RzQbo5wSZ6QJ1Z+Idil0GyLY8vaErb6BrvK4B+A lypAoCjfnYgf4zDlCl40bsd23rJmlC2SHNtZRmOASJQsH18jiJPcsv4PgcskE9jN2gko dwkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=k2Cjq9x631wLzGK9gtayGHpM1M/LJ4e0deWNdmi+j4Q=; b=PG2h1QPxTV//uHj8+W00tvgtaXHIAL6ZQf6nhMJNQWMmmkSJ9sp5x1q1uYyZoncfCi WMNDtLItwUrjUiUnz/YAF6+EMjAyik/MqnR5kerHh4Z0ZcZ/I205C0p7EDwhgtS00LF4 +IExeZC1KJ8AF3XfSe+OA1lhxueZ8G8jwlIsjEt5NNFnP11vPruvdUJUnKoj/EMDLazj +Gj9u4xDWbW2a+qVrGSTjw9mYQuM0KHw8UBqbZ6uq/NQyWuonB3o5IrnWiZvtgKnerdo jzyJ1Gnzxi1Se+DPghxRI07U9G3zJqNhdixHFXWlsgL55Mv2Cb/RHzZW/ddbuGcBqMaP 2QBA== X-Gm-Message-State: APjAAAUXt2mKc3wYYSvNhFV1M9DJrKLNlfmsC6wgGWULcik3dqUlz6Ud 8yFqYuh7g1MpkrWi28GC548= X-Google-Smtp-Source: APXvYqxLsZC5YO8cJYi/3oaIayEUxv71d9UTF146nTi30hXAygzBFtodjO31jw3aEpc97YjhVfGy+w== X-Received: by 2002:a63:78a:: with SMTP id 132mr36937172pgh.196.1553842185715; Thu, 28 Mar 2019 23:49:45 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id i5sm1602818pfd.16.2019.03.28.23.49.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Mar 2019 23:49:44 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Cc: Andrey Smirnov , Angus Ainslie , Chris Healy , Lucas Stach , Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 8/9] ARM: dts: imx51: Specify IMX5_CLK_IPG as "ahb" clock to SDMA Date: Thu, 28 Mar 2019 23:49:23 -0700 Message-Id: <20190329064924.8728-8-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190329064924.8728-1-andrew.smirnov@gmail.com> References: <20190329064924.8728-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" clock to determine if it needs to configure the IP block as operating at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both clocks as IMX5_CLK_SDMA results in driver incorrectly thinking that ratio is 1:1 which results in broken SDMA funtionality. Fix the code to specify IMX5_CLK_AHB as "ahb" clock for SDMA, to avoid detecting incorrect clock ratio. Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Signed-off-by: Andrey Smirnov Cc: Angus Ainslie (Purism) Cc: Chris Healy Cc: Lucas Stach Cc: Fabio Estevam Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/imx51.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi index 0b28b68a17bb..e3fa3d213cd8 100644 --- a/arch/arm/boot/dts/imx51.dtsi +++ b/arch/arm/boot/dts/imx51.dtsi @@ -502,7 +502,7 @@ reg = <0x83fb0000 0x4000>; interrupts = <6>; clocks = <&clks IMX5_CLK_SDMA_GATE>, - <&clks IMX5_CLK_SDMA_GATE>; + <&clks IMX5_CLK_AHB>; clock-names = "ipg", "ahb"; #dma-cells = <3>; fsl,sdma-ram-script-name = "imx/sdma/sdma-imx51.bin"; -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06002C43381 for ; Fri, 29 Mar 2019 06:51:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C29E32082F for ; Fri, 29 Mar 2019 06:51:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aV8M/gLX"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jbx8eCCx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C29E32082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FMXQ7yBUdygGImYp97inuvDy5oin5Ykmhu0UZA2Maz0=; b=aV8M/gLXTzXciJ 1nTc1FZMrRH45gJ/GVND6XRXvhu2zOlSs8sfOKaZogE7UJoArY0S/EP3eud4Fo/BbgkY1sHu+57MI SLpM9/eaUM1/HJXiVIdGSwBMhs7QIlkN3I8TqsFvjSTGieBaPJPNekKFwaOGahZ960vz9FLDsxWSZ fjS0nVhb6WudDwf5631NDiDdnU5K0H2fQ11QMb0dIRtID1G504pE5SnYKzJUu4wqLUbpBr/dQnz4K kj9W4b/JazafsCaiq7QkdEpDrgPzQbXbRwAY7mYjv3xXwbSPO2kahvypZTup9cgrSi3gnX2+l48aF ntmNr1LV3FIl9mSUDSCA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lLz-0006zv-8z; Fri, 29 Mar 2019 06:51:03 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lKl-00047D-BD for linux-arm-kernel@lists.infradead.org; Fri, 29 Mar 2019 06:49:51 +0000 Received: by mail-pf1-x443.google.com with SMTP id 188so579581pfd.8 for ; Thu, 28 Mar 2019 23:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=k2Cjq9x631wLzGK9gtayGHpM1M/LJ4e0deWNdmi+j4Q=; b=Jbx8eCCxlkj9f7lJcaEAl/HEHgnmd23R2aMcPE63P988aQzKfTpRGRqss7KmVBiP90 jDkNg2oZxMGgXzun5Z4ASHo65AF2SsbCn5jEGOFay2GfCplLoJfJoUL/DB6sgh67f3Kb Iqee6lVHWiaClL11akdrKiRKVFU/w4NX5+xFhJr+J+YLjO6rB68zuLnbMvJHd5ERWrWK X3TzLtwek6CnqwZIdkCfjs07KR2E7RzQbo5wSZ6QJ1Z+Idil0GyLY8vaErb6BrvK4B+A lypAoCjfnYgf4zDlCl40bsd23rJmlC2SHNtZRmOASJQsH18jiJPcsv4PgcskE9jN2gko dwkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=k2Cjq9x631wLzGK9gtayGHpM1M/LJ4e0deWNdmi+j4Q=; b=LAovk8BadjNhKTAOzyfuZWwxp+LRZPpFa9CeXr1mXsx86iwKKlsz2jpFkvL+CaHGIW HfoU3trl40Y/dI2AJSIMNkz0X7LiPBp4KjI1paS8VdJ2h28qDN4eCgt/gdXhfeHiDkq/ cm9yLsM5kHdoo5WKHMSdUaZlTKq5+JrrpEfNaV6YNlk86GZO8cxiGZS6w2t5Tixn4F5t +b4RjZwQqJePlBcPQjBLqNzzn0P5N5FgupaLFo7fRzVMjpG6yQX7MNHVl3zBTyO+kMRJ LxME3ZN4e5/G/8nPL2gmD2a2d0vpuX23P3dKJNoJyre4zverNo7gzqzROrVTqbDWDJx/ 6XvQ== X-Gm-Message-State: APjAAAX/zdy1aw29kJM5ZDVjiaej8vH/DrHfVDpay7teWWJqIH/SRRB2 Gnxi6PLGBZL7lhzayIe64ng= X-Google-Smtp-Source: APXvYqxLsZC5YO8cJYi/3oaIayEUxv71d9UTF146nTi30hXAygzBFtodjO31jw3aEpc97YjhVfGy+w== X-Received: by 2002:a63:78a:: with SMTP id 132mr36937172pgh.196.1553842185715; Thu, 28 Mar 2019 23:49:45 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id i5sm1602818pfd.16.2019.03.28.23.49.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Mar 2019 23:49:44 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Subject: [PATCH v3 8/9] ARM: dts: imx51: Specify IMX5_CLK_IPG as "ahb" clock to SDMA Date: Thu, 28 Mar 2019 23:49:23 -0700 Message-Id: <20190329064924.8728-8-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190329064924.8728-1-andrew.smirnov@gmail.com> References: <20190329064924.8728-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_234947_695115_0C4F99E6 X-CRM114-Status: GOOD ( 13.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Angus Ainslie , linux-kernel@vger.kernel.org, Chris Healy , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lucas Stach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" clock to determine if it needs to configure the IP block as operating at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both clocks as IMX5_CLK_SDMA results in driver incorrectly thinking that ratio is 1:1 which results in broken SDMA funtionality. Fix the code to specify IMX5_CLK_AHB as "ahb" clock for SDMA, to avoid detecting incorrect clock ratio. Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Signed-off-by: Andrey Smirnov Cc: Angus Ainslie (Purism) Cc: Chris Healy Cc: Lucas Stach Cc: Fabio Estevam Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/imx51.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi index 0b28b68a17bb..e3fa3d213cd8 100644 --- a/arch/arm/boot/dts/imx51.dtsi +++ b/arch/arm/boot/dts/imx51.dtsi @@ -502,7 +502,7 @@ reg = <0x83fb0000 0x4000>; interrupts = <6>; clocks = <&clks IMX5_CLK_SDMA_GATE>, - <&clks IMX5_CLK_SDMA_GATE>; + <&clks IMX5_CLK_AHB>; clock-names = "ipg", "ahb"; #dma-cells = <3>; fsl,sdma-ram-script-name = "imx/sdma/sdma-imx51.bin"; -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel