All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Si-Wei Liu <si-wei.liu@oracle.com>
Cc: jiri@resnulli.us, mst@redhat.com, kubakici@wp.pl,
	sridhar.samudrala@intel.com, alexander.duyck@gmail.com,
	virtualization@lists.linux-foundation.org, liran.alon@oracle.com,
	netdev@vger.kernel.org, boris.ostrovsky@oracle.com,
	davem@davemloft.net
Subject: Re: [PATCH net v4] failover: allow name change on IFF_UP slave interfaces
Date: Fri, 29 Mar 2019 08:15:12 -0700	[thread overview]
Message-ID: <20190329081512.2f231508__40028.7453363248$1553872540$gmane$org@shemminger-XPS-13-9360> (raw)
In-Reply-To: <1553816847-28121-1-git-send-email-si-wei.liu@oracle.com>

On Thu, 28 Mar 2019 19:47:27 -0400
Si-Wei Liu <si-wei.liu@oracle.com> wrote:

> +	if (unlikely(dev->flags & IFF_UP)) {
> +		struct netdev_notifier_change_info change_info;
> +
> +		change_info.flags_changed = 0;

Simpler to use structure initialization, which also avoid any chance
of unititialized fields.

		struct netdev_notifier_change_info change_info
			= { .flags_changed =  0 };

      parent reply	other threads:[~2019-03-29 15:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-28 23:47 [PATCH net v4] failover: allow name change on IFF_UP slave interfaces Si-Wei Liu
2019-03-29  5:55 ` Samudrala, Sridhar
2019-03-29  5:55   ` Samudrala, Sridhar
2019-03-29 19:50   ` si-wei liu
2019-03-29 22:31     ` Michael S. Tsirkin
2019-03-29 22:58       ` si-wei liu
2019-03-29 22:31     ` Michael S. Tsirkin
2019-03-29 13:45 ` kbuild test robot
2019-03-29 13:45 ` kbuild test robot
2019-03-29 15:15 ` Stephen Hemminger
2019-03-29 15:34   ` Jiri Pirko
2019-03-29 15:34   ` Jiri Pirko
2019-03-29 20:01     ` si-wei liu
2019-03-29 15:15 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20190329081512.2f231508__40028.7453363248$1553872540$gmane$org@shemminger-XPS-13-9360' \
    --to=stephen@networkplumber.org \
    --cc=alexander.duyck@gmail.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=davem@davemloft.net \
    --cc=jiri@resnulli.us \
    --cc=kubakici@wp.pl \
    --cc=liran.alon@oracle.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=si-wei.liu@oracle.com \
    --cc=sridhar.samudrala@intel.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.