All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eugeniu Rosca <erosca@de.adit-jv.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 3/7] common: Implement A/B metadata
Date: Fri, 29 Mar 2019 09:36:37 +0100	[thread overview]
Message-ID: <20190329083616.GA11026@vmlxhi-102.adit-jv.com> (raw)
In-Reply-To: <20190328195848.GP18421@bill-the-cat>

Hello,

On Thu, Mar 28, 2019 at 03:58:48PM -0400, Tom Rini wrote:
> On Thu, Mar 28, 2019 at 05:30:30PM +0100, Eugeniu Rosca wrote:
> > Hello Igor, All,
> > 
> > On Thu, Mar 21, 2019 at 05:39:36PM +0200, Igor Opaniuk wrote:
> > > Hi Eugeniu,
> > > 
> > > On Fri, Mar 8, 2019 at 7:29 PM Eugeniu Rosca <roscaeugeniu@gmail.com> wrote:
> > [..]
> > > >
> > > > The s/uint8_t/u8/ and s/uint32_t/u32/ conversion creates noise
> > > > comparing the in-tree versus out-of-tree files and will add some
> > > > overhead during integration. I still see a lot of U-Boot code saying
> > > > uint8_t/uint32_t, so I wonder if these can be preserved. BTW, some of
> > > > the patches from this series add code using uint32_t.
> > > 
> > > Agree.
> > 
> > Igor, many thanks for the recent replies.
> > 
> > WRT preserving the contents of the original bootloader_message.h from
> > https://android.googlesource.com/platform/bootable/recovery.git/ , I
> > wonder what's the chance of keeping the CPP comments in place when
> > importing the file in-tree, since it will make the diffs and subsequent
> > integration/updates easier from the source repository. Furthermore, we
> > don't expect any U-Boot specific development to be done in this file
> > in-tree. It should purely reflect the upstream state.
> > 
> > I wonder if there is any official position regarding that from the
> > U-Boot maintainers?
> 
> Yes, for stuff that we're importing from another place, and really
> really aren't touching otherwise, we should avoid changing it.

Tom, thanks for your prompt feedback.

Igor, unless you have any objections/comments, would you kindly leave
the CPP comments in the next revision of "bootloader_message.h", so
that we minimize the future integration/back-porting efforts?

I would also re-iterate on the need to import the header file in a
standalone commit, since certain users need it for implementing
A/B-unrelated use-cases/features (e.g. accessing A/B-unrelated
fields of the BCB, like boot reason [1]).

[1] https://source.android.com/devices/bootloader/boot-reason

Best regards,
Eugeniu.

  reply	other threads:[~2019-03-29  8:36 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-18 16:21 [U-Boot] [PATCH v3 0/7] android: implement A/B boot process Igor Opaniuk
2019-02-18 16:21 ` [U-Boot] [PATCH v3 1/7] cmd: part: Add 'number' sub-command Igor Opaniuk
2019-03-10 22:41   ` Eugeniu Rosca
2019-03-21 15:42     ` Igor Opaniuk
2019-05-20 13:27       ` Igor Opaniuk
2019-05-20 14:12         ` Roman Stratiienko
2019-02-18 16:21 ` [U-Boot] [PATCH v3 2/7] disk: part: Extend API to get partition info Igor Opaniuk
2019-02-18 16:21 ` [U-Boot] [PATCH v3 3/7] common: Implement A/B metadata Igor Opaniuk
2019-03-08 17:28   ` Eugeniu Rosca
2019-03-21 15:39     ` Igor Opaniuk
2019-03-28 16:30       ` Eugeniu Rosca
2019-03-28 19:58         ` Tom Rini
2019-03-29  8:36           ` Eugeniu Rosca [this message]
2019-03-10 21:50   ` Simon Glass
2019-03-11 17:27   ` Eugeniu Rosca
2019-03-18 18:04     ` Eugeniu Rosca
2019-03-18 20:21       ` Eugeniu Rosca
2019-03-18 21:20         ` Bajjuri, Praneeth
2019-03-19 10:13           ` Eugeniu Rosca
2019-02-18 16:21 ` [U-Boot] [PATCH v3 4/7] cmd: Add 'ab_select' command Igor Opaniuk
2019-03-10 21:50   ` Simon Glass
2019-02-18 16:21 ` [U-Boot] [PATCH v3 5/7] test/py: Add base test case for A/B updates Igor Opaniuk
2019-02-18 16:21 ` [U-Boot] [PATCH v3 6/7] doc: android: Add simple guide " Igor Opaniuk
2019-02-18 16:21 ` [U-Boot] [PATCH v3 7/7] env: am57xx: Implement A/B boot process Igor Opaniuk
2019-03-10 21:50   ` Simon Glass
2019-02-28 10:28 ` [U-Boot] [PATCH v3 0/7] android: implement " Sam Protsenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190329083616.GA11026@vmlxhi-102.adit-jv.com \
    --to=erosca@de.adit-jv.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.