From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/6] drm/i915: Don't use split gamma when we don't have to Date: Fri, 29 Mar 2019 15:49:26 +0200 Message-ID: <20190329134926.GZ3888@intel.com> References: <20190328210505.10429-1-ville.syrjala@linux.intel.com> <20190328210505.10429-3-ville.syrjala@linux.intel.com> <20190329001603.GW4773@mdroper-desk.amr.corp.intel.com> <20190329104702.GU3888@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 65A7E89781 for ; Fri, 29 Mar 2019 13:49:30 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190329104702.GU3888@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBNYXIgMjksIDIwMTkgYXQgMTI6NDc6MDJQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFRodSwgTWFyIDI4LCAyMDE5IGF0IDA1OjE2OjAzUE0gLTA3MDAsIE1hdHQg Um9wZXIgd3JvdGU6Cj4gPiBPbiBUaHUsIE1hciAyOCwgMjAxOSBhdCAxMTowNTowMVBNICswMjAw LCBWaWxsZSBTeXJqYWxhIHdyb3RlOgo+ID4gPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxl LnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gPiAKPiA+ID4gVXNpbmcgdGhlIHNwbGl0IGdh bW1hIG1vZGUgd2hlbiB3ZSBkb24ndCBoYXZlIHRvIGhhcyB0aGUgYW5ub3lpbmcKPiA+ID4gcmVx dWlyZW1lbnQgb2YgbG9hZGluZyBhIGxpbmVhciBMVVQgdG8gdGhlIHVudXNlZCBoYWxmLiBJbnN0 ZWFkCj4gPiA+IGxldCdzIG1ha2UgbGlmZSBzaW1wbGVyIGJ5IHN3aXRjaGluZyB0byB0aGUgMTBi aXQgZ2FtbWEgbW9kZQo+ID4gPiBhbmQgZHVwbGljYXRpbmcgZWFjaCBlbnRyeS4KPiA+ID4gCj4g PiA+IFRoaXMgYWxzbyBhbGxvd3MgdXMgdG8gbG9hZCB0aGUgc29mdHdhcmUgZ2FtbWEgTFVUIGlu dG8gdGhlCj4gPiA+IGhhcmR3YXJlIGRlZ2FtbWEgTFVULCB0aHVzIHJlbW92aW5nIHNvbWUgb2Yg dGhlIGJ1Z2d5Cj4gPiA+IGNvbmZpZ3VyYXRpb25zIHdlIGN1cnJlbnRseSBhbGxvdyAoWUNiQ3Iv bGltaXRlZCByYW5nZSBSR0IKPiA+ID4gKyBnYW1tYSBMVVQpLiBXZSBkbyBzdGlsbCBoYXZlIG90 aGVyIGNvbmZpZ3VyYXRpb25zIHRoYXQgYXJlCj4gPiA+IGFsc28gYnVnZ3ksIGJ1dCB0aG9zZSB3 aWxsIG5lZWQgbW9yZSBjb21wbGljYXRlZCBmaXhlcwo+ID4gPiBvciB0aGV5IGp1c3QgbmVlZCB0 byBiZSByZWplY3RlZC4gU2FkbHkgR0xLIGRvZXNuJ3QgaGF2ZQo+ID4gPiB0aGlzIGZsZXhpYmls aXR5IGFueW1vcmUgYW5kIHRoZSBkZWdhbW1hIGFuZCBnYW1tYSBMVVRzCj4gPiA+IGFyZSB2ZXJ5 IGRpZmZlcmVudCBzbyBubyBoZWxwIHRoZXJlLgo+ID4gPiAKPiA+ID4gU2lnbmVkLW9mZi1ieTog VmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+ID4gLS0t Cj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oICAgIHwgICAxICsKPiA+ID4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbG9yLmMgfCAxNTkgKysrKysrKysrKysrKysr LS0tLS0tLS0tLS0tLS0KPiA+ID4gIDIgZmlsZXMgY2hhbmdlZCwgODYgaW5zZXJ0aW9ucygrKSwg NzQgZGVsZXRpb25zKC0pCj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9yZWcuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiA+ID4g aW5kZXggYzg2NjM3OWE1MjFiLi5lYjdlOTMzNTRjZmUgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9yZWcuaAo+ID4gPiBAQCAtMTAxMjcsNiArMTAxMjcsNyBAQCBlbnVtIHNrbF9wb3dl cl9nYXRlIHsKPiA+ID4gICNkZWZpbmUgICBQQUxfUFJFQ19TUExJVF9NT0RFCQkoMSA8PCAzMSkK PiA+ID4gICNkZWZpbmUgICBQQUxfUFJFQ19BVVRPX0lOQ1JFTUVOVAkoMSA8PCAxNSkKPiA+ID4g ICNkZWZpbmUgICBQQUxfUFJFQ19JTkRFWF9WQUxVRV9NQVNLCSgweDNmZiA8PCAwKQo+ID4gPiAr I2RlZmluZSAgIFBBTF9QUkVDX0lOREVYX1ZBTFVFKHgpCSgoeCkgPDwgMCkKPiA+ID4gICNkZWZp bmUgX1BBTF9QUkVDX0RBVEFfQQkweDRBNDA0Cj4gPiA+ICAjZGVmaW5lIF9QQUxfUFJFQ19EQVRB X0IJMHg0QUMwNAo+ID4gPiAgI2RlZmluZSBfUEFMX1BSRUNfREFUQV9DCTB4NEI0MDQKPiA+ID4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbG9yLmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jCj4gPiA+IGluZGV4IGQ3YzM4YTJiYmQ4Zi4uZWQ0 YmQ5YmQxNWY1IDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9j b2xvci5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbG9yLmMKPiA+ ID4gQEAgLTQ2Niw3MiArNDY2LDMyIEBAIHN0YXRpYyB2b2lkIHNrbF9jb2xvcl9jb21taXQoY29u c3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gPiA+ICAJCWlsa19sb2Fk X2NzY19tYXRyaXgoY3J0Y19zdGF0ZSk7Cj4gPiA+ICB9Cj4gPiA+ICAKPiA+ID4gLXN0YXRpYyB2 b2lkIGJkd19sb2FkX2RlZ2FtbWFfbHV0KGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpj cnRjX3N0YXRlKQo+ID4gPiArc3RhdGljIHZvaWQgYmR3X2xvYWRfbHV0XzEwKHN0cnVjdCBpbnRl bF9jcnRjICpjcnRjLAo+ID4gPiArCQkJICAgIGNvbnN0IHN0cnVjdCBkcm1fcHJvcGVydHlfYmxv YiAqYmxvYiwKPiA+ID4gKwkJCSAgICB1MzIgcHJlY19pbmRleCwgYm9vbCBkdXBsaWNhdGUpCj4g PiA+ICB7Cj4gPiA+IC0Jc3RydWN0IGludGVsX2NydGMgKmNydGMgPSB0b19pbnRlbF9jcnRjKGNy dGNfc3RhdGUtPmJhc2UuY3J0Yyk7Cj4gPiA+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2ID0gdG9faTkxNShjcnRjLT5iYXNlLmRldik7Cj4gPiA+IC0JY29uc3Qgc3RydWN0IGRy bV9wcm9wZXJ0eV9ibG9iICpkZWdhbW1hX2x1dCA9IGNydGNfc3RhdGUtPmJhc2UuZGVnYW1tYV9s dXQ7Cj4gPiA+IC0JdTMyIGksIGx1dF9zaXplID0gSU5URUxfSU5GTyhkZXZfcHJpdiktPmNvbG9y LmRlZ2FtbWFfbHV0X3NpemU7Cj4gPiA+ICsJY29uc3Qgc3RydWN0IGRybV9jb2xvcl9sdXQgKmx1 dCA9IGJsb2ItPmRhdGE7Cj4gPiA+ICsJaW50IGksIGx1dF9zaXplID0gZHJtX2NvbG9yX2x1dF9z aXplKGJsb2IpOwo+ID4gPiAgCWVudW0gcGlwZSBwaXBlID0gY3J0Yy0+cGlwZTsKPiA+ID4gIAo+ ID4gPiAtCUk5MTVfV1JJVEUoUFJFQ19QQUxfSU5ERVgocGlwZSksCj4gPiA+IC0JCSAgIFBBTF9Q UkVDX1NQTElUX01PREUgfCBQQUxfUFJFQ19BVVRPX0lOQ1JFTUVOVCk7Cj4gPiA+IC0KPiA+ID4g LQlpZiAoZGVnYW1tYV9sdXQpIHsKPiA+ID4gLQkJY29uc3Qgc3RydWN0IGRybV9jb2xvcl9sdXQg Kmx1dCA9IGRlZ2FtbWFfbHV0LT5kYXRhOwo+ID4gPiArCUk5MTVfV1JJVEUoUFJFQ19QQUxfSU5E RVgocGlwZSksIHByZWNfaW5kZXggfAo+ID4gPiArCQkgICBQQUxfUFJFQ19BVVRPX0lOQ1JFTUVO VCk7Cj4gPiA+ICAKPiA+ID4gLQkJZm9yIChpID0gMDsgaSA8IGx1dF9zaXplOyBpKyspCj4gPiA+ IC0JCQlJOTE1X1dSSVRFKFBSRUNfUEFMX0RBVEEocGlwZSksIGlsa19sdXRfMTAoJmx1dFtpXSkp Owo+ID4gPiAtCX0gZWxzZSB7Cj4gPiA+ICsJLyoKPiA+ID4gKwkgKiBXZSBhZHZlcnRpemUgdGhl IHNwbGl0IGdhbW1hIHNpemVzLiBXaGVuIG5vdCB1c2luZyBzcGxpdAo+ID4gPiArCSAqIGdhbW1h IHdlIGp1c3QgZHVwbGljYXRlIGVhY2ggZW50cnkuCj4gPiA+ICsJICoKPiA+ID4gKwkgKiBUT0RP OiBleHBvc2UgdGhlIGZ1bGwgTFVUIHRvIHVzZXJzcGFjZQo+ID4gCj4gPiBBbnkgcmVhc29uIG5v dCB0byBqdXN0IGRvIHRoaXMgaW1tZWRpYXRlbHk/ICBUaHJvd2luZyBhd2F5IGhhbGYgdGhlCj4g PiB0YWJsZSBlbnRyaWVzIGlmIHdlIGRlY2lkZSB3ZSBuZWVkIHNwbGl0IG1vZGUgZG9lc24ndCBz ZWVtIGFueSBoYXJkZXIKPiA+IHRoYW4gZHVwbGljYXRpbmcgdGhlIGVudHJpZXMgd2hlbiB3ZSBk ZWNpZGUgd2UgZG9uJ3QuICBUaGUgY29sb3IKPiA+IG1hbmFnZW1lbnQga2VybmVsZG9jIGFscmVh ZHkgZXhwbGljaXRseSByZWNvbW1lbmRzIHRoaXMgYXBwcm9hY2ggZm9yCj4gPiBoYXJkd2FyZSB0 aGF0IGNhbiBzdXBwb3J0IG11bHRpcGxlIGdhbW1hIG1vZGVzLCBzbyBJIGRvbid0IHRoaW5rIHdl IG5lZWQKPiA+IGFueSBuZXcgQUJJIHRvIGhhbmRsZSBpdC4KPiAKPiBIbW0uIEkgZ3Vlc3MgdGhh dCBhcHBvcmFjaCBjb3VsZCBiZSBkb2FibGUuIEl0IG1pZ2h0IGJlIGEgYml0IGFubm95aW5nCj4g Zm9yIHVzZXJzcGFjZSB0aG91Z2ggaWYgaXQgZXhwZWN0cyBhIGRpcmVjdCBjb2xvciB2aXN1YWwu IEJ1dCBhdCBsZWFzdAo+IGZvciBYIHdlIHdvbid0IHVzZSBkZWdhbW1hL2N0bSBhbnl3YXkgc28g c2VlbXMgbGlrZSBpdCBzaG91bGQgd29yayBvdXQKPiBqdXN0IGZpbmUuCgpBcyB1c3VhbCB0aGlz IG5lZWRzIGEgYml0IG9mIGNhcmUgd2hlbiBwaWNraW5nIHRoZSBMVVQgZW50cmllcyB3ZQp1c2Uu IEkgdGhpbmsgSSdsbCBzZW5kIHRoYXQgYXMgYSBmb2xsb3d1cC4KCi0tIApWaWxsZSBTeXJqw6Rs w6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4