From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FD5BC43381 for ; Fri, 29 Mar 2019 15:34:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1E9D20693 for ; Fri, 29 Mar 2019 15:34:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="O9cxJLBw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729446AbfC2Pe0 (ORCPT ); Fri, 29 Mar 2019 11:34:26 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:35116 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728924AbfC2Pe0 (ORCPT ); Fri, 29 Mar 2019 11:34:26 -0400 Received: by mail-wr1-f67.google.com with SMTP id w1so3143020wrp.2 for ; Fri, 29 Mar 2019 08:34:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LT6zb4JS+E9Th6gQxNAgGLIqs2LdBPf+XbtM/9N+8B8=; b=O9cxJLBwaebh5AkqsslZ9Isgl9fEdcusgJx3syxKFi1wzZMCRBESVvOgXdSjwyen6/ Zaxtl0wliWLkeLee24oZ0hmnoCFBw4NyBVQzjjK7SMRL6uN6eWyuda7U8d2PNCOzt/vm 6Sut3D9EvkA81fCgj45BS9iblLvjuiAcbMPG+75GqyzFuiINyxyc/xUwOk/Vbrpi8mNo rILmqbkN9Et/6BV/V8YtDRYcCG4VapyEfWD9SHLAZkWTeZUwJvfZkT2tY6g0YZmi8X/G vyJb9CdlEuM9oD4kbz8I7b/wxAwuABZ5Eu2sXGTXPQpGTFMO6/L7XW/2QRfbT+vIO5eM 88cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LT6zb4JS+E9Th6gQxNAgGLIqs2LdBPf+XbtM/9N+8B8=; b=XeuD98I3lA1/gxiVZzqzDrc4mTI274ScWZ4fOQxo0HQ5lI1ezwBXwOfkUBAJVSz2cy 41X+WVvmmyXw5LqLvJ7eeVJw0N4dDoTPz8YZ1Cnt76OZj0GXnMCPMkSYdFKszGwqYLti f8/7GjCEBZJhewdcttNpyQZiez9/ALjK/wZRC+y3yYNnjOWFZyX1EqtDnJ1BNj2dZDtN 8543MOraz7WF9tWnbdM6DniFuvkltHQXocTJaIaJfIJKfOAovDutL5mjUpJq1AN73Qwk /ELUH84mO5jwzMBtKxBRwzfQ4MyxqhsYybKF52Yj0KSIdFtqI0YTmEIt8fGpxgQXYpXa RwfA== X-Gm-Message-State: APjAAAWiPmtideWbD9BpTJaMIr0RlR9SqmcvcZ+qcyLP4i4LHKWGtTG1 xvWdevubMH0ghXNN+aQfxCByyA== X-Google-Smtp-Source: APXvYqy6mAwE8wgg7bxrD2RQ1VlKanp30ksFOwn92tVp36k1KyP5ISAyHpxX2r4Ynkb45cuaieAKsA== X-Received: by 2002:adf:ef91:: with SMTP id d17mr33204699wro.78.1553873664919; Fri, 29 Mar 2019 08:34:24 -0700 (PDT) Received: from localhost (ip-94-113-223-73.net.upcbroadband.cz. [94.113.223.73]) by smtp.gmail.com with ESMTPSA id z8sm2518963wrh.80.2019.03.29.08.34.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 Mar 2019 08:34:24 -0700 (PDT) Date: Fri, 29 Mar 2019 16:34:23 +0100 From: Jiri Pirko To: Stephen Hemminger Cc: Si-Wei Liu , mst@redhat.com, sridhar.samudrala@intel.com, davem@davemloft.net, kubakici@wp.pl, alexander.duyck@gmail.com, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, liran.alon@oracle.com, boris.ostrovsky@oracle.com, vijay.balakrishna@oracle.com Subject: Re: [PATCH net v4] failover: allow name change on IFF_UP slave interfaces Message-ID: <20190329153423.GZ14297@nanopsycho> References: <1553816847-28121-1-git-send-email-si-wei.liu@oracle.com> <20190329081512.2f231508@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190329081512.2f231508@shemminger-XPS-13-9360> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fri, Mar 29, 2019 at 04:15:12PM CET, stephen@networkplumber.org wrote: >On Thu, 28 Mar 2019 19:47:27 -0400 >Si-Wei Liu wrote: > >> + if (unlikely(dev->flags & IFF_UP)) { >> + struct netdev_notifier_change_info change_info; >> + >> + change_info.flags_changed = 0; > >Simpler to use structure initialization, which also avoid any chance >of unititialized fields. > > struct netdev_notifier_change_info change_info > = { .flags_changed = 0 }; In fact, you can do just: struct netdev_notifier_change_info change_info = {}; to achieve the same.