From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3F15C43381 for ; Fri, 29 Mar 2019 19:46:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 67A222184C for ; Fri, 29 Mar 2019 19:46:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="p8hUKizW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730071AbfC2TqX (ORCPT ); Fri, 29 Mar 2019 15:46:23 -0400 Received: from mail-qk1-f201.google.com ([209.85.222.201]:43998 "EHLO mail-qk1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729766AbfC2TqW (ORCPT ); Fri, 29 Mar 2019 15:46:22 -0400 Received: by mail-qk1-f201.google.com with SMTP id m8so2772363qka.10 for ; Fri, 29 Mar 2019 12:46:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=BUBHmun+6919HJl9SDixKlmvfWQdVn2SOTJUQLPp/RY=; b=p8hUKizWWbSHHAy1fgihULzZiPVyBOeB4GfAPmnyazp8ioDS5jEEAr5sBsoh6RUEZC 7vmazG5iYjXLMu1MJR1NhCZbSHhHGMs43/7bQr5tZinyKDu2IWXlXfS5BXCR4f3m1SAU OW1+ggn6f6bVOJivVuq7cY5s1LUTnatSoJPKg8vxz3Oc+X2bjFfzhGJnd+5DhDMbUiPw REvSsGoFL5U7L+axDmA+EWGj5a0Hvo8/HQ38ADbXYADy7nntnlTvH/SK3h2XZNknNacQ OXPwhv1gVUi7Ssq41eEcDVQv+I+aaPLQGVCvKxJjkAasUbkTxXUiFXIRA3MsuC1DzVeW QmwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=BUBHmun+6919HJl9SDixKlmvfWQdVn2SOTJUQLPp/RY=; b=HOkxTNSNjOQd0FMJGsqFDqk9ZZUaGcohN2xotiHPngaZRz/t7qmhYhqQl3ZEEiN6T4 JePSvJ3vMjbSug8hI9VNJU5XVEPNzWxHgugqWFMS/gFKyNrfynmVKzeQKhfkpAtqIEGG Hy9YrLYTLhxF9nApS8EFmdRlKOGhuSL6ovo1L/PzyVaEJ2b7Fot5zi7DQPHzJF+wcXWo n9/9x060UbUAQ3K1vXqMunnD9Bqmrnho9XlCrjk13yNY+NNJ6MY5fMXKNg1sCDP7Dwyh vBTi5BEfHOt77Lupr4LFq1U1wUtlpSV3DPnStOM3W+9G3WiqPrCDa44vCAzF1AE7e3zH s6AQ== X-Gm-Message-State: APjAAAUtPiIeBP0s12dSjPzspxtO4WLwZpYdlWBdMj/NUz0JBKIPG+fT EjwbRRkkaepie2CaJvWPVW+XKs5ITe6LSg== X-Google-Smtp-Source: APXvYqw6o8oFbDVvNWEPfzaONo5R7lYK0VCdf4X3UZCa7MEMd//4slFrHVWrV2xCXsUjZQ6p8Ty43aq5kc61Rg== X-Received: by 2002:a37:6442:: with SMTP id y63mr3425840qkb.12.1553888781694; Fri, 29 Mar 2019 12:46:21 -0700 (PDT) Date: Fri, 29 Mar 2019 12:46:17 -0700 Message-Id: <20190329194617.195528-1-edumazet@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.21.0.392.gf8f6787159e-goog Subject: [PATCH net-next] tcp: cleanup sk_tx_skb_cache before reuse From: Eric Dumazet To: "David S . Miller" Cc: netdev , Eric Dumazet , Eric Dumazet , Soheil Hassas Yeganeh , Willem de Bruijn Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org TCP stack relies on the fact that a freshly allocated skb has skb->cb[] and skb_shinfo(skb)->tx_flags cleared. When recycling tx skb, we must ensure these fields are cleared. Fixes: 472c2e07eef0 ("tcp: add one skb cache for tx") Signed-off-by: Eric Dumazet Cc: Soheil Hassas Yeganeh Cc: Willem de Bruijn --- net/ipv4/tcp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index 82bd707c03472f2cebb1a90d5f1c13acc821468f..603e770d59b3db96adca9602319d2f6970a56285 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -872,6 +872,8 @@ struct sk_buff *sk_stream_alloc_skb(struct sock *sk, int size, gfp_t gfp, sk->sk_tx_skb_cache = NULL; pskb_trim(skb, 0); INIT_LIST_HEAD(&skb->tcp_tsorted_anchor); + skb_shinfo(skb)->tx_flags = 0; + memset(TCP_SKB_CB(skb), 0, sizeof(struct tcp_skb_cb)); return skb; } } -- 2.21.0.392.gf8f6787159e-goog