From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A18BC43381 for ; Sat, 30 Mar 2019 05:47:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E727218AC for ; Sat, 30 Mar 2019 05:47:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553924836; bh=CuANC5Javzn9dZRQkD8MQw7sWd/zE17vkS7KuDwKiq4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=i9kvkhMRglNwRDYjeRtu2HwQMWyS0GIW311WKz4ooH9gsVag914kLJ2Qeo9Td3ZQ+ XXouuDdz261OlvzJk0pXJTKkVv58OeWjWCBHs4mLJ0lP7eVjqg4RSDIuPPI+P8KkLH AkXgDSVkEARhJC2NIlkg8GSac0wREhPVJyEi3QTo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726597AbfC3FrQ (ORCPT ); Sat, 30 Mar 2019 01:47:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:40504 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726450AbfC3FrP (ORCPT ); Sat, 30 Mar 2019 01:47:15 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 867A9218A3; Sat, 30 Mar 2019 05:47:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553924835; bh=CuANC5Javzn9dZRQkD8MQw7sWd/zE17vkS7KuDwKiq4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Un1d+8YXv6XpYQ1ynxXTqVbA9GzOaLS6irJlLhRabq+TaQmOatdLqb4Gk9MdJTHvP 1Xkm2SA95G4WIFaEt5lBOj8TwATDgMVZfjt8ZM6sHNbUS1WiqlOKOTrBw1BXo59k5z 0xV5+8vJWL8/5AbC9ltaZwEKuw3yfqQJbxiGeQQw= Date: Sat, 30 Mar 2019 06:47:12 +0100 From: Greg KH To: Janusz Krzysztofik Cc: Sasha Levin , Hans Verkuil , stable@vger.kernel.org Subject: Re: [BACKPORT v3.18] media: ov6650: Fix sensor possibly not detected on probe Message-ID: <20190330054712.GC23655@kroah.com> References: <20190329212005.6501-1-jmkrzyszt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190329212005.6501-1-jmkrzyszt@gmail.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Mar 29, 2019 at 10:20:05PM +0100, Janusz Krzysztofik wrote: > After removal of clock_start() from before soc_camera_init_i2c() in > soc_camera_probe() by commit 9aea470b399d ("[media] soc-camera: switch > I2C subdevice drivers to use v4l2-clk") introduced in v3.11, the ov6650 > driver could no longer probe the sensor successfully because its clock > was no longer turned on in advance. The issue was initially worked > around by adding that missing clock_start() equivalent to OMAP1 camera > interface driver - the only user of this sensor - but a propoer fix > should be rather implemented in the sensor driver code itself. > > Fix the issue by inserting a delay between the clock is turned on and > the sensor I2C registers are read for the first time. > > Fixes: 9aea470b399d ("[media] soc-camera: switch I2C subdevice drivers to use v4l2-clk") > Signed-off-by: Janusz Krzysztofik > Cc: stable@vger.kernel.org > --- > Rebased on 3.18, should apply cleanly on 4.4 and 4.9 as well. > > I dropped the comment on the patch being tested on an out of tree > omap1_camera driver mainly because that driver is still in the tree > in those kernel versions. > > drivers/media/i2c/soc_camera/ov6650.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/i2c/soc_camera/ov6650.c b/drivers/media/i2c/soc_camera/ov6650.c > index ab01598ec83f..c0e25bf55fb8 100644 > --- a/drivers/media/i2c/soc_camera/ov6650.c > +++ b/drivers/media/i2c/soc_camera/ov6650.c > @@ -829,6 +829,8 @@ static int ov6650_video_probe(struct i2c_client *client) > if (ret < 0) > return ret; > > + msleep(20); > + > /* > * check and show product ID and manufacturer ID > */ > -- > 2.19.2 > What is the git commit id of this patch in Linus's tree? thanks, greg k-h