From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9C51C43381 for ; Sat, 30 Mar 2019 15:51:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A08020643 for ; Sat, 30 Mar 2019 15:51:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cuRaK14x"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LVhoMpBJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A08020643 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=NdFTR47FfnX3DS0bXBy41aEj/aswwZ0jD24S0mf7d7I=; b=cuR aK14xXH5Sb/LJMEUYx/1r94L/ZE2KSkiFvkZchoo/F5+LT7AChVUKMXCjgg+rLRmYeWvNj+6JGGBP gDVjN67bm0G52GRvaEjlbJWXnKHWfpiKEOoVg58LepOONxv2E2frFI9A6wXK5s87ZKMXCqme/CFt4 ln+QM8hnWPvw6kn+jtLuGLGgAMVycuD34n5rPfMds2mKzuCAJtDx+oTiNzwhSG25MX8amZRrufHIS kawZjb+cGwHqoUqXtKVh4sMjGrcsyzehduZ76Ii3JRxshBL2BaEQ5ShUJe/VjS4Dlc4UFi+1aYDUO gHllo/hdc+3f6Q53vclwaE2P8g7PS5Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAGGJ-0003o7-Tw; Sat, 30 Mar 2019 15:51:15 +0000 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAGGG-0003nn-LR for linux-arm-kernel@lists.infradead.org; Sat, 30 Mar 2019 15:51:14 +0000 Received: by mail-qk1-x744.google.com with SMTP id c20so3162547qkc.10 for ; Sat, 30 Mar 2019 08:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=d6GbLqIvfsB3oQD/Ndaw+lGNtmEU6M0D2tNKK7/AoDQ=; b=LVhoMpBJuAr4AJX0Kqi1sTpy056Aa7fUkSZmgGy/Yo+4GyPZJ0PbgtqJLFLg0qch0k LFJeaw2f5W9rkxMHdmG2NqZtW6AM5JebesLsnDZttmhR3c59kBEqI9/p8zZOIbY99wti cAIgBUkl6r5eSp1DMiTlkgbM0a9J7/JrxTOYcdS3q8jtXPXrrVZx+JgwY+Pxb96gp5Xp HTW9BXuO4hNVljf8kHhxAtVdEAeq/v67QC1heX1wTIHdXXoK/8kZMZliBAxoGABJKiF0 Jy2JsZcEOb0eCksGvd2JABVMcxShYeaiZP7SKy380VOX+DNWSuusROwIb7rBsORNOWqx C06Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=d6GbLqIvfsB3oQD/Ndaw+lGNtmEU6M0D2tNKK7/AoDQ=; b=bQSGIihCf5XLmVoNu4PxP71Q4m8hPfmUucnbGvfxQXcHNvU3ofMLka6IzbXTzcnrEh DIzyeTaIapekx8ARBU91umkwfBOwyIVTRc6MlfQNDd1lOUNqystVu/OhXhfSH2Qa/05I emdnfIIECEKmccNCoY95lioja/tjsZ2Iwp6X59T/pqSvQvXgnPaGmElEX7Y+cauieNep akKEMP6UsYxkWg13DQl45iKAY6myHlRZ6BWiQAFmACIytWgRfhLn3rgKK4Kd1ERlgjYH f9rm2/Dia6OJL9yIH7Q5XVr0VpiUHvnBxaMhO69N0JN+5mdmc0EJO6z1/OqjdtnK87LA jxXg== X-Gm-Message-State: APjAAAXAzY90POGck7DHmqP1jj3AyIM4l4Fj4hwinS6ZJRkfs/ps6Uls 6GuaXa7R6YtBtfJC1Xv6W0c= X-Google-Smtp-Source: APXvYqzj2KiOCEoyld7pQFzw+nTCuHDxpQ8ks4dJFQYdc6ezf+tbj2owImFJK3DgAFBRpXSGmRu3jQ== X-Received: by 2002:a37:5905:: with SMTP id n5mr20577720qkb.181.1553961071065; Sat, 30 Mar 2019 08:51:11 -0700 (PDT) Received: from fabio-Latitude-E5450.am.freescale.net ([2804:14c:482:3c8::1]) by smtp.gmail.com with ESMTPSA id r20sm3495846qtc.48.2019.03.30.08.51.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 30 Mar 2019 08:51:09 -0700 (PDT) From: Fabio Estevam To: shawnguo@kernel.org Subject: [RFC] ARM: dts: imx: Fix the AR803X phy-mode Date: Sat, 30 Mar 2019 12:50:51 -0300 Message-Id: <20190330155051.9855-1-festevam@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190330_085113_126833_22C771F6 X-CRM114-Status: GOOD ( 13.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, linux@armlinux.org.uk, smoch@web.de, stwiss.opensource@diasemi.com, linux-imx@nxp.com, kernel@pengutronix.de, Fabio Estevam , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode") exposed an issue on imx DTS files using AR8031/AR8035 PHYs. The end result is that the boards can no longer obtain an IP address via UDHCP, for example. Quoting Andrew Lunn: "The problem here is, all the DTs were broken since day 0. However, because the PHY driver was also broken, nobody noticed and it worked. Now that the PHY driver has been fixed, all the bugs in the DTs now become an issue" To fix this problem, the phy-mode property needs to be "rgmii-id", which has the following meaning as per Documentation/devicetree/bindings/net/ethernet.txt: "RGMII with internal RX and TX delays provided by the PHY, the MAC should not add the RX or TX delays in this case)" Tested on imx6-sabresd, imx6sx-sdb and imx7d-pico boards with successfully restored networking. Signed-off-by: Fabio Estevam --- Hi, Marking it as RFC in the hope of getting some feedback as to how to proceed with fixing this regression on 5.1-rc1. It's not possible to know if there are other imx boards in tree that use AR803X, so here is an attempt. mx6-sabresd, imx6sx-sdb and imx7d-pico have been successfully tested. Thanks arch/arm/boot/dts/imx6q-tbs2910.dts | 2 +- arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 2 +- arch/arm/boot/dts/imx6qdl-sr-som.dtsi | 2 +- arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 2 +- arch/arm/boot/dts/imx6sx-sdb.dtsi | 2 +- arch/arm/boot/dts/imx7d-pico.dtsi | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/imx6q-tbs2910.dts b/arch/arm/boot/dts/imx6q-tbs2910.dts index 2ce8399a10ba..bfff87ce2e1f 100644 --- a/arch/arm/boot/dts/imx6q-tbs2910.dts +++ b/arch/arm/boot/dts/imx6q-tbs2910.dts @@ -98,7 +98,7 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi index a0705066ccba..185fb17a3500 100644 --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi @@ -202,7 +202,7 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi b/arch/arm/boot/dts/imx6qdl-sr-som.dtsi index 4ccb7afc4b35..6d7f6b9035bc 100644 --- a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi +++ b/arch/arm/boot/dts/imx6qdl-sr-som.dtsi @@ -53,7 +53,7 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_microsom_enet_ar8035>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-reset-duration = <2>; phy-reset-gpios = <&gpio4 15 GPIO_ACTIVE_LOW>; status = "okay"; diff --git a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi index b7d5fb421404..50d9a989e06a 100644 --- a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi +++ b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi @@ -224,7 +224,7 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-reset-gpios = <&gpio3 29 GPIO_ACTIVE_LOW>; interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; diff --git a/arch/arm/boot/dts/imx6sx-sdb.dtsi b/arch/arm/boot/dts/imx6sx-sdb.dtsi index 08ede56c3f10..f6972deb5e39 100644 --- a/arch/arm/boot/dts/imx6sx-sdb.dtsi +++ b/arch/arm/boot/dts/imx6sx-sdb.dtsi @@ -191,7 +191,7 @@ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet1>; phy-supply = <®_enet_3v3>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-handle = <ðphy1>; phy-reset-gpios = <&gpio2 7 GPIO_ACTIVE_LOW>; status = "okay"; diff --git a/arch/arm/boot/dts/imx7d-pico.dtsi b/arch/arm/boot/dts/imx7d-pico.dtsi index 3fd595a71202..6f50ebf31a0a 100644 --- a/arch/arm/boot/dts/imx7d-pico.dtsi +++ b/arch/arm/boot/dts/imx7d-pico.dtsi @@ -92,7 +92,7 @@ <&clks IMX7D_ENET1_TIME_ROOT_CLK>; assigned-clock-parents = <&clks IMX7D_PLL_ENET_MAIN_100M_CLK>; assigned-clock-rates = <0>, <100000000>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-handle = <ðphy0>; fsl,magic-packet; phy-reset-gpios = <&gpio6 11 GPIO_ACTIVE_LOW>; -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel