From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavan Nikhilesh Bhagavatula Subject: [PATCH] ethdev: fix DMA zone reserve not honoring size Date: Sun, 31 Mar 2019 16:25:04 +0000 Message-ID: <20190331162437.13048-1-pbhagavatula@marvell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , Pavan Nikhilesh Bhagavatula , "stable@dpdk.org" To: Jerin Jacob Kollanukkaran , "thomas@monjalon.net" , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , "stephen@networkplumber.org" Return-path: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Pavan Nikhilesh The `rte_eth_dma_zone_reserve()` is generally used to create HW rings. In some scenarios when a driver needs to reconfigure the ring size since the named memzone already exists it returns the previous memzone without checking if a different sized ring is requested. Introduce a check to see if the ring size requested is different from the previously created memzone length. Fixes: 719dbebceb81 ("xen: allow determining DOM0 at runtime") Cc: stable@dpdk.org Signed-off-by: Pavan Nikhilesh --- lib/librte_ethdev/rte_ethdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.= c index 12b66b68c..4ae12e43b 100644 --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte_ethdev/rte_ethdev.c @@ -3604,9 +3604,12 @@ rte_eth_dma_zone_reserve(const struct rte_eth_dev *d= ev, const char *ring_name, } =20 mz =3D rte_memzone_lookup(z_name); - if (mz) + if (mz && (mz->len =3D=3D size)) return mz; =20 + if (mz) + rte_memzone_free(mz); + return rte_memzone_reserve_aligned(z_name, size, socket_id, RTE_MEMZONE_IOVA_CONTIG, align); } --=20 2.21.0