From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3995CC43381 for ; Sun, 31 Mar 2019 17:16:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F262520882 for ; Sun, 31 Mar 2019 17:16:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UwwJaiVw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731314AbfCaRQX (ORCPT ); Sun, 31 Mar 2019 13:16:23 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:38916 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731237AbfCaRQW (ORCPT ); Sun, 31 Mar 2019 13:16:22 -0400 Received: by mail-wr1-f68.google.com with SMTP id j9so8836406wrn.6; Sun, 31 Mar 2019 10:16:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2UMBM2cl3aL2/0tcntzJoQrX4s/pKpcX133TQvpp/hI=; b=UwwJaiVwcwXsevwpQMnBmx4uhha1L5BWG96xilbiUpD2h+KecFFXO/p/rDn2zKtzvB CIwaD+0DY7yprN+GgnsECqFluSVXxo+/M6P152ZTyyBXRPxFuhYxZv2XHerW0Anb5Z/c pU3/otKP8BXTgQSHtb1KK8lNWX/U4WZt0CorQKvNSHcPCIgnmhhkTJqhSYZ5BR4JbQ1T Gp7bKzVlyAOSAIwH+d/GRccc9VXDLTLQeOO8waPWVdll18ekop9bdvzmlaxH69962l2p a0mMFp4MWYgPw0VJbkfIfDCtZr6dCmDqVI1VTYVQsXd80NH9ZtZuT5Xi938lV7AvnMXH tQ3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2UMBM2cl3aL2/0tcntzJoQrX4s/pKpcX133TQvpp/hI=; b=tO9LQtfyJ2nGCV9atl7U51prhPyXIJLVeA/ccwi6dhWCnQyl47HNEgjB4vhnhXpHY8 Q2zMFb86uZH4kqDAREqzxDQny8Xip7QRyxpf++qJb+8PYM1da4J1Aj5n18fg06g/iJ4l AvNt5tCpWVgXDTIezbzVa5A67LXU9HLFPxx84Re1nI1gia0xHllkkp4l624Wrn1NCpRL Gni5m63jjoD9dGjraSBYKFjqI5YHT6EFa/53h3yY3FrNrpRGTwV0Zz60qPji5fHAHDeU wpErZ+AzQ9GerWxvX4DlETK2KNWUvNiP9FxRCsor+okd2FMI5HYs7OAzxgi+mjzT7PRM Wq0g== X-Gm-Message-State: APjAAAWW16jGKIIqnLv8wfDcfkAajtcJsbKg34JRR6omSbD+Ov/f2HG9 2v9iJr9GcjHNE4VEG5t3qh0= X-Google-Smtp-Source: APXvYqxsz+MfYPkfMf4a+GFiLqQMtZu3UvDwWhKcs3ebK9FuYavFjBr5BIIJStMf+oaEzGeWiMKfhw== X-Received: by 2002:adf:ef8e:: with SMTP id d14mr21620754wro.81.1554052580621; Sun, 31 Mar 2019 10:16:20 -0700 (PDT) Received: from debian (cpc101300-bagu16-2-0-cust362.1-3.cable.virginm.net. [86.21.41.107]) by smtp.gmail.com with ESMTPSA id g84sm10547804wmf.25.2019.03.31.10.16.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 31 Mar 2019 10:16:19 -0700 (PDT) Date: Sun, 31 Mar 2019 18:16:17 +0100 From: Sudip Mukherjee To: Yifeng Li Cc: Teddy Wang , linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 1/7] fbdev: sm712fb: use type "u8" for 8-bit I/O. Message-ID: <20190331171617.ebh7aozv3eleyqzb@debian> References: <20190322051759.15007-1-tomli@tomli.me> <20190322051759.15007-2-tomli@tomli.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190322051759.15007-2-tomli@tomli.me> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 22, 2019 at 01:17:53PM +0800, Yifeng Li wrote: > This commit converts "unsigned int" and "int" in I/O wrappers > to "u8". It improves readability since it's consistent with > the prototypes of readb() and writeb(). More importantly, it > reduces readers' confusion, since the upcoming 2D acceleration > code will use a different wordsize. > > Signed-off-by: Yifeng Li Tested-by: Sudip Mukherjee -- Regards Sudip From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudip Mukherjee Date: Sun, 31 Mar 2019 17:16:17 +0000 Subject: Re: [PATCH v2 1/7] fbdev: sm712fb: use type "u8" for 8-bit I/O. Message-Id: <20190331171617.ebh7aozv3eleyqzb@debian> List-Id: References: <20190322051759.15007-1-tomli@tomli.me> <20190322051759.15007-2-tomli@tomli.me> In-Reply-To: <20190322051759.15007-2-tomli@tomli.me> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yifeng Li Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Teddy Wang , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org On Fri, Mar 22, 2019 at 01:17:53PM +0800, Yifeng Li wrote: > This commit converts "unsigned int" and "int" in I/O wrappers > to "u8". It improves readability since it's consistent with > the prototypes of readb() and writeb(). More importantly, it > reduces readers' confusion, since the upcoming 2D acceleration > code will use a different wordsize. > > Signed-off-by: Yifeng Li Tested-by: Sudip Mukherjee -- Regards Sudip From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudip Mukherjee Subject: Re: [PATCH v2 1/7] fbdev: sm712fb: use type "u8" for 8-bit I/O. Date: Sun, 31 Mar 2019 18:16:17 +0100 Message-ID: <20190331171617.ebh7aozv3eleyqzb@debian> References: <20190322051759.15007-1-tomli@tomli.me> <20190322051759.15007-2-tomli@tomli.me> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2F6286E073 for ; Sun, 31 Mar 2019 17:16:22 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id r4so8825412wrq.8 for ; Sun, 31 Mar 2019 10:16:22 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20190322051759.15007-2-tomli@tomli.me> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Yifeng Li Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Teddy Wang , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBNYXIgMjIsIDIwMTkgYXQgMDE6MTc6NTNQTSArMDgwMCwgWWlmZW5nIExpIHdyb3Rl Ogo+IFRoaXMgY29tbWl0IGNvbnZlcnRzICJ1bnNpZ25lZCBpbnQiIGFuZCAiaW50IiBpbiBJL08g d3JhcHBlcnMKPiB0byAidTgiLiBJdCBpbXByb3ZlcyByZWFkYWJpbGl0eSBzaW5jZSBpdCdzIGNv bnNpc3RlbnQgd2l0aAo+IHRoZSBwcm90b3R5cGVzIG9mIHJlYWRiKCkgYW5kIHdyaXRlYigpLiBN b3JlIGltcG9ydGFudGx5LCBpdAo+IHJlZHVjZXMgcmVhZGVycycgY29uZnVzaW9uLCBzaW5jZSB0 aGUgdXBjb21pbmcgMkQgYWNjZWxlcmF0aW9uCj4gY29kZSB3aWxsIHVzZSBhIGRpZmZlcmVudCB3 b3Jkc2l6ZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBZaWZlbmcgTGkgPHRvbWxpQHRvbWxpLm1lPgoK VGVzdGVkLWJ5OiBTdWRpcCBNdWtoZXJqZWUgPHN1ZGlwbS5tdWtoZXJqZWVAZ21haWwuY29tPgoK LS0KUmVnYXJkcwpTdWRpcApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWw=