From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7E2776E147 for ; Mon, 1 Apr 2019 10:24:41 +0000 (UTC) Date: Mon, 1 Apr 2019 13:24:39 +0300 From: Petri Latvala Message-ID: <20190401102439.GE4038@platvala-desk.ger.corp.intel.com> References: <20190401064657.23322-1-arkadiusz.hiler@intel.com> <20190401064657.23322-2-arkadiusz.hiler@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190401064657.23322-2-arkadiusz.hiler@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t 2/3] runner: Refactor metadata parsing List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Arkadiusz Hiler Cc: igt-dev@lists.freedesktop.org List-ID: T24gTW9uLCBBcHIgMDEsIDIwMTkgYXQgMDk6NDY6NTZBTSArMDMwMCwgQXJrYWRpdXN6IEhpbGVy IHdyb3RlOgo+IFRvIGFpZCB0ZXN0aW5nIGZ1bmN0aW9uIHBhcnNpbmcgbWV0YWRhdGEudHh0IGlz IHNwbGl0IGludG8gb3V0ZXIgaGVscGVyCj4gdGhhdCBvcGVyYXRlcyBvbiBkaXJmZCBhbmQgaW5u ZXIgZnVuY3Rpb24gdGhhdCBvcGVyYXRlcyBvbiBGSUxFKi4KPiAKPiBUaGlzIGFsbG93cyB1cyB0 byB0ZXN0IHRoZSBwYXJzaW5nIHVzaW5nIGZtZW1vcGVuKCksIGxpbWl0aW5nIHRoZSBhbW91bnQK PiBvZiBuZWNlc3NhcnkgYm9pbGVycGxhdGUuCj4gCj4gU2lnbmVkLW9mZi1ieTogQXJrYWRpdXN6 IEhpbGVyIDxhcmthZGl1c3ouaGlsZXJAaW50ZWwuY29tPgo+IC0tLQo+ICBydW5uZXIvZXhlY3V0 b3IuYyAgICAgfCAgMiArLQo+ICBydW5uZXIvcmVzdWx0Z2VuLmMgICAgfCAgMiArLQo+ICBydW5u ZXIvcnVubmVyX3Rlc3RzLmMgfCAgMiArLQo+ICBydW5uZXIvc2V0dGluZ3MuYyAgICAgfCA0MCAr KysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tCj4gIHJ1bm5lci9zZXR0aW5n cy5oICAgICB8ICA0ICsrKy0KPiAgNSBmaWxlcyBjaGFuZ2VkLCAzMiBpbnNlcnRpb25zKCspLCAx OCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvcnVubmVyL2V4ZWN1dG9yLmMgYi9ydW5u ZXIvZXhlY3V0b3IuYwo+IGluZGV4IGE0MGUyZGQxLi4wZTkxYjdhYiAxMDA2NDQKPiAtLS0gYS9y dW5uZXIvZXhlY3V0b3IuYwo+ICsrKyBiL3J1bm5lci9leGVjdXRvci5jCj4gQEAgLTExMTIsNyAr MTExMiw3IEBAIGJvb2wgaW5pdGlhbGl6ZV9leGVjdXRlX3N0YXRlX2Zyb21fcmVzdW1lKGludCBk aXJmZCwKPiAgCW1lbXNldChzdGF0ZSwgMCwgc2l6ZW9mKCpzdGF0ZSkpOwo+ICAJc3RhdGUtPnJl c3VtaW5nID0gdHJ1ZTsKPiAgCj4gLQlpZiAoIXJlYWRfc2V0dGluZ3Moc2V0dGluZ3MsIGRpcmZk KSB8fAo+ICsJaWYgKCFyZWFkX3NldHRpbmdzX2Zyb21fZGlyKHNldHRpbmdzLCBkaXJmZCkgfHwK PiAgCSAgICAhcmVhZF9qb2JfbGlzdChsaXN0LCBkaXJmZCkpIHsKPiAgCQljbG9zZShkaXJmZCk7 Cj4gIAkJcmV0dXJuIGZhbHNlOwo+IGRpZmYgLS1naXQgYS9ydW5uZXIvcmVzdWx0Z2VuLmMgYi9y dW5uZXIvcmVzdWx0Z2VuLmMKPiBpbmRleCA3M2ZkYTY0Zi4uNDBkMWNmY2MgMTAwNjQ0Cj4gLS0t IGEvcnVubmVyL3Jlc3VsdGdlbi5jCj4gKysrIGIvcnVubmVyL3Jlc3VsdGdlbi5jCj4gQEAgLTEw ODUsNyArMTA4NSw3IEBAIHN0cnVjdCBqc29uX29iamVjdCAqZ2VuZXJhdGVfcmVzdWx0c19qc29u KGludCBkaXJmZCkKPiAgCWluaXRfc2V0dGluZ3MoJnNldHRpbmdzKTsKPiAgCWluaXRfam9iX2xp c3QoJmpvYl9saXN0KTsKPiAgCj4gLQlpZiAoIXJlYWRfc2V0dGluZ3MoJnNldHRpbmdzLCBkaXJm ZCkpIHsKPiArCWlmICghcmVhZF9zZXR0aW5nc19mcm9tX2Rpcigmc2V0dGluZ3MsIGRpcmZkKSkg ewo+ICAJCWZwcmludGYoc3RkZXJyLCAicmVzdWx0Z2VuOiBDYW5ub3QgcGFyc2Ugc2V0dGluZ3Nc biIpOwo+ICAJCXJldHVybiBOVUxMOwo+ICAJfQo+IGRpZmYgLS1naXQgYS9ydW5uZXIvcnVubmVy X3Rlc3RzLmMgYi9ydW5uZXIvcnVubmVyX3Rlc3RzLmMKPiBpbmRleCBlNDY1NjhhYy4uMDY3MjU1 MzYgMTAwNjQ0Cj4gLS0tIGEvcnVubmVyL3J1bm5lcl90ZXN0cy5jCj4gKysrIGIvcnVubmVyL3J1 bm5lcl90ZXN0cy5jCj4gQEAgLTY4MCw3ICs2ODAsNyBAQCBpZ3RfbWFpbgo+ICAJCQkJICAgICAi T3BlbmluZyAlcy9tZXRhZGF0YS50eHQgZmFpbGVkXG4iLCBkaXJuYW1lKTsKPiAgCQkJY2xvc2Uo ZmQpOwo+ICAKPiAtCQkJaWd0X2Fzc2VydF9mKHJlYWRfc2V0dGluZ3MoJmNtcF9zZXR0aW5ncywg ZGlyZmQpLCAiUmVhZGluZyBzZXR0aW5ncyBmYWlsZWRcbiIpOwo+ICsJCQlpZ3RfYXNzZXJ0X2Yo cmVhZF9zZXR0aW5nc19mcm9tX2RpcigmY21wX3NldHRpbmdzLCBkaXJmZCksICJSZWFkaW5nIHNl dHRpbmdzIGZhaWxlZFxuIik7Cj4gIAkJCWFzc2VydF9zZXR0aW5nc19lcXVhbCgmc2V0dGluZ3Ms ICZjbXBfc2V0dGluZ3MpOwo+ICAJCX0KPiAgCj4gZGlmZiAtLWdpdCBhL3J1bm5lci9zZXR0aW5n cy5jIGIvcnVubmVyL3NldHRpbmdzLmMKPiBpbmRleCBlNjQyNDRlNi4uMjBiMjEzNzggMTAwNjQ0 Cj4gLS0tIGEvcnVubmVyL3NldHRpbmdzLmMKPiArKysgYi9ydW5uZXIvc2V0dGluZ3MuYwo+IEBA IC01NDAsNyArNTQwLDcgQEAgYm9vbCBzZXJpYWxpemVfc2V0dGluZ3Moc3RydWN0IHNldHRpbmdz ICpzZXR0aW5ncykKPiAgI3VuZGVmIFNFUklBTElaRV9MSU5FCj4gIH0KPiAgCj4gLWJvb2wgcmVh ZF9zZXR0aW5ncyhzdHJ1Y3Qgc2V0dGluZ3MgKnNldHRpbmdzLCBpbnQgZGlyZmQpCj4gK2Jvb2wg cmVhZF9zZXR0aW5nc19mcm9tX2ZpbGUoc3RydWN0IHNldHRpbmdzICpzZXR0aW5ncywgRklMRSAq ZikKPiAgewo+ICAjZGVmaW5lIFBBUlNFX0xJTkUocywgbmFtZSwgdmFsLCBmaWVsZCwgd3JpdGUp IFwKPiAgCWlmICghc3RyY21wKG5hbWUsICNmaWVsZCkpIHsJICAgICAgIFwKPiBAQCAtNTUxLDIw ICs1NTEsOCBAQCBib29sIHJlYWRfc2V0dGluZ3Moc3RydWN0IHNldHRpbmdzICpzZXR0aW5ncywg aW50IGRpcmZkKQo+ICAJCWNvbnRpbnVlOwkJICAgICAgIFwKPiAgCX0KPiAgCj4gLQlpbnQgZmQ7 Cj4gLQlGSUxFICpmOwo+ICAJY2hhciAqbmFtZSA9IE5VTEwsICp2YWwgPSBOVUxMOwo+ICAKPiAt CWZyZWVfc2V0dGluZ3Moc2V0dGluZ3MpOwo+IC0KPiAtCWlmICgoZmQgPSBvcGVuYXQoZGlyZmQs IHNldHRpbmdzX2ZpbGVuYW1lLCBPX1JET05MWSkpIDwgMCkKPiAtCQlyZXR1cm4gZmFsc2U7Cj4g LQo+IC0JZiA9IGZkb3BlbihmZCwgInIiKTsKPiAtCWlmICghZikgewo+IC0JCWNsb3NlKGZkKTsK PiAtCQlyZXR1cm4gZmFsc2U7Cj4gLQl9Cj4gIAo+ICAJd2hpbGUgKGZzY2FuZihmLCAiJW1zIDog JW1zIiwgJm5hbWUsICZ2YWwpID09IDIpIHsKPiAgCQlpbnQgbnVtdmFsID0gYXRvaSh2YWwpOwo+ IEBAIC01OTIsOSArNTgwLDMzIEBAIGJvb2wgcmVhZF9zZXR0aW5ncyhzdHJ1Y3Qgc2V0dGluZ3Mg KnNldHRpbmdzLCBpbnQgZGlyZmQpCj4gIAo+ICAJZnJlZShuYW1lKTsKPiAgCWZyZWUodmFsKTsK PiAtCWZjbG9zZShmKTsKPiAgCj4gIAlyZXR1cm4gdHJ1ZTsKPiAgCj4gICN1bmRlZiBQQVJTRV9M SU5FCj4gIH0KPiArCj4gK2Jvb2wgcmVhZF9zZXR0aW5nc19mcm9tX2RpcihzdHJ1Y3Qgc2V0dGlu Z3MgKnNldHRpbmdzLCBpbnQgZGlyZmQpCj4gK3sKPiArCWludCBmZDsKPiArCUZJTEUgKmY7Cj4g Kwo+ICsKCgpFeHRyYSBsaW5lIGhlcmUKCgo+ICsJZnJlZV9zZXR0aW5ncyhzZXR0aW5ncyk7Cj4g Kwo+ICsJaWYgKChmZCA9IG9wZW5hdChkaXJmZCwgc2V0dGluZ3NfZmlsZW5hbWUsIE9fUkRPTkxZ KSkgPCAwKQo+ICsJCXJldHVybiBmYWxzZTsKPiArCj4gKwlmID0gZmRvcGVuKGZkLCAiciIpOwo+ ICsJaWYgKCFmKSB7Cj4gKwkJY2xvc2UoZmQpOwo+ICsJCXJldHVybiBmYWxzZTsKPiArCX0KPiAr Cj4gKwlpZiAoIXJlYWRfc2V0dGluZ3NfZnJvbV9maWxlKHNldHRpbmdzLCBmKSkKPiArCQlyZXR1 cm4gZmFsc2U7CgpmIGxlYWtlZCBpZiByZWFkX3NldHRpbmdzX2Zyb21fZmlsZSBmYWlscwoKCgpX aXRoIHRob3NlIGZpeGVkLApSZXZpZXdlZC1ieTogUGV0cmkgTGF0dmFsYSA8cGV0cmkubGF0dmFs YUBpbnRlbC5jb20+Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldg==