All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eugeniu Rosca <erosca@de.adit-jv.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/5] fdt: boot_get_fdt: simplify no_fdt handling (non-functional)
Date: Mon, 1 Apr 2019 12:45:35 +0200	[thread overview]
Message-ID: <20190401104537.29801-4-erosca@de.adit-jv.com> (raw)
In-Reply-To: <20190401104537.29801-1-erosca@de.adit-jv.com>

Increase the readability of boot_get_fdt().
No change in behavior is expected.

Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
---
Changes in v2:
 - NA
 - Link v1: https://patchwork.ozlabs.org/patch/1071588/
---
 common/image-fdt.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/common/image-fdt.c b/common/image-fdt.c
index c335e7e2f220..68bcab85baf4 100644
--- a/common/image-fdt.c
+++ b/common/image-fdt.c
@@ -279,7 +279,6 @@ int boot_get_fdt(int flag, int argc, char * const argv[], uint8_t arch,
 	int		fdt_noffset;
 #endif
 	const char *select = NULL;
-	int		ok_no_fdt = 0;
 
 	*of_flat_tree = NULL;
 	*of_size = 0;
@@ -487,12 +486,9 @@ int boot_get_fdt(int flag, int argc, char * const argv[], uint8_t arch,
 	return 0;
 
 no_fdt:
-	ok_no_fdt = 1;
+	debug("Continuing to boot without FDT\n");
+	return 0;
 error:
-	if (ok_no_fdt) {
-		debug("Continuing to boot without FDT\n");
-		return 0;
-	}
 	return 1;
 }
 
-- 
2.21.0

  parent reply	other threads:[~2019-04-01 10:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01 10:45 [U-Boot] [PATCH v2 0/5] boot_get_fdt: clean up and use 'fdtaddr' as fallback for Android Eugeniu Rosca
2019-04-01 10:45 ` [U-Boot] [PATCH v2 1/5] fdt: boot_get_fdt: remove redundant zeroing out Eugeniu Rosca
2019-04-18  4:33   ` Simon Glass
2019-04-18 10:18     ` Eugeniu Rosca
2019-04-20  1:36       ` Simon Glass
2019-04-22  2:38       ` sjg at google.com
2019-04-25 17:00     ` Eugeniu Rosca
2019-04-01 10:45 ` [U-Boot] [PATCH v2 2/5] fdt: boot_get_fdt: really boot w/o FDT when "goto no_fdt" Eugeniu Rosca
2019-04-21 19:26   ` Simon Glass
2019-04-22  2:38   ` sjg at google.com
2019-04-25 17:04     ` Eugeniu Rosca
2019-04-01 10:45 ` Eugeniu Rosca [this message]
2019-04-21 19:26   ` [U-Boot] [PATCH v2 3/5] fdt: boot_get_fdt: simplify no_fdt handling (non-functional) Simon Glass
2019-04-22  2:38   ` sjg at google.com
2019-04-01 10:45 ` [U-Boot] [PATCH v2 4/5] fdt: boot_get_fdt: android: compress " Eugeniu Rosca
2019-04-21 19:26   ` Simon Glass
2019-04-22  2:38   ` sjg at google.com
2019-04-01 10:52 ` [U-Boot] [PATCH v2 5/5] fdt: boot_get_fdt: android: use ENV 'fdtaddr' as fallback Eugeniu Rosca
2019-04-01 15:26   ` Eugeniu Rosca
2019-04-21 19:26   ` Simon Glass
2019-04-22  2:38   ` sjg at google.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190401104537.29801-4-erosca@de.adit-jv.com \
    --to=erosca@de.adit-jv.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.