From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFEF9C4360F for ; Mon, 1 Apr 2019 17:55:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B881F2084B for ; Mon, 1 Apr 2019 17:55:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729489AbfDARzS (ORCPT ); Mon, 1 Apr 2019 13:55:18 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:35629 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729476AbfDARzS (ORCPT ); Mon, 1 Apr 2019 13:55:18 -0400 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hB19M-0006iR-PM; Mon, 01 Apr 2019 19:55:12 +0200 Received: from mgr by ptx.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1hB19I-0008NL-E3; Mon, 01 Apr 2019 19:55:08 +0200 Date: Mon, 1 Apr 2019 19:55:08 +0200 From: Michael Grzeschik To: Fabio Estevam Cc: shawnguo@kernel.org, andrew@lunn.ch, baruch@tkos.co.il, linux@armlinux.org.uk, stable@vger.kernel.org, smoch@web.de, stwiss.opensource@diasemi.com, linux-imx@nxp.com, kernel@pengutronix.de, Marc Kleine-Budde , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: dts: imx: Fix the AR803X phy-mode Message-ID: <20190401175508.cyzfee7hedi3rvyn@pengutronix.de> References: <20190401124730.25814-1-festevam@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ac3ppvlgznrtfgsr" Content-Disposition: inline In-Reply-To: <20190401124730.25814-1-festevam@gmail.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 19:49:42 up 14 days, 5:00, 54 users, load average: 1.08, 1.09, 1.09 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mgr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: stable@vger.kernel.org Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org --ac3ppvlgznrtfgsr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Apr 01, 2019 at 09:47:30AM -0300, Fabio Estevam wrote: > Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode= ") > exposed an issue on imx DTS files using AR8031/AR8035 PHYs. >=20 > The end result is that the boards can no longer obtain an IP address > via UDHCP, for example. >=20 > Quoting Andrew Lunn: >=20 > "The problem here is, all the DTs were broken since day 0. However, > because the PHY driver was also broken, nobody noticed and it > worked. Now that the PHY driver has been fixed, all the bugs in the > DTs now become an issue" >=20 > To fix this problem, the phy-mode property needs to be "rgmii-id", which > has the following meaning as per=20 > Documentation/devicetree/bindings/net/ethernet.txt: >=20 > "RGMII with internal RX and TX delays provided by the PHY, the MAC should > not add the RX or TX delays in this case)" >=20 > Tested on imx6-sabresd, imx6sx-sdb and imx7d-pico boards with > successfully restored networking. >=20 > Based on the initial submission from Steve Twiss for the > imx6qdl-sabresd. >=20 > Cc: # 4.9+ > Signed-off-by: Fabio Estevam > Tested-by: Baruch Siach > Tested-by: Soeren Moch > Tested-by: Steve Twiss > Tested-by: Adam Thomson > Signed-off-by: Steve Twiss > Tested-by: Marc Kleine-Budde > Signed-off-by: Marc Kleine-Budde > --- > arch/arm/boot/dts/imx6dl-riotboard.dts | 2 +- > arch/arm/boot/dts/imx6q-tbs2910.dts | 2 +- > arch/arm/boot/dts/imx6qdl-apf6.dtsi | 2 +- > arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 2 +- > arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 2 +- > arch/arm/boot/dts/imx6qdl-sr-som.dtsi | 2 +- > arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 2 +- > arch/arm/boot/dts/imx6sx-sabreauto.dts | 2 +- > arch/arm/boot/dts/imx6sx-sdb.dtsi | 2 +- > arch/arm/boot/dts/imx7d-pico.dtsi | 2 +- > 10 files changed, 10 insertions(+), 10 deletions(-) >=20 > diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts b/arch/arm/boot/dts/i= mx6dl-riotboard.dts > index 65c184bb8fb0..d9de49efa802 100644 > --- a/arch/arm/boot/dts/imx6dl-riotboard.dts > +++ b/arch/arm/boot/dts/imx6dl-riotboard.dts > @@ -92,7 +92,7 @@ > &fec { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_enet>; > - phy-mode =3D "rgmii"; > + phy-mode =3D "rgmii-id"; > phy-reset-gpios =3D <&gpio3 31 GPIO_ACTIVE_LOW>; > interrupts-extended =3D <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, > <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; > diff --git a/arch/arm/boot/dts/imx6q-tbs2910.dts b/arch/arm/boot/dts/imx6= q-tbs2910.dts > index 2ce8399a10ba..bfff87ce2e1f 100644 > --- a/arch/arm/boot/dts/imx6q-tbs2910.dts > +++ b/arch/arm/boot/dts/imx6q-tbs2910.dts > @@ -98,7 +98,7 @@ > &fec { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_enet>; > - phy-mode =3D "rgmii"; > + phy-mode =3D "rgmii-id"; > phy-reset-gpios =3D <&gpio1 25 GPIO_ACTIVE_LOW>; > status =3D "okay"; > }; > diff --git a/arch/arm/boot/dts/imx6qdl-apf6.dtsi b/arch/arm/boot/dts/imx6= qdl-apf6.dtsi > index 1ebf29f43a24..4738c3c1ab50 100644 > --- a/arch/arm/boot/dts/imx6qdl-apf6.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-apf6.dtsi > @@ -51,7 +51,7 @@ > &fec { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_enet>; > - phy-mode =3D "rgmii"; > + phy-mode =3D "rgmii-id"; > phy-reset-duration =3D <10>; > phy-reset-gpios =3D <&gpio1 24 GPIO_ACTIVE_LOW>; > status =3D "okay"; > diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts= /imx6qdl-sabreauto.dtsi > index 1280de50a984..f3404dd10537 100644 > --- a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi > @@ -292,7 +292,7 @@ > &fec { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_enet>; > - phy-mode =3D "rgmii"; > + phy-mode =3D "rgmii-id"; > interrupts-extended =3D <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, > <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; > fsl,err006687-workaround-present; > diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/i= mx6qdl-sabresd.dtsi > index a0705066ccba..185fb17a3500 100644 > --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > @@ -202,7 +202,7 @@ > &fec { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_enet>; > - phy-mode =3D "rgmii"; > + phy-mode =3D "rgmii-id"; > phy-reset-gpios =3D <&gpio1 25 GPIO_ACTIVE_LOW>; > status =3D "okay"; > }; > diff --git a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi b/arch/arm/boot/dts/im= x6qdl-sr-som.dtsi > index 4ccb7afc4b35..6d7f6b9035bc 100644 > --- a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-sr-som.dtsi > @@ -53,7 +53,7 @@ > &fec { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_microsom_enet_ar8035>; > - phy-mode =3D "rgmii"; > + phy-mode =3D "rgmii-id"; > phy-reset-duration =3D <2>; > phy-reset-gpios =3D <&gpio4 15 GPIO_ACTIVE_LOW>; > status =3D "okay"; > diff --git a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts= /imx6qdl-wandboard.dtsi > index b7d5fb421404..50d9a989e06a 100644 > --- a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi > @@ -224,7 +224,7 @@ > &fec { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_enet>; > - phy-mode =3D "rgmii"; > + phy-mode =3D "rgmii-id"; > phy-reset-gpios =3D <&gpio3 29 GPIO_ACTIVE_LOW>; > interrupts-extended =3D <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, > <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; > diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts b/arch/arm/boot/dts/i= mx6sx-sabreauto.dts > index b0ee324afe58..315044ccd65f 100644 > --- a/arch/arm/boot/dts/imx6sx-sabreauto.dts > +++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts > @@ -75,7 +75,7 @@ > &fec1 { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_enet1>; > - phy-mode =3D "rgmii"; > + phy-mode =3D "rgmii-id"; > phy-handle =3D <ðphy1>; > fsl,magic-packet; > status =3D "okay"; > diff --git a/arch/arm/boot/dts/imx6sx-sdb.dtsi b/arch/arm/boot/dts/imx6sx= -sdb.dtsi > index 08ede56c3f10..f6972deb5e39 100644 > --- a/arch/arm/boot/dts/imx6sx-sdb.dtsi > +++ b/arch/arm/boot/dts/imx6sx-sdb.dtsi > @@ -191,7 +191,7 @@ > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_enet1>; > phy-supply =3D <®_enet_3v3>; > - phy-mode =3D "rgmii"; > + phy-mode =3D "rgmii-id"; > phy-handle =3D <ðphy1>; > phy-reset-gpios =3D <&gpio2 7 GPIO_ACTIVE_LOW>; > status =3D "okay"; > diff --git a/arch/arm/boot/dts/imx7d-pico.dtsi b/arch/arm/boot/dts/imx7d-= pico.dtsi > index 3fd595a71202..6f50ebf31a0a 100644 > --- a/arch/arm/boot/dts/imx7d-pico.dtsi > +++ b/arch/arm/boot/dts/imx7d-pico.dtsi > @@ -92,7 +92,7 @@ > <&clks IMX7D_ENET1_TIME_ROOT_CLK>; > assigned-clock-parents =3D <&clks IMX7D_PLL_ENET_MAIN_100M_CLK>; > assigned-clock-rates =3D <0>, <100000000>; > - phy-mode =3D "rgmii"; > + phy-mode =3D "rgmii-id"; > phy-handle =3D <ðphy0>; > fsl,magic-packet; > phy-reset-gpios =3D <&gpio6 11 GPIO_ACTIVE_LOW>; > --=20 > 2.17.1 >=20 >=20 > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >=20 Please add: diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi b/arch/arm/boot/d= ts/imx6qdl-nitrogen6_max.dtsi index c3415aa348a2c..153002e632f43 100644 --- a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi @@ -331,7 +331,7 @@ &fec { pinctrl-names =3D "default"; pinctrl-0 =3D <&pinctrl_enet>; - phy-mode =3D "rgmii"; + phy-mode =3D "rgmii-id"; phy-reset-gpios =3D <&gpio1 27 GPIO_ACTIVE_LOW>; txen-skew-ps =3D <0>; txc-skew-ps =3D <3000>; diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6_som2.dtsi b/arch/arm/boot/= dts/imx6qdl-nitrogen6_som2.dtsi index ed53f07c6b7b5..4ca653b467c76 100644 --- a/arch/arm/boot/dts/imx6qdl-nitrogen6_som2.dtsi +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6_som2.dtsi @@ -262,7 +262,7 @@ &fec { pinctrl-names =3D "default"; pinctrl-0 =3D <&pinctrl_enet>; - phy-mode =3D "rgmii"; + phy-mode =3D "rgmii-id"; interrupts-extended =3D <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; fsl,err006687-workaround-present; diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/= imx6qdl-nitrogen6x.dtsi index 8b0e432099b52..f08428820a10e 100644 --- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi @@ -264,7 +264,7 @@ &fec { pinctrl-names =3D "default"; pinctrl-0 =3D <&pinctrl_enet>; - phy-mode =3D "rgmii"; + phy-mode =3D "rgmii-id"; phy-reset-gpios =3D <&gpio1 27 GPIO_ACTIVE_LOW>; txen-skew-ps =3D <0>; txc-skew-ps =3D <3000>; Tested-by: Michael Grzeschik Signed-off-by: Michael Grzeschik Thanks, Michael --=20 Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --ac3ppvlgznrtfgsr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEElXvEUs6VPX6mDPT8C+njFXoeLGQFAlyiUHYACgkQC+njFXoe LGRh2Q//S2W1BF8Hw7xi76afSXf0Enw0Ysk2thlN21JrNfZw61iIZdDas6mYUerJ Pnb1gQaZWS5G+zCfGXIBt24MiS748TLGms4vLJqk1TNUTwOF8g0BqsAAmcD4hGrK jYnjM1vTS82ySH1VUQy8/quMlCB7SUDXfwbpZP0fO/D9xSydReWsRVPiGmKJ11yu EbNynefn2CMuPQY54QYxl986+f/2iuORU0lo+84NP8RcwV8FrRCvGniIeVhJoIZy ARz0+HbEm8KUYv4y/0OrFyI8qqZRorP/RC6pV65ETBOpKN3MJcwbVBIDk7oKSEXP xh1YcRdcGUoZMg0ItTmuGHljII4JcUZSq1Z/8n28uj+Jvzmi6A9NA2uP8TGxv3g2 XdB/lw+u5J0t8mVn1w4tM17qYbfuIbfM2t/t66D7kwhvvJ9NoO2u8hE49c5sid6g S9R8dLJ6IqVubUu4/NsuZuizyH+BKIsW2c/nBl1FhcLtpSZYldn5HRaL3ihJCNTM sa955U+pMwTtHMsh8Ip+To96RTvI5oV8oOU6PKS2nP/yZ8gcaL1LiszhscLjqruw C6dy76oid+EkYMqcPCCZtQxeftZ/O31obxTpGKjejrEpfS5mECCZSaBoxKYO/fFy A0LHCzIiHVdG9I8na9c8f+CpnA3zJnmwFwWoejCA5it+i1P/j6Q= =Zb5j -----END PGP SIGNATURE----- --ac3ppvlgznrtfgsr-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4AD2C4360F for ; Mon, 1 Apr 2019 17:55:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84E882084B for ; Mon, 1 Apr 2019 17:55:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ByWZcKf7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84E882084B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BFk7VxJcHXJGIejKeTXztwU0BycvJWvFFkOyZsAli3g=; b=ByWZcKf7ZO/Zexv24bsRWeGtH iLqwleTYk6n2ApX5dCMTYSXujCRzlZxd7ovdc3cvsv5oJV9WcFJApSIPwZvTuVXmlGCTcJGxWLVom LHLFPwD4z2pO6YbjIISfSbMCkSVBjkLBdBdM0/o6uWtmJJUMbvJTDvtCfzgx3OB/Yw54Bg2L3RnXu C04hAehLWyj8Pe9+C+iAHmATzIBv1i7daPCcnSLPWzN+benl7lKviWbOvvZwA/VBxeHwvXTRCgvp0 Wl1g3P/hQkBhiFlAZriLsqRTy1quU0va5qaFx4JN586M0CS7k2KLJaDedPXwczyqUKGl5OtY1W63E AdehoTc2A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB19d-0006jI-3d; Mon, 01 Apr 2019 17:55:29 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB19Y-0006i6-Op for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 17:55:27 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hB19M-0006iR-PM; Mon, 01 Apr 2019 19:55:12 +0200 Received: from mgr by ptx.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1hB19I-0008NL-E3; Mon, 01 Apr 2019 19:55:08 +0200 Date: Mon, 1 Apr 2019 19:55:08 +0200 From: Michael Grzeschik To: Fabio Estevam Subject: Re: [PATCH] ARM: dts: imx: Fix the AR803X phy-mode Message-ID: <20190401175508.cyzfee7hedi3rvyn@pengutronix.de> References: <20190401124730.25814-1-festevam@gmail.com> MIME-Version: 1.0 In-Reply-To: <20190401124730.25814-1-festevam@gmail.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 19:49:42 up 14 days, 5:00, 54 users, load average: 1.08, 1.09, 1.09 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mgr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_105525_128190_4FB2D072 X-CRM114-Status: GOOD ( 22.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, baruch@tkos.co.il, linux@armlinux.org.uk, stable@vger.kernel.org, smoch@web.de, stwiss.opensource@diasemi.com, linux-imx@nxp.com, kernel@pengutronix.de, Marc Kleine-Budde , shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============8916687377729904174==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8916687377729904174== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ac3ppvlgznrtfgsr" Content-Disposition: inline --ac3ppvlgznrtfgsr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Apr 01, 2019 at 09:47:30AM -0300, Fabio Estevam wrote: > Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode= ") > exposed an issue on imx DTS files using AR8031/AR8035 PHYs. >=20 > The end result is that the boards can no longer obtain an IP address > via UDHCP, for example. >=20 > Quoting Andrew Lunn: >=20 > "The problem here is, all the DTs were broken since day 0. However, > because the PHY driver was also broken, nobody noticed and it > worked. Now that the PHY driver has been fixed, all the bugs in the > DTs now become an issue" >=20 > To fix this problem, the phy-mode property needs to be "rgmii-id", which > has the following meaning as per=20 > Documentation/devicetree/bindings/net/ethernet.txt: >=20 > "RGMII with internal RX and TX delays provided by the PHY, the MAC should > not add the RX or TX delays in this case)" >=20 > Tested on imx6-sabresd, imx6sx-sdb and imx7d-pico boards with > successfully restored networking. >=20 > Based on the initial submission from Steve Twiss for the > imx6qdl-sabresd. >=20 > Cc: # 4.9+ > Signed-off-by: Fabio Estevam > Tested-by: Baruch Siach > Tested-by: Soeren Moch > Tested-by: Steve Twiss > Tested-by: Adam Thomson > Signed-off-by: Steve Twiss > Tested-by: Marc Kleine-Budde > Signed-off-by: Marc Kleine-Budde > --- > arch/arm/boot/dts/imx6dl-riotboard.dts | 2 +- > arch/arm/boot/dts/imx6q-tbs2910.dts | 2 +- > arch/arm/boot/dts/imx6qdl-apf6.dtsi | 2 +- > arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 2 +- > arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 2 +- > arch/arm/boot/dts/imx6qdl-sr-som.dtsi | 2 +- > arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 2 +- > arch/arm/boot/dts/imx6sx-sabreauto.dts | 2 +- > arch/arm/boot/dts/imx6sx-sdb.dtsi | 2 +- > arch/arm/boot/dts/imx7d-pico.dtsi | 2 +- > 10 files changed, 10 insertions(+), 10 deletions(-) >=20 > diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts b/arch/arm/boot/dts/i= mx6dl-riotboard.dts > index 65c184bb8fb0..d9de49efa802 100644 > --- a/arch/arm/boot/dts/imx6dl-riotboard.dts > +++ b/arch/arm/boot/dts/imx6dl-riotboard.dts > @@ -92,7 +92,7 @@ > &fec { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_enet>; > - phy-mode =3D "rgmii"; > + phy-mode =3D "rgmii-id"; > phy-reset-gpios =3D <&gpio3 31 GPIO_ACTIVE_LOW>; > interrupts-extended =3D <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, > <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; > diff --git a/arch/arm/boot/dts/imx6q-tbs2910.dts b/arch/arm/boot/dts/imx6= q-tbs2910.dts > index 2ce8399a10ba..bfff87ce2e1f 100644 > --- a/arch/arm/boot/dts/imx6q-tbs2910.dts > +++ b/arch/arm/boot/dts/imx6q-tbs2910.dts > @@ -98,7 +98,7 @@ > &fec { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_enet>; > - phy-mode =3D "rgmii"; > + phy-mode =3D "rgmii-id"; > phy-reset-gpios =3D <&gpio1 25 GPIO_ACTIVE_LOW>; > status =3D "okay"; > }; > diff --git a/arch/arm/boot/dts/imx6qdl-apf6.dtsi b/arch/arm/boot/dts/imx6= qdl-apf6.dtsi > index 1ebf29f43a24..4738c3c1ab50 100644 > --- a/arch/arm/boot/dts/imx6qdl-apf6.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-apf6.dtsi > @@ -51,7 +51,7 @@ > &fec { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_enet>; > - phy-mode =3D "rgmii"; > + phy-mode =3D "rgmii-id"; > phy-reset-duration =3D <10>; > phy-reset-gpios =3D <&gpio1 24 GPIO_ACTIVE_LOW>; > status =3D "okay"; > diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts= /imx6qdl-sabreauto.dtsi > index 1280de50a984..f3404dd10537 100644 > --- a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi > @@ -292,7 +292,7 @@ > &fec { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_enet>; > - phy-mode =3D "rgmii"; > + phy-mode =3D "rgmii-id"; > interrupts-extended =3D <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, > <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; > fsl,err006687-workaround-present; > diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/i= mx6qdl-sabresd.dtsi > index a0705066ccba..185fb17a3500 100644 > --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > @@ -202,7 +202,7 @@ > &fec { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_enet>; > - phy-mode =3D "rgmii"; > + phy-mode =3D "rgmii-id"; > phy-reset-gpios =3D <&gpio1 25 GPIO_ACTIVE_LOW>; > status =3D "okay"; > }; > diff --git a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi b/arch/arm/boot/dts/im= x6qdl-sr-som.dtsi > index 4ccb7afc4b35..6d7f6b9035bc 100644 > --- a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-sr-som.dtsi > @@ -53,7 +53,7 @@ > &fec { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_microsom_enet_ar8035>; > - phy-mode =3D "rgmii"; > + phy-mode =3D "rgmii-id"; > phy-reset-duration =3D <2>; > phy-reset-gpios =3D <&gpio4 15 GPIO_ACTIVE_LOW>; > status =3D "okay"; > diff --git a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts= /imx6qdl-wandboard.dtsi > index b7d5fb421404..50d9a989e06a 100644 > --- a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi > @@ -224,7 +224,7 @@ > &fec { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_enet>; > - phy-mode =3D "rgmii"; > + phy-mode =3D "rgmii-id"; > phy-reset-gpios =3D <&gpio3 29 GPIO_ACTIVE_LOW>; > interrupts-extended =3D <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, > <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; > diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts b/arch/arm/boot/dts/i= mx6sx-sabreauto.dts > index b0ee324afe58..315044ccd65f 100644 > --- a/arch/arm/boot/dts/imx6sx-sabreauto.dts > +++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts > @@ -75,7 +75,7 @@ > &fec1 { > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_enet1>; > - phy-mode =3D "rgmii"; > + phy-mode =3D "rgmii-id"; > phy-handle =3D <ðphy1>; > fsl,magic-packet; > status =3D "okay"; > diff --git a/arch/arm/boot/dts/imx6sx-sdb.dtsi b/arch/arm/boot/dts/imx6sx= -sdb.dtsi > index 08ede56c3f10..f6972deb5e39 100644 > --- a/arch/arm/boot/dts/imx6sx-sdb.dtsi > +++ b/arch/arm/boot/dts/imx6sx-sdb.dtsi > @@ -191,7 +191,7 @@ > pinctrl-names =3D "default"; > pinctrl-0 =3D <&pinctrl_enet1>; > phy-supply =3D <®_enet_3v3>; > - phy-mode =3D "rgmii"; > + phy-mode =3D "rgmii-id"; > phy-handle =3D <ðphy1>; > phy-reset-gpios =3D <&gpio2 7 GPIO_ACTIVE_LOW>; > status =3D "okay"; > diff --git a/arch/arm/boot/dts/imx7d-pico.dtsi b/arch/arm/boot/dts/imx7d-= pico.dtsi > index 3fd595a71202..6f50ebf31a0a 100644 > --- a/arch/arm/boot/dts/imx7d-pico.dtsi > +++ b/arch/arm/boot/dts/imx7d-pico.dtsi > @@ -92,7 +92,7 @@ > <&clks IMX7D_ENET1_TIME_ROOT_CLK>; > assigned-clock-parents =3D <&clks IMX7D_PLL_ENET_MAIN_100M_CLK>; > assigned-clock-rates =3D <0>, <100000000>; > - phy-mode =3D "rgmii"; > + phy-mode =3D "rgmii-id"; > phy-handle =3D <ðphy0>; > fsl,magic-packet; > phy-reset-gpios =3D <&gpio6 11 GPIO_ACTIVE_LOW>; > --=20 > 2.17.1 >=20 >=20 > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >=20 Please add: diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi b/arch/arm/boot/d= ts/imx6qdl-nitrogen6_max.dtsi index c3415aa348a2c..153002e632f43 100644 --- a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi @@ -331,7 +331,7 @@ &fec { pinctrl-names =3D "default"; pinctrl-0 =3D <&pinctrl_enet>; - phy-mode =3D "rgmii"; + phy-mode =3D "rgmii-id"; phy-reset-gpios =3D <&gpio1 27 GPIO_ACTIVE_LOW>; txen-skew-ps =3D <0>; txc-skew-ps =3D <3000>; diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6_som2.dtsi b/arch/arm/boot/= dts/imx6qdl-nitrogen6_som2.dtsi index ed53f07c6b7b5..4ca653b467c76 100644 --- a/arch/arm/boot/dts/imx6qdl-nitrogen6_som2.dtsi +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6_som2.dtsi @@ -262,7 +262,7 @@ &fec { pinctrl-names =3D "default"; pinctrl-0 =3D <&pinctrl_enet>; - phy-mode =3D "rgmii"; + phy-mode =3D "rgmii-id"; interrupts-extended =3D <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; fsl,err006687-workaround-present; diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/= imx6qdl-nitrogen6x.dtsi index 8b0e432099b52..f08428820a10e 100644 --- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi @@ -264,7 +264,7 @@ &fec { pinctrl-names =3D "default"; pinctrl-0 =3D <&pinctrl_enet>; - phy-mode =3D "rgmii"; + phy-mode =3D "rgmii-id"; phy-reset-gpios =3D <&gpio1 27 GPIO_ACTIVE_LOW>; txen-skew-ps =3D <0>; txc-skew-ps =3D <3000>; Tested-by: Michael Grzeschik Signed-off-by: Michael Grzeschik Thanks, Michael --=20 Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --ac3ppvlgznrtfgsr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEElXvEUs6VPX6mDPT8C+njFXoeLGQFAlyiUHYACgkQC+njFXoe LGRh2Q//S2W1BF8Hw7xi76afSXf0Enw0Ysk2thlN21JrNfZw61iIZdDas6mYUerJ Pnb1gQaZWS5G+zCfGXIBt24MiS748TLGms4vLJqk1TNUTwOF8g0BqsAAmcD4hGrK jYnjM1vTS82ySH1VUQy8/quMlCB7SUDXfwbpZP0fO/D9xSydReWsRVPiGmKJ11yu EbNynefn2CMuPQY54QYxl986+f/2iuORU0lo+84NP8RcwV8FrRCvGniIeVhJoIZy ARz0+HbEm8KUYv4y/0OrFyI8qqZRorP/RC6pV65ETBOpKN3MJcwbVBIDk7oKSEXP xh1YcRdcGUoZMg0ItTmuGHljII4JcUZSq1Z/8n28uj+Jvzmi6A9NA2uP8TGxv3g2 XdB/lw+u5J0t8mVn1w4tM17qYbfuIbfM2t/t66D7kwhvvJ9NoO2u8hE49c5sid6g S9R8dLJ6IqVubUu4/NsuZuizyH+BKIsW2c/nBl1FhcLtpSZYldn5HRaL3ihJCNTM sa955U+pMwTtHMsh8Ip+To96RTvI5oV8oOU6PKS2nP/yZ8gcaL1LiszhscLjqruw C6dy76oid+EkYMqcPCCZtQxeftZ/O31obxTpGKjejrEpfS5mECCZSaBoxKYO/fFy A0LHCzIiHVdG9I8na9c8f+CpnA3zJnmwFwWoejCA5it+i1P/j6Q= =Zb5j -----END PGP SIGNATURE----- --ac3ppvlgznrtfgsr-- --===============8916687377729904174== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8916687377729904174==--