From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DB62C43381 for ; Mon, 1 Apr 2019 17:21:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 67A6D20883 for ; Mon, 1 Apr 2019 17:21:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731817AbfDARV1 (ORCPT ); Mon, 1 Apr 2019 13:21:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39830 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731404AbfDARVX (ORCPT ); Mon, 1 Apr 2019 13:21:23 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C19AF7C082; Mon, 1 Apr 2019 17:21:22 +0000 (UTC) Received: from gondolin (ovpn-117-29.ams2.redhat.com [10.36.117.29]) by smtp.corp.redhat.com (Postfix) with ESMTP id D6D7860123; Mon, 1 Apr 2019 17:21:18 +0000 (UTC) Date: Mon, 1 Apr 2019 19:21:15 +0200 From: Cornelia Huck To: Parav Pandit Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, kwankhede@nvidia.com, alex.williamson@redhat.com, cjia@nvidia.com Subject: Re: [PATCHv1 4/7] vfio/mdev: Avoid masking error code to EBUSY Message-ID: <20190401192115.3bc7ec4e.cohuck@redhat.com> In-Reply-To: <1553658345-43995-5-git-send-email-parav@mellanox.com> References: <1553658345-43995-1-git-send-email-parav@mellanox.com> <1553658345-43995-5-git-send-email-parav@mellanox.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 01 Apr 2019 17:21:22 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Mar 2019 22:45:42 -0500 Parav Pandit wrote: > Instead of masking return error to -EBUSY, return actual error > returned by the driver. > > Reviewed-by: Maxim Levitsky > Signed-off-by: Parav Pandit > --- > drivers/vfio/mdev/mdev_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c > index 00ca613..836d319 100644 > --- a/drivers/vfio/mdev/mdev_core.c > +++ b/drivers/vfio/mdev/mdev_core.c > @@ -141,7 +141,7 @@ static int mdev_device_remove_ops(struct mdev_device *mdev, bool force_remove) > */ > ret = parent->ops->remove(mdev); > if (ret && !force_remove) > - return -EBUSY; > + return ret; > > sysfs_remove_groups(&mdev->dev.kobj, parent->ops->mdev_attr_groups); > return 0; Makes sense, even if no current ->remove callback returns anything other than 0 or -EBUSY. Reviewed-by: Cornelia Huck