All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: vladbu@mellanox.com
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
	xiyou.wangcong@gmail.com, jiri@resnulli.us
Subject: Re: [PATCH net-next] net: sched: don't set tunnel for decap action
Date: Tue, 02 Apr 2019 13:20:49 -0700 (PDT)	[thread overview]
Message-ID: <20190402.132049.72774598864366010.davem@davemloft.net> (raw)
In-Reply-To: <20190401111659.22588-1-vladbu@mellanox.com>

From: Vlad Buslov <vladbu@mellanox.com>
Date: Mon,  1 Apr 2019 14:16:59 +0300

> Action tunnel_key doesn't have a metadata/tunnel for release(decap) action.
> Drivers do not dereference entry->tunnel pointer for that action type, so
> this behavior doesn't result in a crash at the moment. However, this needs
> to be corrected as a preparation for updating hardware offloads API to not
> rely on rtnl lock, for which flow_action code will copy the tunnel data to
> temporary buffer to prevent concurrent action overwrite from
> invalidating/freeing it.
> 
> Fixes: 3a7b68617de7 ("cls_api: add translator to flow_action representation")
> Signed-off-by: Vlad Buslov <vladbu@mellanox.com>

Applied, thanks Vlad.

      reply	other threads:[~2019-04-02 20:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01 11:16 [PATCH net-next] net: sched: don't set tunnel for decap action Vlad Buslov
2019-04-02 20:20 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190402.132049.72774598864366010.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=vladbu@mellanox.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.