From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C761BC10F0B for ; Tue, 2 Apr 2019 14:06:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A10982084B for ; Tue, 2 Apr 2019 14:06:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731579AbfDBOGd (ORCPT ); Tue, 2 Apr 2019 10:06:33 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:54189 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726903AbfDBOGd (ORCPT ); Tue, 2 Apr 2019 10:06:33 -0400 X-Originating-IP: 109.213.83.19 Received: from localhost (alyon-652-1-60-19.w109-213.abo.wanadoo.fr [109.213.83.19]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 1B9CD6001E; Tue, 2 Apr 2019 14:06:27 +0000 (UTC) Date: Tue, 2 Apr 2019 16:06:27 +0200 From: Alexandre Belloni To: Yingjoe Chen Cc: Hsin-Hsiung Wang , Lee Jones , Rob Herring , Matthias Brugger , Mark Brown , Eddie Huang , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, srv_heupstream@mediatek.com, Alessandro Zummo , Marc Zyngier , Ran Bi , Sean Wang , linux-kernel@vger.kernel.org, Liam Girdwood , linux-mediatek@lists.infradead.org, Mark Rutland , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 9/9] rtc: Add support for the MediaTek MT6358 RTC Message-ID: <20190402140627.GC22216@piout.net> References: <1552275991-34648-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1552275991-34648-10-git-send-email-hsin-hsiung.wang@mediatek.com> <1553161886.13384.7.camel@mtksdaap41> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1553161886.13384.7.camel@mtksdaap41> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/03/2019 17:51:26+0800, Yingjoe Chen wrote: > > Hi, > > > Should use 'rtc: mt6397: ' as prefix for this patch. > > > On Mon, 2019-03-11 at 11:46 +0800, Hsin-Hsiung Wang wrote: > > From: Ran Bi > > > > This add support for the MediaTek MT6358 RTC. MT6397 mfd will pass > > RTC_WRTGR address offset to RTC driver. > > > > Signed-off-by: Ran Bi > > --- > > drivers/rtc/rtc-mt6397.c | 16 ++++++++++++++-- > > 1 file changed, 14 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c > > index f85f1fc..c8a0090 100644 > > --- a/drivers/rtc/rtc-mt6397.c > > +++ b/drivers/rtc/rtc-mt6397.c > > @@ -27,7 +27,7 @@ > > #define RTC_BBPU 0x0000 > > #define RTC_BBPU_CBUSY BIT(6) > > > > -#define RTC_WRTGR 0x003c > > +#define RTC_WRTGR_DEFAULT 0x003c > > > > #define RTC_IRQ_STA 0x0002 > > #define RTC_IRQ_STA_AL BIT(0) > > @@ -78,6 +78,7 @@ struct mt6397_rtc { > > struct regmap *regmap; > > int irq; > > u32 addr_base; > > + u32 wrtgr_offset; > > }; > > > > static int mtk_rtc_write_trigger(struct mt6397_rtc *rtc) > > @@ -86,7 +87,8 @@ static int mtk_rtc_write_trigger(struct mt6397_rtc *rtc) > > int ret; > > u32 data; > > > > - ret = regmap_write(rtc->regmap, rtc->addr_base + RTC_WRTGR, 1); > > + ret = regmap_write(rtc->regmap, > > + rtc->addr_base + rtc->wrtgr_offset, 1); > > if (ret < 0) > > return ret; > > > > @@ -341,6 +343,15 @@ static int mtk_rtc_probe(struct platform_device *pdev) > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > rtc->addr_base = res->start; > > > > + res = platform_get_resource(pdev, IORESOURCE_REG, 0); > > + if (res) { > > + rtc->wrtgr_offset = res->start; > > + dev_info(&pdev->dev, "register offset:%d\n", rtc->wrtgr_offset); > > + } else { > > + rtc->wrtgr_offset = RTC_WRTGR_DEFAULT; > > + dev_err(&pdev->dev, "Failed to get register offset\n"); > > + } > > + > > Since this will be passed by MFD, do we still need to keep the DEFAULT? > Any case this platform_get_resource will failed? > > It's too bad HW changed this offset, but I'm not sure about passing this > information from MFD. We have 1 register that have different offset now, > and might have others for future chips, adding each one by > IORESOURCE_IRQ doesn't looks like a good solution. Keeping this > information in RTC driver only also looks better. > I agree, this would be better. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8338C4360F for ; Tue, 2 Apr 2019 14:06:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA28C2084B for ; Tue, 2 Apr 2019 14:06:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="j89ah4wW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA28C2084B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dXC3Q8aQMXs9Cad6IdJ4Y/SJIdNAscVd68tplkUG6hw=; b=j89ah4wWbVBYSm GlRsqfY+ylZk3yX/GCyz/wqtgjF4Sl4JzaxJbogEc0Gm6RmZs4qp8os9TkT+xi+GR4n2EMwWQCTSG 1bpS2qX/TCSx5Ma3zC9JXNEB7nmcfonnnmwdu8l/lUsK1pnW3Dioc9yU/uWdtXx4nxsrVokJsuC7n hwmh6QwzcOqGtFBbRU4b/U72rdYlH+knV9WSeFte7LOfWJkEymArzwYCZxY9pVAUus2gBROutqDzP YnzH/gQWEyHS74f5JiihF2LCE1YAfoY2cDXn52kOCsOCIdlbkfNwxFAfKk4PSdIYYmnVAA5pZHVvW tsTxpAvOi1Qw+y7Q0KqQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBK3r-0002f2-4f; Tue, 02 Apr 2019 14:06:47 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBK3k-0002cr-BM; Tue, 02 Apr 2019 14:06:45 +0000 X-Originating-IP: 109.213.83.19 Received: from localhost (alyon-652-1-60-19.w109-213.abo.wanadoo.fr [109.213.83.19]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 1B9CD6001E; Tue, 2 Apr 2019 14:06:27 +0000 (UTC) Date: Tue, 2 Apr 2019 16:06:27 +0200 From: Alexandre Belloni To: Yingjoe Chen Subject: Re: [PATCH v2 9/9] rtc: Add support for the MediaTek MT6358 RTC Message-ID: <20190402140627.GC22216@piout.net> References: <1552275991-34648-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1552275991-34648-10-git-send-email-hsin-hsiung.wang@mediatek.com> <1553161886.13384.7.camel@mtksdaap41> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1553161886.13384.7.camel@mtksdaap41> User-Agent: Mutt/1.11.3 (2019-02-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190402_070640_690616_FC470282 X-CRM114-Status: GOOD ( 20.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, srv_heupstream@mediatek.com, Alessandro Zummo , Marc Zyngier , Ran Bi , Sean Wang , linux-kernel@vger.kernel.org, Rob Herring , Liam Girdwood , Mark Brown , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger , Mark Rutland , Eddie Huang , Lee Jones , Hsin-Hsiung Wang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/03/2019 17:51:26+0800, Yingjoe Chen wrote: > > Hi, > > > Should use 'rtc: mt6397: ' as prefix for this patch. > > > On Mon, 2019-03-11 at 11:46 +0800, Hsin-Hsiung Wang wrote: > > From: Ran Bi > > > > This add support for the MediaTek MT6358 RTC. MT6397 mfd will pass > > RTC_WRTGR address offset to RTC driver. > > > > Signed-off-by: Ran Bi > > --- > > drivers/rtc/rtc-mt6397.c | 16 ++++++++++++++-- > > 1 file changed, 14 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c > > index f85f1fc..c8a0090 100644 > > --- a/drivers/rtc/rtc-mt6397.c > > +++ b/drivers/rtc/rtc-mt6397.c > > @@ -27,7 +27,7 @@ > > #define RTC_BBPU 0x0000 > > #define RTC_BBPU_CBUSY BIT(6) > > > > -#define RTC_WRTGR 0x003c > > +#define RTC_WRTGR_DEFAULT 0x003c > > > > #define RTC_IRQ_STA 0x0002 > > #define RTC_IRQ_STA_AL BIT(0) > > @@ -78,6 +78,7 @@ struct mt6397_rtc { > > struct regmap *regmap; > > int irq; > > u32 addr_base; > > + u32 wrtgr_offset; > > }; > > > > static int mtk_rtc_write_trigger(struct mt6397_rtc *rtc) > > @@ -86,7 +87,8 @@ static int mtk_rtc_write_trigger(struct mt6397_rtc *rtc) > > int ret; > > u32 data; > > > > - ret = regmap_write(rtc->regmap, rtc->addr_base + RTC_WRTGR, 1); > > + ret = regmap_write(rtc->regmap, > > + rtc->addr_base + rtc->wrtgr_offset, 1); > > if (ret < 0) > > return ret; > > > > @@ -341,6 +343,15 @@ static int mtk_rtc_probe(struct platform_device *pdev) > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > rtc->addr_base = res->start; > > > > + res = platform_get_resource(pdev, IORESOURCE_REG, 0); > > + if (res) { > > + rtc->wrtgr_offset = res->start; > > + dev_info(&pdev->dev, "register offset:%d\n", rtc->wrtgr_offset); > > + } else { > > + rtc->wrtgr_offset = RTC_WRTGR_DEFAULT; > > + dev_err(&pdev->dev, "Failed to get register offset\n"); > > + } > > + > > Since this will be passed by MFD, do we still need to keep the DEFAULT? > Any case this platform_get_resource will failed? > > It's too bad HW changed this offset, but I'm not sure about passing this > information from MFD. We have 1 register that have different offset now, > and might have others for future chips, adding each one by > IORESOURCE_IRQ doesn't looks like a good solution. Keeping this > information in RTC driver only also looks better. > I agree, this would be better. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel