From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 123DFC4360F for ; Thu, 4 Apr 2019 04:49:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB632204EC for ; Thu, 4 Apr 2019 04:49:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726058AbfDDEt1 (ORCPT ); Thu, 4 Apr 2019 00:49:27 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:35366 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725903AbfDDEt1 (ORCPT ); Thu, 4 Apr 2019 00:49:27 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E5B65144FE3DE; Wed, 3 Apr 2019 21:49:26 -0700 (PDT) Date: Wed, 03 Apr 2019 21:49:26 -0700 (PDT) Message-Id: <20190403.214926.2003732231073495468.davem@davemloft.net> To: penguin-kernel@i-love.sakura.ne.jp Cc: netdev@vger.kernel.org, syzbot+0049bebbf3042dbd2e8f@syzkaller.appspotmail.com, syzbot+915c9f99f3dbc4bd6cd1@syzkaller.appspotmail.com Subject: Re: [PATCH] net: socket: Always initialize family field at move_addr_to_kernel(). From: David Miller In-Reply-To: References: <1554128362-12274-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> <20190402.132306.2280596762532017665.davem@davemloft.net> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 03 Apr 2019 21:49:27 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Tetsuo Handa Date: Wed, 3 Apr 2019 06:07:40 +0900 > On 2019/04/03 5:23, David Miller wrote: >> Please fix RDS and other protocols to examine the length properly >> instead. > > Do you prefer adding branches only for allow reading the family of socket address? If the length is zero, there is no point in reading the family.