From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9F7AC4360F for ; Wed, 3 Apr 2019 07:49:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BDD7720693 for ; Wed, 3 Apr 2019 07:49:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728772AbfDCHt5 (ORCPT ); Wed, 3 Apr 2019 03:49:57 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:39661 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726004AbfDCHt5 (ORCPT ); Wed, 3 Apr 2019 03:49:57 -0400 X-Originating-IP: 90.88.30.125 Received: from xps13 (aaubervilliers-681-1-89-125.w90-88.abo.wanadoo.fr [90.88.30.125]) (Authenticated sender: miquel.raynal@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 997BE1C0016; Wed, 3 Apr 2019 07:49:53 +0000 (UTC) Date: Wed, 3 Apr 2019 09:49:47 +0200 From: Miquel Raynal To: Stephen Rothwell Cc: Boris Brezillon , Linux Next Mailing List , Linux Kernel Mailing List , Paul Cercueil Subject: Re: linux-next: build warning after merge of the nand tree Message-ID: <20190403094947.1d9be502@xps13> In-Reply-To: <20190403102239.174fbe35@canb.auug.org.au> References: <20190403102239.174fbe35@canb.auug.org.au> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/qsqmeb635Ca4Dp/b1OU2MMw"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/qsqmeb635Ca4Dp/b1OU2MMw Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Stephen, Stephen Rothwell wrote on Wed, 3 Apr 2019 10:22:39 +1100: > Hi all, >=20 > After merging the nand tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: >=20 > drivers/mtd/nand/raw/ingenic/jz4725b_bch.c: In function 'jz4725b_bch_read= _parity': > drivers/mtd/nand/raw/ingenic/jz4725b_bch.c:147:12: warning: this statemen= t may fall through [-Wimplicit-fallthrough=3D] > dest8[2] =3D (val >> 16) & 0xff; > ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~ > drivers/mtd/nand/raw/ingenic/jz4725b_bch.c:148:2: note: here > case 2: /* fall-through */ > ^~~~ > drivers/mtd/nand/raw/ingenic/jz4725b_bch.c:149:12: warning: this statemen= t may fall through [-Wimplicit-fallthrough=3D] > dest8[1] =3D (val >> 8) & 0xff; > ~~~~~~~~~^~~~~~~~~~~~~~~~~~~ > drivers/mtd/nand/raw/ingenic/jz4725b_bch.c:150:2: note: here > case 1: /* fall-through */ > ^~~~ >=20 > Introduced by commit >=20 > acb29396f956 ("mtd: rawnand: ingenic: Add support for the JZ4725B") >=20 > I get this warning because I am building with -Wimplicit-fallthrough > in attempt to catch new additions early. The gcc warning can be turned > off by adding a /* fall through */ comment at the point the fall through > happens (i.e. before the next case label). >=20 Thanks for the warnings, I moved the fall-through comments so the warnings are gone. I also added -Wextra in my "mtd-builds" setup to catch these earlier. Thanks, Miqu=C3=A8l --Sig_/qsqmeb635Ca4Dp/b1OU2MMw Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEE9HuaYnbmDhq/XIDIJWrqGEe9VoQFAlykZZsACgkQJWrqGEe9 VoTvvAf/Uq/tS1GdWpDRK0XyZf+vq8o1M/iNbQjxAFvQ5ngX0S2jyYtOi/XEePtr P8eIDADsSC23QHUqk7JoAx0fyyVKVs/MkmHiRhwN+0ILaEUIzcNuNsO8GN391WYB ucm2WlP0v7EmeWim1sC6Apk18avv4ezXdHozFLe+P52POFpdR99lYqteNMODMSCZ zppF+sbbfK0LmHh88ivWpkJKfV8Lrofo2V2BcXJaAEOYna2CRNeasRurHx1wc2/1 YdQRd0SRYWwxReXThYh4xWPZsMqcj6EdkmX+TKecK/s/BfxrykbCBbTNra172xvz YHa/Yjdt+oLkORzguxyno31pc466kA== =LNeA -----END PGP SIGNATURE----- --Sig_/qsqmeb635Ca4Dp/b1OU2MMw--