All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH 2/5] devtools/cocci: make strlcpy replacement smarter
Date: Wed,  3 Apr 2019 15:45:02 +0100	[thread overview]
Message-ID: <20190403144505.46234-3-bruce.richardson@intel.com> (raw)
In-Reply-To: <20190403144505.46234-1-bruce.richardson@intel.com>

The original coccinelle script worked by replacing instances of
snprintf(.."%s",...) with strlcpy(), but only where the source and dest
parameters were plain identifiers. Allowing expressions for those params
opens up a wide range of other possible changes.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 devtools/cocci/strlcpy.cocci | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/devtools/cocci/strlcpy.cocci b/devtools/cocci/strlcpy.cocci
index 335e27128..6f6beb697 100644
--- a/devtools/cocci/strlcpy.cocci
+++ b/devtools/cocci/strlcpy.cocci
@@ -1,6 +1,5 @@
 @use_strlcpy@
-identifier src, dst;
-expression size;
+expression src, dst, size;
 @@
 (
 - snprintf(dst, size, "%s", src)
-- 
2.20.1

  parent reply	other threads:[~2019-04-03 14:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03 14:45 [PATCH 0/5] clean up snprintf use for string copying Bruce Richardson
2019-04-03 14:45 ` [PATCH 1/5] net/bonding: fix buffer length when printing strings Bruce Richardson
2019-04-03 15:47   ` Stephen Hemminger
2019-04-03 15:51     ` Bruce Richardson
2019-04-03 15:53       ` Stephen Hemminger
2019-04-03 14:45 ` Bruce Richardson [this message]
2019-04-03 14:45 ` [PATCH 3/5] devtools/cocci: create safer version of strlcpy script Bruce Richardson
2019-04-03 14:45 ` [PATCH 4/5] replace snprintf with strlcpy without adding extra include Bruce Richardson
2019-04-03 15:51   ` Stephen Hemminger
2019-04-03 15:56     ` Bruce Richardson
2019-04-04 18:05       ` Thomas Monjalon
2019-04-03 14:45 ` [PATCH 5/5] replace snprintf with strlcpy Bruce Richardson
2019-04-03 14:57 ` [PATCH 0/5] clean up snprintf use for string copying Wiles, Keith
2019-04-03 15:13   ` Bruce Richardson
2019-04-03 15:27   ` Stephen Hemminger
2019-04-04 20:11 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190403144505.46234-3-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.