From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Sasha Levin <sashal@kernel.org>,
robh+dt@kernel.org, mark.rutland@arm.com, peterhuewe@gmx.de,
jgg@ziepe.ca,
Microsoft Linux Kernel List <linux-kernel@microsoft.com>,
"Bryan Kelly (CSI)" <bryankel@microsoft.com>,
Thirupathaiah Annapureddy <thiruan@microsoft.com>,
Sudhakar Evuri <suredd@microsoft.com>,
arnd@arndb.de, gregkh@linuxfoundation.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH 2/2] ftpm: firmware TPM running in TEE
Date: Wed, 3 Apr 2019 21:19:36 +0300 [thread overview]
Message-ID: <20190403181936.GC17006@linux.intel.com> (raw)
In-Reply-To: <20190402135643.02443863@shemminger-XPS-13-9360>
On Tue, Apr 02, 2019 at 01:56:43PM -0700, Stephen Hemminger wrote:
> On Tue, 2 Apr 2019 12:33:16 -0700
> "Sasha Levin" <sashal@kernel.org> wrote:
>
> > +/*
> > + * ftpm_tee_tpm_op_recv retrieve fTPM response.
> > + * @param: chip, the tpm_chip description as specified in
> > driver/char/tpm/tpm.h.
> > + * @param: buf, the buffer to store data.
> > + * @param: count, the number of bytes to read.
> > + * @return: In case of success the number of bytes received.
> > + * In other case, a < 0 value describing the issue.
> > + */
>
> You are using a docbook style comment but it doesn't start with
> docbook prefix.
>
> /**
> * ftpm_tee_tpm_op_recv retrieve fTPM response.
> *
> * @param: chip, the tpm_chip description as specified in driver/char/tpm/tpm.h.
> * @param: buf, the buffer to store data.
> * @param: count, the number of bytes to read.
> * @return: In case of success the number of bytes received.
> * In other case, a < 0 value describing the issue.
> */
This is different commenting style that we use on anything else
under drivers/char/tpm.
/Jarkko
next prev parent reply other threads:[~2019-04-03 18:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 19:33 [PATCH 1/2] ftpm: dt-binding: add dts documentation for fTPM driver Sasha Levin
2019-04-02 19:33 ` [PATCH 2/2] ftpm: firmware TPM running in TEE Sasha Levin
2019-04-02 20:56 ` Stephen Hemminger
2019-04-02 20:56 ` Stephen Hemminger
2019-04-03 18:19 ` Jarkko Sakkinen [this message]
2019-04-03 12:40 ` Jason Gunthorpe
2019-04-03 18:18 ` Jarkko Sakkinen
2019-04-03 18:27 ` Jarkko Sakkinen
2019-04-06 15:30 ` Sasha Levin
2019-04-10 11:29 ` Jarkko Sakkinen
2019-04-10 16:04 ` Sasha Levin
2019-04-10 17:38 ` Jarkko Sakkinen
2019-04-02 19:37 ` [PATCH 1/2] ftpm: dt-binding: add dts documentation for fTPM driver Greg KH
2019-04-02 20:03 ` Sasha Levin
2019-04-03 18:15 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403181936.GC17006@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bryankel@microsoft.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peterhuewe@gmx.de \
--cc=robh+dt@kernel.org \
--cc=sashal@kernel.org \
--cc=stephen@networkplumber.org \
--cc=suredd@microsoft.com \
--cc=thiruan@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.