From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=8ckQ=SF=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 0177FC4360F
	for <netdev@archiver.kernel.org>; Wed,  3 Apr 2019 20:47:05 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id B6B142084B
	for <netdev@archiver.kernel.org>; Wed,  3 Apr 2019 20:47:05 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="tLskkw8I"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726310AbfDCUrE (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Wed, 3 Apr 2019 16:47:04 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:49233 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726144AbfDCUrE (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 3 Apr 2019 16:47:04 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=OL7nC20QTupfR5/hQA50zpIardVvLahSZFJS4j6tpHQ=; b=tLskkw8IXfqpMNX8uGKZvGeIgK
        U+SO1I5VIocKnd1Qw4ca4QokUj3k3HOGaeuWMAvzDlsaOtHpybDamX+dAAqfCuhVKxf7OWnBeIrMf
        SKKQcU1C5gZMZ/3KgWzHdXzKeJOUNHKlxuQ8LYZMxFMXfNQbtlOQ4Gu/Yo2s6D0ll3GQ=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1hBmmg-0005Kg-Id; Wed, 03 Apr 2019 22:46:58 +0200
Date:   Wed, 3 Apr 2019 22:46:58 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Heiner Kallweit <hkallweit1@gmail.com>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 1/2] net: phy: allow a PHY driver to define
 neither features nor get_features
Message-ID: <20190403204658.GF4592@lunn.ch>
References: <a4dc471c-5301-567d-1616-73f063730512@gmail.com>
 <d177b061-a154-43d3-b20d-8ba7564772a8@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d177b061-a154-43d3-b20d-8ba7564772a8@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

> @@ -2218,9 +2223,9 @@ int phy_driver_register(struct phy_driver *new_driver, struct module *owner)
>  	/* Either the features are hard coded, or dynamically
>  	 * determine. It cannot be both or neither
>  	 */

Hi Heiner

The comment needs updating to match the code.

> -	if (WARN_ON((!new_driver->features && !new_driver->get_features) ||
> -		    (new_driver->features && new_driver->get_features))) {
> -		pr_err("%s: Driver features are missing\n", new_driver->name);
> +	if (WARN_ON(new_driver->features && new_driver->get_features)) {
> +		pr_err("%s: features and get_features must not both be set\n",
> +		       new_driver->name);
>  		return -EINVAL;

	Andrew