From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=8ckQ=SF=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 3AC3EC4360F
	for <netdev@archiver.kernel.org>; Wed,  3 Apr 2019 20:55:26 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 084FF2133D
	for <netdev@archiver.kernel.org>; Wed,  3 Apr 2019 20:55:25 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="aO8Ezpzm"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726574AbfDCUzY (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Wed, 3 Apr 2019 16:55:24 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:49250 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726151AbfDCUzY (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 3 Apr 2019 16:55:24 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=j25dLYpElUGAcsIO8mQdkKSrGvUgK45/oE4awRiYECQ=; b=aO8EzpzmNrr9dN4fJo/SpjgE5T
        5zV2AqTbmZgzXCXIfNtYy8gdHxKVJPd+nVIRROQxjdS+1vF+7UEXxlEo0HLVa8MIhMslggOsJcC1y
        K0bSg4baewk2y4nmmxR6zaH39mMrL/zmuyT+YgZ5xk1c6apyzviPXeq854g95PcQSaaA=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1hBmuo-0005Qh-11; Wed, 03 Apr 2019 22:55:22 +0200
Date:   Wed, 3 Apr 2019 22:55:21 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Heiner Kallweit <hkallweit1@gmail.com>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/2] net: phy: realtek: remove setting callback
 get_features and use phylib fallback
Message-ID: <20190403205521.GG4592@lunn.ch>
References: <a4dc471c-5301-567d-1616-73f063730512@gmail.com>
 <9881fca7-1531-ed66-e3d0-be0a9372f829@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9881fca7-1531-ed66-e3d0-be0a9372f829@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Wed, Apr 03, 2019 at 08:20:09PM +0200, Heiner Kallweit wrote:
> Now that phylib uses genphy_read_abilities() as fallback, we don't have
> to set callback get_features any longer.

Hi Heiner

I wonder how many PHY drivers we will break if we just remove
.features everywhere?

Maybe we should create patches for the Marvell driver and the Broadcom
drivers. I and Florian can test them.

	 Andrew