From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACFC5C4360F for ; Thu, 4 Apr 2019 17:45:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 83693206DD for ; Thu, 4 Apr 2019 17:45:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729166AbfDDRpN (ORCPT ); Thu, 4 Apr 2019 13:45:13 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:48696 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726698AbfDDRpN (ORCPT ); Thu, 4 Apr 2019 13:45:13 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id BC4F4146E40EA; Thu, 4 Apr 2019 10:45:12 -0700 (PDT) Date: Thu, 04 Apr 2019 10:45:12 -0700 (PDT) Message-Id: <20190404.104512.77763843856685868.davem@davemloft.net> To: lorenzo.bianconi@redhat.com Cc: netdev@vger.kernel.org, mcroce@redhat.com, vlomovtsev@marvell.com Subject: Re: [PATCH net] net: thunderx: fix NULL pointer dereference in nicvf_open/nicvf_stop From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 04 Apr 2019 10:45:12 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Lorenzo Bianconi Date: Thu, 4 Apr 2019 12:16:27 +0200 > When a bpf program is uploaded, the driver computes the number of > xdp tx queues resulting in the allocation of additional qsets. > Starting from commit '2ecbe4f4a027 ("net: thunderx: replace global > nicvf_rx_mode_wq work queue for all VFs to private for each of them")' > the driver runs link state polling for each VF resulting in the > following NULL pointer dereference: ... > Fix it by checking nicvf_rx_mode_wq pointer in nicvf_open and nicvf_stop > > Fixes: 2ecbe4f4a027 ("net: thunderx: replace global nicvf_rx_mode_wq work queue for all VFs to private for each of them") > Fixes: 2c632ad8bc74 ("net: thunderx: move link state polling function to VF") > Reported-by: Matteo Croce > Signed-off-by: Lorenzo Bianconi Applied and queued up for -stable.