From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25025C10F0E for ; Thu, 4 Apr 2019 17:50:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0476A206DD for ; Thu, 4 Apr 2019 17:50:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729594AbfDDRu1 (ORCPT ); Thu, 4 Apr 2019 13:50:27 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:48860 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728643AbfDDRu0 (ORCPT ); Thu, 4 Apr 2019 13:50:26 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 640C1146EB434; Thu, 4 Apr 2019 10:50:26 -0700 (PDT) Date: Thu, 04 Apr 2019 10:50:26 -0700 (PDT) Message-Id: <20190404.105026.1392007748486231745.davem@davemloft.net> To: pablo@netfilter.org Cc: netdev@vger.kernel.org, nikolay@cumulusnetworks.com, roopa@cumulusnetworks.com, bridge@lists.linux-foundation.org, nbd@nbd.name Subject: Re: [PATCH net-next] net: bridge: update multicast stats from maybe_deliver() From: David Miller In-Reply-To: <20190404115638.28592-1-pablo@netfilter.org> References: <20190404115638.28592-1-pablo@netfilter.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 04 Apr 2019 10:50:26 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Pablo Neira Ayuso Date: Thu, 4 Apr 2019 13:56:38 +0200 > Simplify this code by updating bridge multicast stats from > maybe_deliver(). > > Note that commit 6db6f0eae605 ("bridge: multicast to unicast"), in case > the port flag BR_MULTICAST_TO_UNICAST is set, never updates the previous > port pointer, therefore it is always going to be different from the > existing port in this deduplicated list iteration. > > Signed-off-by: Pablo Neira Ayuso Applied. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 04 Apr 2019 10:50:26 -0700 (PDT) Message-Id: <20190404.105026.1392007748486231745.davem@davemloft.net> From: David Miller In-Reply-To: <20190404115638.28592-1-pablo@netfilter.org> References: <20190404115638.28592-1-pablo@netfilter.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH net-next] net: bridge: update multicast stats from maybe_deliver() List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: pablo@netfilter.org Cc: nikolay@cumulusnetworks.com, netdev@vger.kernel.org, roopa@cumulusnetworks.com, bridge@lists.linux-foundation.org, nbd@nbd.name From: Pablo Neira Ayuso Date: Thu, 4 Apr 2019 13:56:38 +0200 > Simplify this code by updating bridge multicast stats from > maybe_deliver(). > > Note that commit 6db6f0eae605 ("bridge: multicast to unicast"), in case > the port flag BR_MULTICAST_TO_UNICAST is set, never updates the previous > port pointer, therefore it is always going to be different from the > existing port in this deduplicated list iteration. > > Signed-off-by: Pablo Neira Ayuso Applied.