From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1026CC4360F for ; Fri, 5 Apr 2019 00:18:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D15EB217D9 for ; Fri, 5 Apr 2019 00:18:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729400AbfDEASw (ORCPT ); Thu, 4 Apr 2019 20:18:52 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:54892 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727053AbfDEASw (ORCPT ); Thu, 4 Apr 2019 20:18:52 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 11ABA14733ACF; Thu, 4 Apr 2019 17:18:52 -0700 (PDT) Date: Thu, 04 Apr 2019 17:18:51 -0700 (PDT) Message-Id: <20190404.171851.2300207178008312076.davem@davemloft.net> To: cleech@redhat.com Cc: netdev@vger.kernel.org Subject: Re: [PATCH] vlan: conditional inclusion of FCoE hooks to match netdevice.h and bnx2x From: David Miller In-Reply-To: <20190402220612.1055433-1-cleech@redhat.com> References: <20190402220612.1055433-1-cleech@redhat.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 04 Apr 2019 17:18:52 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Chris Leech Date: Tue, 2 Apr 2019 15:06:12 -0700 > Way back in 3c9c36bcedd426f2be2826da43e5163de61735f7 the > ndo_fcoe_get_wwn pointer was switched from depending on CONFIG_FCOE to > CONFIG_LIBFCOE in order to allow building FCoE support into the bnx2x > driver and used by bnx2fc without including the generic software fcoe > module. > > But, FCoE is generally used over an 802.1q VLAN, and the implementation > of ndo_fcoe_get_wwn in the 8021q module was not similarly changed. The > result is that if CONFIG_FCOE is disabled, then bnz2fc cannot make a > call to ndo_fcoe_get_wwn through the 8021q interface to the underlying > bnx2x interface. The bnx2fc driver then falls back to a potentially > different mapping of Ethernet MAC to Fibre Channel WWN, creating an > incompatibility with the fabric and target configurations when compared > to the WWNs used by pre-boot firmware and differently-configured > kernels. > > So make the conditional inclusion of FCoE code in 8021q match the > conditional inclusion in netdevice.h > > Signed-off-by: Chris Leech Applied, thanks Chris.