From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A1CCC4360F for ; Fri, 5 Apr 2019 00:20:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 258AD20663 for ; Fri, 5 Apr 2019 00:20:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728966AbfDEAUI (ORCPT ); Thu, 4 Apr 2019 20:20:08 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:54914 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728727AbfDEAUH (ORCPT ); Thu, 4 Apr 2019 20:20:07 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 49DC314737688; Thu, 4 Apr 2019 17:20:07 -0700 (PDT) Date: Thu, 04 Apr 2019 17:20:06 -0700 (PDT) Message-Id: <20190404.172006.2092092064840910481.davem@davemloft.net> To: john.hurley@netronome.com Cc: jiri@mellanox.com, xiyou.wangcong@gmail.com, netdev@vger.kernel.org, vladbu@mellanox.com, oss-drivers@netronome.com Subject: Re: [PATCH net-next 1/1] net: sched: ensure tc flower reoffload takes filter ref From: David Miller In-Reply-To: <1554245600-11513-1-git-send-email-john.hurley@netronome.com> References: <1554245600-11513-1-git-send-email-john.hurley@netronome.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 04 Apr 2019 17:20:07 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: John Hurley Date: Tue, 2 Apr 2019 23:53:20 +0100 > Recent changes to TC flower remove the requirement for rtnl lock when > accessing and modifying filters. Refcounts now ensure access and deletion > do not happen concurrently. However, the reoffload function which cycles > through all filters and replays them to registered hw drivers is not > protected. > > Use the fl_get_next_filter() function to cycle the filters for reoffload > and ensure the ref taken by this function is put when done with each > filter. > > Signed-off-by: John Hurley > Reviewed-by: Jakub Kicinski Applied, thank you.