From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E46AC4360F for ; Fri, 5 Apr 2019 00:53:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA6DF2171F for ; Fri, 5 Apr 2019 00:53:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729789AbfDEAx1 (ORCPT ); Thu, 4 Apr 2019 20:53:27 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:55584 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726418AbfDEAx1 (ORCPT ); Thu, 4 Apr 2019 20:53:27 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0E3EF1473A481; Thu, 4 Apr 2019 17:53:27 -0700 (PDT) Date: Thu, 04 Apr 2019 17:53:26 -0700 (PDT) Message-Id: <20190404.175326.553696775953316967.davem@davemloft.net> To: nikolay@cumulusnetworks.com Cc: netdev@vger.kernel.org, liam.mcbirnie@boeing.com, roopa@cumulusnetworks.com, stephen@networkplumber.org, bridge@lists.linux-foundation.org Subject: Re: [PATCH net] net: bridge: always clear mcast matching struct on reports and leaves From: David Miller In-Reply-To: <20190403202724.9123-1-nikolay@cumulusnetworks.com> References: <20190403202724.9123-1-nikolay@cumulusnetworks.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 04 Apr 2019 17:53:27 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Nikolay Aleksandrov Date: Wed, 3 Apr 2019 23:27:24 +0300 > We need to be careful and always zero the whole br_ip struct when it is > used for matching since the rhashtable change. This patch fixes all the > places which didn't properly clear it which in turn might've caused > mismatches. > > Thanks for the great bug report with reproducing steps and bisection. ... > Reported-by: liam.mcbirnie@boeing.com > Fixes: 19e3a9c90c53 ("net: bridge: convert multicast to generic rhashtable") > Signed-off-by: Nikolay Aleksandrov Applied and queued up for -stable. > I will cook a selftest for this as well. Thanks in advance for this, that's great. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 04 Apr 2019 17:53:26 -0700 (PDT) Message-Id: <20190404.175326.553696775953316967.davem@davemloft.net> From: David Miller In-Reply-To: <20190403202724.9123-1-nikolay@cumulusnetworks.com> References: <20190403202724.9123-1-nikolay@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH net] net: bridge: always clear mcast matching struct on reports and leaves List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: nikolay@cumulusnetworks.com Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com, bridge@lists.linux-foundation.org, liam.mcbirnie@boeing.com From: Nikolay Aleksandrov Date: Wed, 3 Apr 2019 23:27:24 +0300 > We need to be careful and always zero the whole br_ip struct when it is > used for matching since the rhashtable change. This patch fixes all the > places which didn't properly clear it which in turn might've caused > mismatches. > > Thanks for the great bug report with reproducing steps and bisection. ... > Reported-by: liam.mcbirnie@boeing.com > Fixes: 19e3a9c90c53 ("net: bridge: convert multicast to generic rhashtable") > Signed-off-by: Nikolay Aleksandrov Applied and queued up for -stable. > I will cook a selftest for this as well. Thanks in advance for this, that's great.