From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: [PATCH] drm/i915/gvt: Prevent use-after-free in ppgtt_free_all_spt() Date: Thu, 4 Apr 2019 08:30:56 +0100 Message-ID: <20190404073056.12407-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org Cc: Changbin Du , intel-gvt-dev@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org cHBndHRfZnJlZV9hbGxfc3B0KCkgaXRlcmF0ZXMgdGhlIHJhZGl4dHJlZSBhcyBpdCBpcyBkZWxl dGluZyBpdCwKZm9yZ29pbmcgYWxsIHByb3RlY3Rpb24gYWdhaW5zdCB0aGUgbGVhdmVzIGJlaW5n IGZyZWVkIGluIHRoZSBwcm9jZXNzCihsZWF2aW5nIHRoZSBpdGVyIHBvaW50aW5nIGludG8gdGhl IHZvaWQpLgoKQSBtaW5pbWFsIGZpeCBzZWVtcyB0byBiZSB0byB1c2UgdGhlIGF2YWlsYWJsZSBw b3N0X3NoYWRvd19saXN0IHRvCmRlY29tcG9zZSB0aGUgdHJlZSBpbnRvIGEgbGlzdCBwcmlvciB0 byBkZXN0cm95aW5nIHRoZSByYWRpeHRyZWUuCgpBbGVydGVkIGJ5IHRoZSBzcGFyc2Ugd2Fybmlu Z3M6Cgpkcml2ZXJzL2dwdS9kcm0vaTkxNS9ndnQvZ3R0LmM6NzU3Ojk6IHdhcm5pbmc6IGluY29y cmVjdCB0eXBlIGluIGFzc2lnbm1lbnQgKGRpZmZlcmVudCBhZGRyZXNzIHNwYWNlcykKZHJpdmVy cy9ncHUvZHJtL2k5MTUvZ3Z0L2d0dC5jOjc1Nzo5OiAgICBleHBlY3RlZCB2b2lkICoqc2xvdApk cml2ZXJzL2dwdS9kcm0vaTkxNS9ndnQvZ3R0LmM6NzU3Ojk6ICAgIGdvdCB2b2lkIFtub2RlcmVm XSA8YXNuOjQ+ICoqCmRyaXZlcnMvZ3B1L2RybS9pOTE1L2d2dC9ndHQuYzo3NTc6OTogd2Fybmlu ZzogaW5jb3JyZWN0IHR5cGUgaW4gYXNzaWdubWVudCAoZGlmZmVyZW50IGFkZHJlc3Mgc3BhY2Vz KQpkcml2ZXJzL2dwdS9kcm0vaTkxNS9ndnQvZ3R0LmM6NzU3Ojk6ICAgIGV4cGVjdGVkIHZvaWQg KipzbG90CmRyaXZlcnMvZ3B1L2RybS9pOTE1L2d2dC9ndHQuYzo3NTc6OTogICAgZ290IHZvaWQg W25vZGVyZWZdIDxhc246ND4gKioKZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3Z0L2d0dC5jOjc1ODo0 NTogd2FybmluZzogaW5jb3JyZWN0IHR5cGUgaW4gYXJndW1lbnQgMSAoZGlmZmVyZW50IGFkZHJl c3Mgc3BhY2VzKQpkcml2ZXJzL2dwdS9kcm0vaTkxNS9ndnQvZ3R0LmM6NzU4OjQ1OiAgICBleHBl Y3RlZCB2b2lkIFtub2RlcmVmXSA8YXNuOjQ+ICoqc2xvdApkcml2ZXJzL2dwdS9kcm0vaTkxNS9n dnQvZ3R0LmM6NzU4OjQ1OiAgICBnb3Qgdm9pZCAqKnNsb3QKZHJpdmVycy9ncHUvZHJtL2k5MTUv Z3Z0L2d0dC5jOjc1Nzo5OiB3YXJuaW5nOiBpbmNvcnJlY3QgdHlwZSBpbiBhcmd1bWVudCAxIChk aWZmZXJlbnQgYWRkcmVzcyBzcGFjZXMpCmRyaXZlcnMvZ3B1L2RybS9pOTE1L2d2dC9ndHQuYzo3 NTc6OTogICAgZXhwZWN0ZWQgdm9pZCBbbm9kZXJlZl0gPGFzbjo0PiAqKnNsb3QKZHJpdmVycy9n cHUvZHJtL2k5MTUvZ3Z0L2d0dC5jOjc1Nzo5OiAgICBnb3Qgdm9pZCAqKnNsb3QKZHJpdmVycy9n cHUvZHJtL2k5MTUvZ3Z0L2d0dC5jOjc1Nzo5OiB3YXJuaW5nOiBpbmNvcnJlY3QgdHlwZSBpbiBh c3NpZ25tZW50IChkaWZmZXJlbnQgYWRkcmVzcyBzcGFjZXMpCmRyaXZlcnMvZ3B1L2RybS9pOTE1 L2d2dC9ndHQuYzo3NTc6OTogICAgZXhwZWN0ZWQgdm9pZCAqKnNsb3QKZHJpdmVycy9ncHUvZHJt L2k5MTUvZ3Z0L2d0dC5jOjc1Nzo5OiAgICBnb3Qgdm9pZCBbbm9kZXJlZl0gPGFzbjo0PiAqKgoK VGhpcyB3b3VsZCBhbHNvIGhhdmUgYmVlbiBsb3VkbHkgd2FybmluZyBpZiBydW4gdGhyb3VnaCBD SSBmb3IgdGhlCmludmFsaWQgUkNVIGRlcmVmZXJlbmNlcy4KCkZpeGVzOiBiNmMxMjZhMzkzNDUg KCJkcm0vaTkxNS9ndnQ6IE1hbmFnZSBzaGFkb3cgcGFnZXMgd2l0aCByYWRpeCB0cmVlIikKU2ln bmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+CkNjOiBD aGFuZ2JpbiBEdSA8Y2hhbmdiaW4uZHVAaW50ZWwuY29tPgpDYzogWmhlbnl1IFdhbmcgPHpoZW55 dXdAbGludXguaW50ZWwuY29tPgpDYzogWmhpIFdhbmcgPHpoaS5hLndhbmdAaW50ZWwuY29tPgot LS0KIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2d2dC9ndHQuYyB8IDEyICsrKysrKysrKy0tLQogMSBm aWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndnQvZ3R0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9n dnQvZ3R0LmMKaW5kZXggY2YxMzNlZjAzODczLi45ODE0NzczODgyZWMgMTAwNjQ0Ci0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2d2dC9ndHQuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9n dnQvZ3R0LmMKQEAgLTc1MCwxNCArNzUwLDIwIEBAIHN0YXRpYyB2b2lkIHBwZ3R0X2ZyZWVfc3B0 KHN0cnVjdCBpbnRlbF92Z3B1X3BwZ3R0X3NwdCAqc3B0KQogCiBzdGF0aWMgdm9pZCBwcGd0dF9m cmVlX2FsbF9zcHQoc3RydWN0IGludGVsX3ZncHUgKnZncHUpCiB7Ci0Jc3RydWN0IGludGVsX3Zn cHVfcHBndHRfc3B0ICpzcHQ7CisJc3RydWN0IGludGVsX3ZncHVfcHBndHRfc3B0ICpzcHQsICpz cG47CiAJc3RydWN0IHJhZGl4X3RyZWVfaXRlciBpdGVyOwotCXZvaWQgKipzbG90OworCUxJU1Rf SEVBRChhbGxfc3B0KTsKKwl2b2lkIF9fcmN1ICoqc2xvdDsKIAorCXJjdV9yZWFkX2xvY2soKTsK IAlyYWRpeF90cmVlX2Zvcl9lYWNoX3Nsb3Qoc2xvdCwgJnZncHUtPmd0dC5zcHRfdHJlZSwgJml0 ZXIsIDApIHsKIAkJc3B0ID0gcmFkaXhfdHJlZV9kZXJlZl9zbG90KHNsb3QpOwotCQlwcGd0dF9m cmVlX3NwdChzcHQpOworCQlsaXN0X21vdmUoJnNwdC0+cG9zdF9zaGFkb3dfbGlzdCwgJmFsbF9z cHQpOwogCX0KKwlyY3VfcmVhZF91bmxvY2soKTsKKworCWxpc3RfZm9yX2VhY2hfZW50cnlfc2Fm ZShzcHQsIHNwbiwgJmFsbF9zcHQsIHBvc3Rfc2hhZG93X2xpc3QpCisJCXBwZ3R0X2ZyZWVfc3B0 KHNwdCk7CiB9CiAKIHN0YXRpYyBpbnQgcHBndHRfaGFuZGxlX2d1ZXN0X3dyaXRlX3BhZ2VfdGFi bGVfYnl0ZXMoCi0tIAoyLjIwLjEKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeA==